Changeset 106838 in webkit


Ignore:
Timestamp:
Feb 6, 2012 1:01:28 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Source/WebKit2: [GTK] Fix remaining errors in GTK+ WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=77890

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Fix some style issues in the GTK+ WebKit2 API section of the source code.

  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:
  • UIProcess/API/gtk/tests/TestMain.h:

Tools: [GTK] Fix remaining errors in GTK+ WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=77890

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Verify that WebKit2 GTK+ test files are not skipped during style checks.
Skip soup_server_new when checking for NULL versus 0 usage.

  • Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherSkipTest.test_should_skip_with_warning):

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_for_null):

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r106836 r106838  
     12012-02-06  Martin Robinson  <mrobinson@igalia.com>
     2
     3         [GTK] Fix remaining errors in GTK+ WebKit2 API
     4        https://bugs.webkit.org/show_bug.cgi?id=77890
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        Fix some style issues in the GTK+ WebKit2 API section of the source code.
     9
     10        * UIProcess/API/gtk/WebKitPrivate.h:
     11        * UIProcess/API/gtk/WebKitWebView.cpp:
     12        * UIProcess/API/gtk/tests/TestMain.h:
     13
    1142012-02-06  Matthew Delaney  <mdelaney@apple.com>
    215

  • trunk/Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h

    r106142 r106838  
    3434#include <wtf/Assertions.h>
    3535
    36 #define WEBKIT_PARAM_READABLE (static_cast<GParamFlags>(G_PARAM_READABLE|G_PARAM_STATIC_NAME|G_PARAM_STATIC_NICK|G_PARAM_STATIC_BLURB))
    37 #define WEBKIT_PARAM_WRITABLE (static_cast<GParamFlags>(G_PARAM_WRITABLE|G_PARAM_STATIC_NAME|G_PARAM_STATIC_NICK|G_PARAM_STATIC_BLURB))
    38 #define WEBKIT_PARAM_READWRITE (static_cast<GParamFlags>(G_PARAM_READWRITE|G_PARAM_STATIC_NAME|G_PARAM_STATIC_NICK|G_PARAM_STATIC_BLURB))
     36#define WEBKIT_PARAM_READABLE (static_cast<GParamFlags>(G_PARAM_READABLE | G_PARAM_STATIC_NAME | G_PARAM_STATIC_NICK | G_PARAM_STATIC_BLURB))
     37#define WEBKIT_PARAM_WRITABLE (static_cast<GParamFlags>(G_PARAM_WRITABLE | G_PARAM_STATIC_NAME | G_PARAM_STATIC_NICK | G_PARAM_STATIC_BLURB))
     38#define WEBKIT_PARAM_READWRITE (static_cast<GParamFlags>(G_PARAM_READWRITE | G_PARAM_STATIC_NAME | G_PARAM_STATIC_NICK | G_PARAM_STATIC_BLURB))
    3939
    4040#define COMPILE_ASSERT_MATCHING_ENUM(webkitName, webcoreName) \

  • trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp

    r106559 r106838  
    2828#include "WebKitMarshal.h"
    2929#include "WebKitPolicyClient.h"
     30#include "WebKitPrivate.h"
    3031#include "WebKitSettingsPrivate.h"
    3132#include "WebKitUIClient.h"
    … …  
    3435#include "WebKitWebViewPrivate.h"
    3536#include "WebKitWindowPropertiesPrivate.h"
    36 #include "WebKitPrivate.h"
    3737#include "WebPageProxy.h"
    3838#include <WebCore/DragIcon.h>

  • trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h

    r98245 r106838  
    2121#define TestMain_h
    2222
    23 #include <glib-object.h>
    2423#include <JavaScriptCore/GOwnPtr.h>
    2524#include <JavaScriptCore/HashSet.h>
     25#include <glib-object.h>
    2626
    2727#define MAKE_GLIB_TEST_FIXTURE(ClassName) \
    … …  
    4040    }
    4141
    42 class Test
    43 {
     42class Test {
    4443public:
    4544    MAKE_GLIB_TEST_FIXTURE(Test);

  • trunk/Tools/ChangeLog

    r106832 r106838  
     12012-02-06  Martin Robinson  <mrobinson@igalia.com>
     2
     3        [GTK] Fix remaining errors in GTK+ WebKit2 API
     4        https://bugs.webkit.org/show_bug.cgi?id=77890
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        Verify that WebKit2 GTK+ test files are not skipped during style checks.
     9        Skip soup_server_new when checking for NULL versus 0 usage.
     10
     11        * Scripts/webkitpy/style/checker_unittest.py:
     12        (CheckerDispatcherSkipTest.test_should_skip_with_warning):
     13        * Scripts/webkitpy/style/checkers/cpp.py:
     14        (check_for_null):
     15
    1162012-02-06  Eric Seidel  <eric@webkit.org>
    217

  • trunk/Tools/Scripts/webkitpy/style/checker_unittest.py

    r106814 r106838  
    319319           "Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp",
    320320           "Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h",
     321           "Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp",
     322           "Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h",
    321323            ]
    322324

  • trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py

    r105652 r106838  
    24132413    # Don't warn about NULL usage in gtk_widget_style_get(). See Bug 51758.
    24142414    if search(r'\bgtk_widget_style_get\(\w+\b', line):
     2415        return
     2416
     2417    # Don't warn about NULL usage in soup_server_new(). See Bug 77890.
     2418    if search(r'\bsoup_server_new\(\w+\b', line):
    24152419        return
    24162420
Note: See TracChangeset for help on using the changeset viewer.