Changeset 106864 in webkit

Timestamp:

Feb 6, 2012 3:23:43 PM (12 years ago)

Author:

crogers@google.com

Message:

zvmul incorrectly multiplies complex arrays on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=77900

Reviewed by Kenneth Russell.

Source/WebCore:

• platform/audio/VectorMath.cpp:

(WebCore::VectorMath::zvmul):

LayoutTests:

• platform/chromium/test_expectations.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/test_expectations.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/audio/VectorMath.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-06  Chris Rogers  <crogers@google.com>
+
+        zvmul incorrectly multiplies complex arrays on Windows.
+        https://bugs.webkit.org/show_bug.cgi?id=77900
+
+        Reviewed by Kenneth Russell.
+
+        * platform/chromium/test_expectations.txt:
+
 2012-02-06  Ami Fischman  <fischman@chromium.org>
 

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -3762 +3762 @@
 BUGWK75932 : fast/js/mozilla/strict/15.4.4.6.html = TEXT
 
-BUGWK75933 WIN : webaudio/convolution-mono-mono.html = TEXT
-
 BUGWK76280 : media/W3C/video/networkState/networkState_during_progress.html = PASS TEXT
 BUGV81900 SLOW LINUX DEBUG : inspector/debugger/watch-expressions-panel-switch.html = PASS CRASH

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-06  Chris Rogers  <crogers@google.com>
+
+        zvmul incorrectly multiplies complex arrays on Windows.
+        https://bugs.webkit.org/show_bug.cgi?id=77900
+
+        Reviewed by Kenneth Russell.
+
+        * platform/audio/VectorMath.cpp:
+        (WebCore::VectorMath::zvmul):
+
 2012-02-06  Andreas Kling  <awesomekling@apple.com>
 

trunk/Source/WebCore/platform/audio/VectorMath.cpp

@@ -419 +419 @@
 #endif
     for (; i < framesToProcess; ++i) {
-        realDestP[i] = real1P[i] * real2P[i] - imag1P[i] * imag2P[i];
-        imagDestP[i] = real1P[i] * imag2P[i] + imag1P[i] * real2P[i];
+        // Read and compute result before storing them, in case the
+        // destination is the same as one of the sources.
+        float realResult = real1P[i] * real2P[i] - imag1P[i] * imag2P[i];
+        float imagResult = real1P[i] * imag2P[i] + imag1P[i] * real2P[i];
+
+        realDestP[i] = realResult;
+        imagDestP[i] = imagResult;
     }
 }