Changeset 106874 in webkit

Timestamp:

Feb 6, 2012 4:41:31 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

postMessage leaks MemoryEvent object
​https://bugs.webkit.org/show_bug.cgi?id=77893

Patch by Greg Simon <​gregsimon@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

Changed from PassRefPtr().leakRef() to RefPtr.get() when
calling into FrameLoaderClient to stop +1 extra ref.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DOMWindow.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-06  Greg Simon  <gregsimon@chromium.org>
+
+        postMessage leaks MemoryEvent object
+        https://bugs.webkit.org/show_bug.cgi?id=77893
+
+        Reviewed by Adam Barth.
+
+        Changed from PassRefPtr().leakRef() to RefPtr.get() when 
+        calling into FrameLoaderClient to stop +1 extra ref.
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::postMessageTimerFired):
+
 2012-02-06  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
 

trunk/Source/WebCore/page/DOMWindow.cpp

@@ -875 +875 @@
     // DOMWindow might be a proxy for another in browsers that support
     // postMessage calls across WebKit instances.
-    if (isCurrentlyDisplayedInFrame() && m_frame->loader()->client()->willCheckAndDispatchMessageEvent(timer->targetOrigin(), PassRefPtr<MessageEvent>(event).leakRef()))
+    if (isCurrentlyDisplayedInFrame() && m_frame->loader()->client()->willCheckAndDispatchMessageEvent(timer->targetOrigin(), event.get()))
         return;