Changeset 106883 in webkit


Ignore:
Timestamp:
Feb 6, 2012 5:33:27 PM (12 years ago)
Author:
haraken@chromium.org
Message:

Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
​https://bugs.webkit.org/show_bug.cgi?id=77852

Reviewed by Adam Barth.

This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.

[DontCheckEnums] => [DoNotCheckConstants] (This IDL inserts assertions to check if a
constant value is equal to the expected constant value)
[ReturnsNew] => [ReturnNewObject] (For clarification)
[DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
with other [*Getter] IDLs)
[DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
with other [*Setter] IDLs)
[ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
name in implementation)

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/DOMCoreException.idl:
  • dom/Document.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • html/HTMLFormElement.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • inspector/JavaScriptCallFrame.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • storage/IDBCursor.idl:
  • storage/IDBDatabaseException.idl:
  • storage/IDBObjectStore.idl:
  • storage/SQLException.idl:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGException.idl:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGGradientElement.idl:
  • xml/XMLHttpRequestException.idl:
Location:
trunk/Source/WebCore
Files:
54 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r106882 r106883  
     12012-02-05  Kentaro Hara  <haraken@chromium.org>
     2
     3        Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
     4        [DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
     5        https://bugs.webkit.org/show_bug.cgi?id=77852
     6
     7        Reviewed by Adam Barth.
     8
     9        This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
     10        [DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.
     11
     12        [DontCheckEnums] => [DoNotCheckConstants]  (This IDL inserts assertions to check if a
     13        constant value is equal to the expected constant value)
     14        [ReturnsNew] => [ReturnNewObject] (For clarification)
     15        [DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
     16        with other [*Getter] IDLs)
     17        [DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
     18        with other [*Setter] IDLs)
     19        [ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
     20        name in implementation)
     21
     22        No tests. No change in behavior.
     23
     24        * bindings/scripts/CodeGenerator.pm:
     25        (ShouldCheckEnums):
     26        (GenerateCompileTimeCheckForEnumsIfNeeded):
     27        * bindings/scripts/CodeGeneratorJS.pm:
     28        (GenerateHeader):
     29        (GenerateImplementation):
     30        (NativeToJSValue):
     31        * bindings/scripts/CodeGeneratorV8.pm:
     32        (GenerateSingleBatchedAttribute):
     33        (GenerateFunctionCallString):
     34        (NativeToJSValue):
     35
     36        * bindings/scripts/test/TestObj.idl:
     37        * bindings/scripts/test/TestTypedArray.idl:
     38
     39        * bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.
     40        (WebCore):
     41        * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
     42        (WebCore):
     43        * bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
     44        (WebCore):
     45        * bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
     46        (WebCore):
     47
     48        * bindings/scripts/test/TestObj.idl:
     49        * bindings/scripts/test/TestTypedArray.idl:
     50        * css/WebKitCSSFilterValue.idl:
     51        * css/WebKitCSSTransformValue.idl:
     52        * dom/DOMCoreException.idl:
     53        * dom/Document.idl:
     54        * dom/EventException.idl:
     55        * dom/RangeException.idl:
     56        * fileapi/FileException.idl:
     57        * fileapi/OperationNotAllowedException.idl:
     58        * html/HTMLFormElement.idl:
     59        * html/canvas/Float32Array.idl:
     60        * html/canvas/Float64Array.idl:
     61        * html/canvas/Int16Array.idl:
     62        * html/canvas/Int32Array.idl:
     63        * html/canvas/Int8Array.idl:
     64        * html/canvas/OESStandardDerivatives.idl:
     65        * html/canvas/OESVertexArrayObject.idl:
     66        * html/canvas/Uint16Array.idl:
     67        * html/canvas/Uint32Array.idl:
     68        * html/canvas/Uint8Array.idl:
     69        * html/canvas/Uint8ClampedArray.idl:
     70        * html/canvas/WebGLCompressedTextures.idl:
     71        * html/canvas/WebGLDebugRendererInfo.idl:
     72        * html/canvas/WebGLRenderingContext.idl:
     73        * inspector/JavaScriptCallFrame.idl:
     74        * loader/appcache/DOMApplicationCache.idl:
     75        * page/Console.idl:
     76        * page/DOMWindow.idl:
     77        * page/Location.idl:
     78        * storage/IDBCursor.idl:
     79        * storage/IDBDatabaseException.idl:
     80        * storage/IDBObjectStore.idl:
     81        * storage/SQLException.idl:
     82        * svg/SVGComponentTransferFunctionElement.idl:
     83        * svg/SVGException.idl:
     84        * svg/SVGFEBlendElement.idl:
     85        * svg/SVGFEColorMatrixElement.idl:
     86        * svg/SVGFECompositeElement.idl:
     87        * svg/SVGFEConvolveMatrixElement.idl:
     88        * svg/SVGFEDisplacementMapElement.idl:
     89        * svg/SVGFEMorphologyElement.idl:
     90        * svg/SVGFETurbulenceElement.idl:
     91        * svg/SVGGradientElement.idl:
     92        * xml/XMLHttpRequestException.idl:
     93
    1942012-02-06  Stephen Chenney  <schenney@chromium.org>
    295

  • trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm

    r106528 r106883  
    590590{
    591591    my $dataNode = shift;
    592     return not $dataNode->extendedAttributes->{"DontCheckEnums"};
     592    return not $dataNode->extendedAttributes->{"DoNotCheckConstants"};
    593593}
    594594
    … …  
    628628            }
    629629
    630             push(@checks, "COMPILE_ASSERT($value == ${interfaceName}::$name, ${interfaceName}Enum${name}IsWrongUseDontCheckEnums);\n");
     630            push(@checks, "COMPILE_ASSERT($value == ${interfaceName}::$name, ${interfaceName}Enum${name}IsWrongUseDoNotCheckConstants);\n");
    631631
    632632            if ($conditional) {

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r106798 r106883  
    892892            next unless $function->signature->extendedAttributes->{"Custom"} or $function->signature->extendedAttributes->{"JSCustom"};
    893893            next if $function->{overloads} && $function->{overloadIndex} != 1;
    894             my $functionImplementationName = $function->signature->extendedAttributes->{"ImplementationFunction"} || $codeGenerator->WK_lcfirst($function->signature->name);
     894            my $functionImplementationName = $function->signature->extendedAttributes->{"ImplementedAs"} || $codeGenerator->WK_lcfirst($function->signature->name);
    895895            push(@headerContent, "    JSC::JSValue " . $functionImplementationName . "(JSC::ExecState*);\n");
    896896        }
    … …  
    16851685                if ($dataNode->extendedAttributes->{"CheckDomainSecurity"} &&
    16861686                        !$attribute->signature->extendedAttributes->{"DoNotCheckDomainSecurity"} &&
    1687                         !$attribute->signature->extendedAttributes->{"DoNotCheckDomainSecurityOnGet"}) {
     1687                        !$attribute->signature->extendedAttributes->{"DoNotCheckDomainSecurityOnGetter"}) {
    16881688                    push(@implContent, "    if (!castedThis->allowsAccessFrom(exec))\n");
    16891689                    push(@implContent, "        return jsUndefined();\n");
    … …  
    20752075            }
    20762076
    2077             my $functionImplementationName = $function->signature->extendedAttributes->{"ImplementationFunction"} || $codeGenerator->WK_lcfirst($function->signature->name);
     2077            my $functionImplementationName = $function->signature->extendedAttributes->{"ImplementedAs"} || $codeGenerator->WK_lcfirst($function->signature->name);
    20782078
    20792079            push(@implContent, "EncodedJSValue JSC_HOST_CALL ${functionName}(ExecState* exec)\n");
    … …  
    29932993    return $value if $codeGenerator->IsSVGAnimatedType($type);
    29942994
    2995     if ($signature->extendedAttributes->{"ReturnsNew"}) {       
     2995    if ($signature->extendedAttributes->{"ReturnNewObject"}) {
    29962996        return "toJSNewlyCreated(exec, $globalObject, WTF::getPtr($value))";
    29972997    }

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r106827 r106883  
    19331933
    19341934    my $accessControl = "v8::DEFAULT";
    1935     if ($attrExt->{"DoNotCheckDomainSecurityOnGet"}) {
     1935    if ($attrExt->{"DoNotCheckDomainSecurityOnGetter"}) {
    19361936        $accessControl = "v8::ALL_CAN_READ";
    1937     } elsif ($attrExt->{"DoNotCheckDomainSecurityOnSet"}) {
     1937    } elsif ($attrExt->{"DoNotCheckDomainSecurityOnSetter"}) {
    19381938        $accessControl = "v8::ALL_CAN_WRITE";
    19391939    } elsif ($attrExt->{"DoNotCheckDomainSecurity"}) {
    … …  
    31853185    $nativeReturnType = $codeGenerator->GetSVGWrappedTypeNeedingTearOff($returnType) if $isSVGTearOffType;
    31863186
    3187     if ($function->signature->extendedAttributes->{"ImplementationFunction"}) {
    3188         $name = $function->signature->extendedAttributes->{"ImplementationFunction"};
     3187    if ($function->signature->extendedAttributes->{"ImplementedAs"}) {
     3188        $name = $function->signature->extendedAttributes->{"ImplementedAs"};
    31893189    }
    31903190
    … …  
    37393739    # special case for non-DOM node interfaces
    37403740    if (IsDOMNodeType($type)) {
    3741         return "toV8(${value}" . ($signature->extendedAttributes->{"ReturnsNew"} ? ", true)" : ")");
     3741        return "toV8(${value}" . ($signature->extendedAttributes->{"ReturnNewObject"} ? ", true)" : ")");
    37423742    }
    37433743

  • trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp

    r106140 r106883  
    8181
    8282#if ENABLE(Condition11) || ENABLE(Condition12)
    83 COMPILE_ASSERT(1 == TestInterface::SUPPLEMENTALCONSTANT1, TestInterfaceEnumSUPPLEMENTALCONSTANT1IsWrongUseDontCheckEnums);
    84 #endif
    85 #if ENABLE(Condition11) || ENABLE(Condition12)
    86 COMPILE_ASSERT(2 == TestInterface::CONST_IMPL, TestInterfaceEnumCONST_IMPLIsWrongUseDontCheckEnums);
     83COMPILE_ASSERT(1 == TestInterface::SUPPLEMENTALCONSTANT1, TestInterfaceEnumSUPPLEMENTALCONSTANT1IsWrongUseDoNotCheckConstants);
     84#endif
     85#if ENABLE(Condition11) || ENABLE(Condition12)
     86COMPILE_ASSERT(2 == TestInterface::CONST_IMPL, TestInterfaceEnumCONST_IMPLIsWrongUseDoNotCheckConstants);
    8787#endif
    8888

  • trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp

    r106618 r106883  
    173173
    174174#if ENABLE(Condition1)
    175 COMPILE_ASSERT(0 == TestObj::CONDITIONAL_CONST, TestObjEnumCONDITIONAL_CONSTIsWrongUseDontCheckEnums);
    176 #endif
    177 COMPILE_ASSERT(0 == TestObj::CONST_VALUE_0, TestObjEnumCONST_VALUE_0IsWrongUseDontCheckEnums);
    178 COMPILE_ASSERT(1 == TestObj::CONST_VALUE_1, TestObjEnumCONST_VALUE_1IsWrongUseDontCheckEnums);
    179 COMPILE_ASSERT(2 == TestObj::CONST_VALUE_2, TestObjEnumCONST_VALUE_2IsWrongUseDontCheckEnums);
    180 COMPILE_ASSERT(4 == TestObj::CONST_VALUE_4, TestObjEnumCONST_VALUE_4IsWrongUseDontCheckEnums);
    181 COMPILE_ASSERT(8 == TestObj::CONST_VALUE_8, TestObjEnumCONST_VALUE_8IsWrongUseDontCheckEnums);
    182 COMPILE_ASSERT(-1 == TestObj::CONST_VALUE_9, TestObjEnumCONST_VALUE_9IsWrongUseDontCheckEnums);
    183 COMPILE_ASSERT("my constant string" == TestObj::CONST_VALUE_10, TestObjEnumCONST_VALUE_10IsWrongUseDontCheckEnums);
    184 COMPILE_ASSERT(0xffffffff == TestObj::CONST_VALUE_11, TestObjEnumCONST_VALUE_11IsWrongUseDontCheckEnums);
    185 COMPILE_ASSERT(0x01 == TestObj::CONST_VALUE_12, TestObjEnumCONST_VALUE_12IsWrongUseDontCheckEnums);
    186 COMPILE_ASSERT(0X20 == TestObj::CONST_VALUE_13, TestObjEnumCONST_VALUE_13IsWrongUseDontCheckEnums);
    187 COMPILE_ASSERT(0x1abc == TestObj::CONST_VALUE_14, TestObjEnumCONST_VALUE_14IsWrongUseDontCheckEnums);
    188 COMPILE_ASSERT(15 == TestObj::CONST_IMPL, TestObjEnumCONST_IMPLIsWrongUseDontCheckEnums);
     175COMPILE_ASSERT(0 == TestObj::CONDITIONAL_CONST, TestObjEnumCONDITIONAL_CONSTIsWrongUseDoNotCheckConstants);
     176#endif
     177COMPILE_ASSERT(0 == TestObj::CONST_VALUE_0, TestObjEnumCONST_VALUE_0IsWrongUseDoNotCheckConstants);
     178COMPILE_ASSERT(1 == TestObj::CONST_VALUE_1, TestObjEnumCONST_VALUE_1IsWrongUseDoNotCheckConstants);
     179COMPILE_ASSERT(2 == TestObj::CONST_VALUE_2, TestObjEnumCONST_VALUE_2IsWrongUseDoNotCheckConstants);
     180COMPILE_ASSERT(4 == TestObj::CONST_VALUE_4, TestObjEnumCONST_VALUE_4IsWrongUseDoNotCheckConstants);
     181COMPILE_ASSERT(8 == TestObj::CONST_VALUE_8, TestObjEnumCONST_VALUE_8IsWrongUseDoNotCheckConstants);
     182COMPILE_ASSERT(-1 == TestObj::CONST_VALUE_9, TestObjEnumCONST_VALUE_9IsWrongUseDoNotCheckConstants);
     183COMPILE_ASSERT("my constant string" == TestObj::CONST_VALUE_10, TestObjEnumCONST_VALUE_10IsWrongUseDoNotCheckConstants);
     184COMPILE_ASSERT(0xffffffff == TestObj::CONST_VALUE_11, TestObjEnumCONST_VALUE_11IsWrongUseDoNotCheckConstants);
     185COMPILE_ASSERT(0x01 == TestObj::CONST_VALUE_12, TestObjEnumCONST_VALUE_12IsWrongUseDoNotCheckConstants);
     186COMPILE_ASSERT(0X20 == TestObj::CONST_VALUE_13, TestObjEnumCONST_VALUE_13IsWrongUseDoNotCheckConstants);
     187COMPILE_ASSERT(0x1abc == TestObj::CONST_VALUE_14, TestObjEnumCONST_VALUE_14IsWrongUseDoNotCheckConstants);
     188COMPILE_ASSERT(15 == TestObj::CONST_IMPL, TestObjEnumCONST_IMPLIsWrongUseDoNotCheckConstants);
    189189
    190190ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSTestObjConstructor);

  • trunk/Source/WebCore/bindings/scripts/test/TestObj.idl

    r106776 r106883  
    200200        [Immutable] SVGPoint immutablePointFunction();
    201201
    202         [ImplementationFunction=banana] void orange();
     202        [ImplementedAs=banana] void orange();
    203203
    204204        attribute [StrictTypeChecking] float strictFloat;

  • trunk/Source/WebCore/bindings/scripts/test/TestTypedArray.idl

    r106798 r106883  
    3333        JSNoStaticTables,
    3434        JSCustomToJS,
    35         DontCheckEnums
     35        DoNotCheckConstants
    3636    ] Float64Array : ArrayBufferView {
    3737        Int32Array foo(in Float32Array array);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp

    r106140 r106883  
    158158
    159159#if ENABLE(Condition11) || ENABLE(Condition12)
    160 COMPILE_ASSERT(1 == TestInterface::SUPPLEMENTALCONSTANT1, TestInterfaceEnumSUPPLEMENTALCONSTANT1IsWrongUseDontCheckEnums);
    161 #endif
    162 #if ENABLE(Condition11) || ENABLE(Condition12)
    163 COMPILE_ASSERT(2 == TestInterface::CONST_IMPL, TestInterfaceEnumCONST_IMPLIsWrongUseDontCheckEnums);
     160COMPILE_ASSERT(1 == TestInterface::SUPPLEMENTALCONSTANT1, TestInterfaceEnumSUPPLEMENTALCONSTANT1IsWrongUseDoNotCheckConstants);
     161#endif
     162#if ENABLE(Condition11) || ENABLE(Condition12)
     163COMPILE_ASSERT(2 == TestInterface::CONST_IMPL, TestInterfaceEnumCONST_IMPLIsWrongUseDoNotCheckConstants);
    164164#endif
    165165

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp

    r106666 r106883  
    17171717
    17181718#if ENABLE(Condition1)
    1719 COMPILE_ASSERT(0 == TestObj::CONDITIONAL_CONST, TestObjEnumCONDITIONAL_CONSTIsWrongUseDontCheckEnums);
     1719COMPILE_ASSERT(0 == TestObj::CONDITIONAL_CONST, TestObjEnumCONDITIONAL_CONSTIsWrongUseDoNotCheckConstants);
    17201720#endif
    1721 COMPILE_ASSERT(0 == TestObj::CONST_VALUE_0, TestObjEnumCONST_VALUE_0IsWrongUseDontCheckEnums);
    1722 COMPILE_ASSERT(1 == TestObj::CONST_VALUE_1, TestObjEnumCONST_VALUE_1IsWrongUseDontCheckEnums);
    1723 COMPILE_ASSERT(2 == TestObj::CONST_VALUE_2, TestObjEnumCONST_VALUE_2IsWrongUseDontCheckEnums);
    1724 COMPILE_ASSERT(4 == TestObj::CONST_VALUE_4, TestObjEnumCONST_VALUE_4IsWrongUseDontCheckEnums);
    1725 COMPILE_ASSERT(8 == TestObj::CONST_VALUE_8, TestObjEnumCONST_VALUE_8IsWrongUseDontCheckEnums);
    1726 COMPILE_ASSERT(-1 == TestObj::CONST_VALUE_9, TestObjEnumCONST_VALUE_9IsWrongUseDontCheckEnums);
    1727 COMPILE_ASSERT("my constant string" == TestObj::CONST_VALUE_10, TestObjEnumCONST_VALUE_10IsWrongUseDontCheckEnums);
    1728 COMPILE_ASSERT(0xffffffff == TestObj::CONST_VALUE_11, TestObjEnumCONST_VALUE_11IsWrongUseDontCheckEnums);
    1729 COMPILE_ASSERT(0x01 == TestObj::CONST_VALUE_12, TestObjEnumCONST_VALUE_12IsWrongUseDontCheckEnums);
    1730 COMPILE_ASSERT(0X20 == TestObj::CONST_VALUE_13, TestObjEnumCONST_VALUE_13IsWrongUseDontCheckEnums);
    1731 COMPILE_ASSERT(0x1abc == TestObj::CONST_VALUE_14, TestObjEnumCONST_VALUE_14IsWrongUseDontCheckEnums);
    1732 COMPILE_ASSERT(15 == TestObj::CONST_IMPL, TestObjEnumCONST_IMPLIsWrongUseDontCheckEnums);
     1721COMPILE_ASSERT(0 == TestObj::CONST_VALUE_0, TestObjEnumCONST_VALUE_0IsWrongUseDoNotCheckConstants);
     1722COMPILE_ASSERT(1 == TestObj::CONST_VALUE_1, TestObjEnumCONST_VALUE_1IsWrongUseDoNotCheckConstants);
     1723COMPILE_ASSERT(2 == TestObj::CONST_VALUE_2, TestObjEnumCONST_VALUE_2IsWrongUseDoNotCheckConstants);
     1724COMPILE_ASSERT(4 == TestObj::CONST_VALUE_4, TestObjEnumCONST_VALUE_4IsWrongUseDoNotCheckConstants);
     1725COMPILE_ASSERT(8 == TestObj::CONST_VALUE_8, TestObjEnumCONST_VALUE_8IsWrongUseDoNotCheckConstants);
     1726COMPILE_ASSERT(-1 == TestObj::CONST_VALUE_9, TestObjEnumCONST_VALUE_9IsWrongUseDoNotCheckConstants);
     1727COMPILE_ASSERT("my constant string" == TestObj::CONST_VALUE_10, TestObjEnumCONST_VALUE_10IsWrongUseDoNotCheckConstants);
     1728COMPILE_ASSERT(0xffffffff == TestObj::CONST_VALUE_11, TestObjEnumCONST_VALUE_11IsWrongUseDoNotCheckConstants);
     1729COMPILE_ASSERT(0x01 == TestObj::CONST_VALUE_12, TestObjEnumCONST_VALUE_12IsWrongUseDoNotCheckConstants);
     1730COMPILE_ASSERT(0X20 == TestObj::CONST_VALUE_13, TestObjEnumCONST_VALUE_13IsWrongUseDoNotCheckConstants);
     1731COMPILE_ASSERT(0x1abc == TestObj::CONST_VALUE_14, TestObjEnumCONST_VALUE_14IsWrongUseDoNotCheckConstants);
     1732COMPILE_ASSERT(15 == TestObj::CONST_IMPL, TestObjEnumCONST_IMPLIsWrongUseDoNotCheckConstants);
    17331733
    17341734v8::Handle<v8::Value> V8TestObj::constructorCallback(const v8::Arguments& args)

  • trunk/Source/WebCore/css/WebKitCSSFilterValue.idl

    r106798 r106883  
    2929            Conditional=CSS_FILTERS,
    3030            IndexedGetter,
    31             DontCheckEnums
     31            DoNotCheckConstants
    3232    ] WebKitCSSFilterValue : CSSValueList {
    3333

  • trunk/Source/WebCore/css/WebKitCSSTransformValue.idl

    r106798 r106883  
    3131    interface [
    3232            IndexedGetter,
    33             DontCheckEnums
     33            DoNotCheckConstants
    3434    ] WebKitCSSTransformValue : CSSValueList {
    3535

  • trunk/Source/WebCore/dom/DOMCoreException.idl

    r106737 r106883  
    3131    interface [
    3232        JSNoStaticTables,
    33         DontCheckEnums
     33        DoNotCheckConstants
    3434    ] DOMCoreException {
    3535

  • trunk/Source/WebCore/dom/Document.idl

    r106776 r106883  
    3232        readonly attribute Element documentElement;
    3333
    34         [ReturnsNew] Element createElement(in [TreatNullAs=NullString,Optional=CallWithDefaultValue] DOMString tagName)
     34        [ReturnNewObject] Element createElement(in [TreatNullAs=NullString,Optional=CallWithDefaultValue] DOMString tagName)
    3535            raises (DOMException);
    3636        DocumentFragment   createDocumentFragment();
    37         [ReturnsNew] Text createTextNode(in [Optional=CallWithDefaultValue] DOMString data);
    38         [ReturnsNew] Comment createComment(in [Optional=CallWithDefaultValue] DOMString data);
    39         [ReturnsNew] CDATASection createCDATASection(in [Optional=CallWithDefaultValue] DOMString data)
    40             raises(DOMException);
    41         [ObjCLegacyUnnamedParameters, ReturnsNew] ProcessingInstruction createProcessingInstruction(in [Optional=CallWithDefaultValue] DOMString target,
     37        [ReturnNewObject] Text createTextNode(in [Optional=CallWithDefaultValue] DOMString data);
     38        [ReturnNewObject] Comment createComment(in [Optional=CallWithDefaultValue] DOMString data);
     39        [ReturnNewObject] CDATASection createCDATASection(in [Optional=CallWithDefaultValue] DOMString data)
     40            raises(DOMException);
     41        [ObjCLegacyUnnamedParameters, ReturnNewObject] ProcessingInstruction createProcessingInstruction(in [Optional=CallWithDefaultValue] DOMString target,
    4242                                                                                     in [Optional=CallWithDefaultValue] DOMString data)
    4343            raises (DOMException);
    44         [ReturnsNew] Attr createAttribute(in [Optional=CallWithDefaultValue] DOMString name)
    45             raises (DOMException);
    46         [ReturnsNew] EntityReference createEntityReference(in [Optional=CallWithDefaultValue] DOMString name)
     44        [ReturnNewObject] Attr createAttribute(in [Optional=CallWithDefaultValue] DOMString name)
     45            raises (DOMException);
     46        [ReturnNewObject] EntityReference createEntityReference(in [Optional=CallWithDefaultValue] DOMString name)
    4747            raises(DOMException);
    4848        NodeList           getElementsByTagName(in [Optional=CallWithDefaultValue] DOMString tagname);
    … …  
    5050        // Introduced in DOM Level 2:
    5151
    52         [ObjCLegacyUnnamedParameters, ReturnsNew] Node importNode(in [Optional=CallWithDefaultValue] Node importedNode,
     52        [ObjCLegacyUnnamedParameters, ReturnNewObject] Node importNode(in [Optional=CallWithDefaultValue] Node importedNode,
    5353                                                   in [Optional] boolean deep)
    5454            raises (DOMException);
     55<<<<<<< HEAD
    5556        [ObjCLegacyUnnamedParameters, ReturnsNew] Element createElementNS(in [TreatNullAs=NullString,Optional=CallWithDefaultValue] DOMString namespaceURI,
    5657                                                           in [TreatNullAs=NullString,Optional=CallWithDefaultValue] DOMString qualifiedName)
    … …  
    5859        [ObjCLegacyUnnamedParameters, ReturnsNew] Attr createAttributeNS(in [TreatNullAs=NullString,Optional=CallWithDefaultValue] DOMString namespaceURI,
    5960                                                          in [TreatNullAs=NullString,Optional=CallWithDefaultValue] DOMString qualifiedName)
     61=======
     62        [ObjCLegacyUnnamedParameters, ReturnNewObject] Element createElementNS(in [TreatNullAs=EmptyString,Optional=CallWithDefaultValue] DOMString namespaceURI,
     63                                                           in [TreatNullAs=EmptyString,Optional=CallWithDefaultValue] DOMString qualifiedName)
     64            raises (DOMException);
     65        [ObjCLegacyUnnamedParameters, ReturnNewObject] Attr createAttributeNS(in [TreatNullAs=EmptyString,Optional=CallWithDefaultValue] DOMString namespaceURI,
     66                                                          in [TreatNullAs=EmptyString,Optional=CallWithDefaultValue] DOMString qualifiedName)
     67>>>>>>> temp
    6068            raises (DOMException);
    6169        [ObjCLegacyUnnamedParameters] NodeList getElementsByTagNameNS(in [TreatNullAs=NullString,Optional=CallWithDefaultValue] DOMString namespaceURI,
    … …  
    326334
    327335#if defined(ENABLE_TOUCH_EVENTS) && ENABLE_TOUCH_EVENTS
    328         [ReturnsNew, V8EnabledAtRuntime] Touch createTouch(in [Optional=CallWithDefaultValue] DOMWindow window,
     336        [ReturnNewObject, V8EnabledAtRuntime] Touch createTouch(in [Optional=CallWithDefaultValue] DOMWindow window,
    329337                                                         in [Optional=CallWithDefaultValue] EventTarget target,
    330338                                                         in [Optional=CallWithDefaultValue] long identifier,
    … …  
    338346                                                         in [Optional=CallWithDefaultValue] float webkitForce)
    339347            raises (DOMException);
    340         [ReturnsNew, V8EnabledAtRuntime, Custom] TouchList createTouchList()
     348        [ReturnNewObject, V8EnabledAtRuntime, Custom] TouchList createTouchList()
    341349            raises (DOMException);
    342350#endif

  • trunk/Source/WebCore/dom/EventException.idl

    r106737 r106883  
    3232    interface [
    3333        JSNoStaticTables,
    34         DontCheckEnums
     34        DoNotCheckConstants
    3535    ] EventException {
    3636

  • trunk/Source/WebCore/dom/RangeException.idl

    r106645 r106883  
    2121
    2222    interface [
    23         DontCheckEnums
     23        DoNotCheckConstants
    2424    ] RangeException {
    2525

  • trunk/Source/WebCore/fileapi/FileException.idl

    r106737 r106883  
    3232    interface [
    3333        Conditional=BLOB|FILE_SYSTEM,
    34         DontCheckEnums,
     34        DoNotCheckConstants,
    3535        JSNoStaticTables
    3636    ] FileException {

  • trunk/Source/WebCore/fileapi/OperationNotAllowedException.idl

    r106737 r106883  
    3232    interface [
    3333        Conditional=BLOB|FILE_SYSTEM,
    34         DontCheckEnums,
     34        DoNotCheckConstants,
    3535        JSNoStaticTables
    3636    ] OperationNotAllowedException {

  • trunk/Source/WebCore/html/HTMLFormElement.idl

    r106798 r106883  
    3939       
    4040#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
    41         [ImplementationFunction=submitFromJavaScript] void submit();
     41        [ImplementedAs=submitFromJavaScript] void submit();
    4242#else
    4343        void submit();

  • trunk/Source/WebCore/html/canvas/Float32Array.idl

    r106798 r106883  
    3333        JSNoStaticTables,
    3434        JSCustomToJS,
    35         DontCheckEnums
     35        DoNotCheckConstants
    3636    ] Float32Array : ArrayBufferView {
    3737        const unsigned int BYTES_PER_ELEMENT = 4;

  • trunk/Source/WebCore/html/canvas/Float64Array.idl

    r106798 r106883  
    3333        JSNoStaticTables,
    3434        JSCustomToJS,
    35         DontCheckEnums
     35        DoNotCheckConstants
    3636    ] Float64Array : ArrayBufferView {
    3737        const unsigned int BYTES_PER_ELEMENT = 8;

  • trunk/Source/WebCore/html/canvas/Int16Array.idl

    r106798 r106883  
    3232        JSNoStaticTables,
    3333        JSCustomToJS,
    34         DontCheckEnums
     34        DoNotCheckConstants
    3535    ] Int16Array : ArrayBufferView {
    3636        const unsigned int BYTES_PER_ELEMENT = 2;

  • trunk/Source/WebCore/html/canvas/Int32Array.idl

    r106798 r106883  
    3333        JSNoStaticTables,
    3434        JSCustomToJS,
    35         DontCheckEnums
     35        DoNotCheckConstants
    3636    ] Int32Array : ArrayBufferView {
    3737        const unsigned int BYTES_PER_ELEMENT = 4;

  • trunk/Source/WebCore/html/canvas/Int8Array.idl

    r106798 r106883  
    3333        JSNoStaticTables,
    3434        JSCustomToJS,
    35         DontCheckEnums
     35        DoNotCheckConstants
    3636    ] Int8Array : ArrayBufferView {
    3737        const unsigned int BYTES_PER_ELEMENT = 1;

  • trunk/Source/WebCore/html/canvas/OESStandardDerivatives.idl

    r106737 r106883  
    2929        JSGenerateIsReachable=ImplContext,
    3030        OmitConstructor,
    31         DontCheckEnums
     31        DoNotCheckConstants
    3232    ] OESStandardDerivatives {
    3333        const unsigned int FRAGMENT_SHADER_DERIVATIVE_HINT_OES = 0x8B8B;

  • trunk/Source/WebCore/html/canvas/OESVertexArrayObject.idl

    r106737 r106883  
    2929        JSGenerateIsReachable=ImplContext,
    3030        OmitConstructor,
    31         DontCheckEnums
     31        DoNotCheckConstants
    3232    ] OESVertexArrayObject {
    3333        const unsigned int VERTEX_ARRAY_BINDING_OES = 0x85B5;

  • trunk/Source/WebCore/html/canvas/Uint16Array.idl

    r106798 r106883  
    3333        JSNoStaticTables,
    3434        JSCustomToJS,
    35         DontCheckEnums
     35        DoNotCheckConstants
    3636    ] Uint16Array : ArrayBufferView {
    3737        const unsigned int BYTES_PER_ELEMENT = 2;

  • trunk/Source/WebCore/html/canvas/Uint32Array.idl

    r106798 r106883  
    3333        JSNoStaticTables,
    3434        JSCustomToJS,
    35         DontCheckEnums
     35        DoNotCheckConstants
    3636    ] Uint32Array : ArrayBufferView {
    3737        const unsigned int BYTES_PER_ELEMENT = 4;

  • trunk/Source/WebCore/html/canvas/Uint8Array.idl

    r106798 r106883  
    3333        JSNoStaticTables,
    3434        JSCustomToJS,
    35         DontCheckEnums
     35        DoNotCheckConstants
    3636    ] Uint8Array : ArrayBufferView {
    3737        const unsigned int BYTES_PER_ELEMENT = 1;

  • trunk/Source/WebCore/html/canvas/Uint8ClampedArray.idl

    r106798 r106883  
    3333        JSNoStaticTables,
    3434        JSCustomToJS,
    35         DontCheckEnums
     35        DoNotCheckConstants
    3636    ] Uint8ClampedArray : Uint8Array {
    3737        const unsigned int BYTES_PER_ELEMENT = 1;

  • trunk/Source/WebCore/html/canvas/WebGLCompressedTextures.idl

    r106737 r106883  
    2929        JSGenerateIsReachable=ImplContext,
    3030        OmitConstructor,
    31         DontCheckEnums
     31        DoNotCheckConstants
    3232    ] WebGLCompressedTextures {
    3333        /* Compressed Texture Formats */

  • trunk/Source/WebCore/html/canvas/WebGLDebugRendererInfo.idl

    r106737 r106883  
    2929        JSGenerateIsReachable=ImplContext,
    3030        OmitConstructor,
    31         DontCheckEnums
     31        DoNotCheckConstants
    3232    ] WebGLDebugRendererInfo {
    3333        const unsigned int UNMASKED_VENDOR_WEBGL = 0x9245;

  • trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl

    r106737 r106883  
    2929        Conditional=WEBGL,
    3030        JSCustomMarkFunction,
    31         DontCheckEnums
     31        DoNotCheckConstants
    3232    ] WebGLRenderingContext : CanvasRenderingContext {
    3333

  • trunk/Source/WebCore/inspector/JavaScriptCallFrame.idl

    r98750 r106883  
    2929        Conditional=JAVASCRIPT_DEBUGGER,
    3030        OmitConstructor,
    31         DontCheckEnums
     31        DoNotCheckConstants
    3232    ] JavaScriptCallFrame {
    3333

  • trunk/Source/WebCore/loader/appcache/DOMApplicationCache.idl

    r106737 r106883  
    2929        EventTarget,
    3030        OmitConstructor,
    31         DontCheckEnums,
     31        DoNotCheckConstants,
    3232        JSGenerateIsReachable=ImplFrame
    3333    ] DOMApplicationCache {

  • trunk/Source/WebCore/page/Console.idl

    r106776 r106883  
    4242        [CustomArgumentHandling] void dirxml();
    4343        [V8Custom, CustomArgumentHandling] void trace();
    44         [V8Custom, CustomArgumentHandling, ImplementationFunction=assertCondition] void assert(in boolean condition);
     44        [V8Custom, CustomArgumentHandling, ImplementedAs=assertCondition] void assert(in boolean condition);
    4545        [CustomArgumentHandling] void count();
    4646        [CustomArgumentHandling] void markTimeline();

  • trunk/Source/WebCore/page/DOMWindow.idl

    r106783 r106883  
    4444        // DOM Level 0
    4545        attribute [Replaceable] Screen screen;
    46         attribute [Replaceable, DoNotCheckDomainSecurityOnGet, JSCustomGetter] History history;
     46        attribute [Replaceable, DoNotCheckDomainSecurityOnGetter, JSCustomGetter] History history;
    4747        attribute [Replaceable] BarInfo locationbar;
    4848        attribute [Replaceable] BarInfo menubar;
    … …  
    116116        readonly attribute [DoNotCheckDomainSecurity] boolean closed;
    117117
    118         attribute [Replaceable, DoNotCheckDomainSecurityOnGet] unsigned long length;
     118        attribute [Replaceable, DoNotCheckDomainSecurityOnGetter] unsigned long length;
    119119
    120120        attribute DOMString name;
    … …  
    128128
    129129        // Self referential attributes
    130         attribute [Replaceable, DoNotCheckDomainSecurityOnGet] DOMWindow self;
     130        attribute [Replaceable, DoNotCheckDomainSecurityOnGetter] DOMWindow self;
    131131        readonly attribute [DoNotCheckDomainSecurity, V8Unforgeable] DOMWindow window;
    132         attribute [Replaceable, DoNotCheckDomainSecurityOnGet] DOMWindow frames;
    133 
    134         attribute [Replaceable, DoNotCheckDomainSecurityOnGet, V8CustomSetter] DOMWindow opener;
    135         attribute [Replaceable, DoNotCheckDomainSecurityOnGet] DOMWindow parent;
    136         attribute [Replaceable, DoNotCheckDomainSecurityOnGet, V8Unforgeable, V8ReadOnly] DOMWindow top;
     132        attribute [Replaceable, DoNotCheckDomainSecurityOnGetter] DOMWindow frames;
     133
     134        attribute [Replaceable, DoNotCheckDomainSecurityOnGetter, V8CustomSetter] DOMWindow opener;
     135        attribute [Replaceable, DoNotCheckDomainSecurityOnGetter] DOMWindow parent;
     136        attribute [Replaceable, DoNotCheckDomainSecurityOnGetter, V8Unforgeable, V8ReadOnly] DOMWindow top;
    137137
    138138        // DOM Level 2 AbstractView Interface

  • trunk/Source/WebCore/page/Location.idl

    r106783 r106883  
    4444    ] Location {
    4545#if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
    46                  attribute [DoNotCheckDomainSecurityOnSet, CustomSetter, V8Unforgeable] DOMString href;
     46                 attribute [DoNotCheckDomainSecurityOnSetter, CustomSetter, V8Unforgeable] DOMString href;
    4747#endif
    4848
    … …  
    6565
    6666#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
    67         [NotEnumerable, Custom, V8OnInstance, V8ReadOnly, ImplementationFunction=toStringFunction] DOMString toString();
     67        [NotEnumerable, Custom, V8OnInstance, V8ReadOnly, ImplementedAs=toStringFunction] DOMString toString();
    6868#endif
    6969#if defined(V8_BINDING) && V8_BINDING

  • trunk/Source/WebCore/storage/IDBCursor.idl

    r89375 r106883  
    4141        [CallWith=ScriptExecutionContext] IDBRequest update(in SerializedScriptValue value)
    4242            raises (IDBDatabaseException);
    43         [ImplementationFunction=continueFunction] void continue(in [Optional] IDBKey key)
     43        [ImplementedAs=continueFunction] void continue(in [Optional] IDBKey key)
    4444            raises (IDBDatabaseException);
    45         [CallWith=ScriptExecutionContext, ImplementationFunction=deleteFunction] IDBRequest delete()
     45        [CallWith=ScriptExecutionContext, ImplementedAs=deleteFunction] IDBRequest delete()
    4646            raises (IDBDatabaseException);
    4747    };

  • trunk/Source/WebCore/storage/IDBDatabaseException.idl

    r106645 r106883  
    2828    interface [
    2929        Conditional=INDEXED_DATABASE,
    30         DontCheckEnums
     30        DoNotCheckConstants
    3131    ] IDBDatabaseException {
    3232

  • trunk/Source/WebCore/storage/IDBObjectStore.idl

    r103100 r106883  
    3838        [CallWith=ScriptExecutionContext] IDBRequest add(in SerializedScriptValue value, in [Optional] IDBKey key)
    3939            raises (IDBDatabaseException);
    40         [CallWith=ScriptExecutionContext, ImplementationFunction=deleteFunction] IDBRequest delete(in IDBKey key)
     40        [CallWith=ScriptExecutionContext, ImplementedAs=deleteFunction] IDBRequest delete(in IDBKey key)
    4141            raises (IDBDatabaseException);
    4242        [CallWith=ScriptExecutionContext] IDBRequest clear()

  • trunk/Source/WebCore/storage/SQLException.idl

    r106737 r106883  
    3434        Conditional=SQL_DATABASE,
    3535        JSNoStaticTables,
    36         DontCheckEnums
     36        DoNotCheckConstants
    3737    ] SQLException {
    3838        readonly attribute unsigned long code;

  • trunk/Source/WebCore/svg/SVGComponentTransferFunctionElement.idl

    r89269 r106883  
    2828    interface [
    2929        Conditional=SVG&FILTERS,
    30         DontCheckEnums
     30        DoNotCheckConstants
    3131    ] SVGComponentTransferFunctionElement : SVGElement {
    3232        // Component Transfer Types

  • trunk/Source/WebCore/svg/SVGException.idl

    r106645 r106883  
    2323    interface [
    2424        Conditional=SVG,
    25         DontCheckEnums
     25        DoNotCheckConstants
    2626    ] SVGException {
    2727

  • trunk/Source/WebCore/svg/SVGFEBlendElement.idl

    r89269 r106883  
    2828    interface [
    2929        Conditional=SVG&FILTERS,
    30         DontCheckEnums
     30        DoNotCheckConstants
    3131    ] SVGFEBlendElement : SVGElement,
    3232                          SVGFilterPrimitiveStandardAttributes {

  • trunk/Source/WebCore/svg/SVGFEColorMatrixElement.idl

    r89269 r106883  
    2828    interface [
    2929        Conditional=SVG&FILTERS,
    30         DontCheckEnums
     30        DoNotCheckConstants
    3131    ] SVGFEColorMatrixElement : SVGElement,
    3232                                SVGFilterPrimitiveStandardAttributes {

  • trunk/Source/WebCore/svg/SVGFECompositeElement.idl

    r89269 r106883  
    2828    interface [
    2929        Conditional=SVG&FILTERS,
    30         DontCheckEnums
     30        DoNotCheckConstants
    3131    ] SVGFECompositeElement : SVGElement,
    3232                              SVGFilterPrimitiveStandardAttributes {

  • trunk/Source/WebCore/svg/SVGFEConvolveMatrixElement.idl

    r106532 r106883  
    2828    interface [
    2929        Conditional=SVG&FILTERS,
    30         DontCheckEnums
     30        DoNotCheckConstants
    3131    ] SVGFEConvolveMatrixElement : SVGElement,
    3232                                   SVGFilterPrimitiveStandardAttributes {

  • trunk/Source/WebCore/svg/SVGFEDisplacementMapElement.idl

    r89269 r106883  
    2828    interface [
    2929        Conditional=SVG&FILTERS,
    30         DontCheckEnums
     30        DoNotCheckConstants
    3131    ] SVGFEDisplacementMapElement : SVGElement,
    3232                                    SVGFilterPrimitiveStandardAttributes {

  • trunk/Source/WebCore/svg/SVGFEMorphologyElement.idl

    r92237 r106883  
    2828    interface [
    2929        Conditional=SVG&FILTERS,
    30         DontCheckEnums
     30        DoNotCheckConstants
    3131    ] SVGFEMorphologyElement : SVGElement,
    3232                               SVGFilterPrimitiveStandardAttributes {

  • trunk/Source/WebCore/svg/SVGFETurbulenceElement.idl

    r89269 r106883  
    2828    interface [
    2929        Conditional=SVG&FILTERS,
    30         DontCheckEnums
     30        DoNotCheckConstants
    3131    ] SVGFETurbulenceElement : SVGElement,
    3232                               SVGFilterPrimitiveStandardAttributes {

  • trunk/Source/WebCore/svg/SVGGradientElement.idl

    r89269 r106883  
    2828    interface [
    2929        Conditional=SVG,
    30         DontCheckEnums
     30        DoNotCheckConstants
    3131    ] SVGGradientElement : SVGElement,
    3232                           SVGURIReference,

  • trunk/Source/WebCore/xml/XMLHttpRequestException.idl

    r106737 r106883  
    3131    interface [
    3232        JSNoStaticTables,
    33         DontCheckEnums
     33        DoNotCheckConstants
    3434    ] XMLHttpRequestException {
    3535

  • trunk/Source/WebCore/xml/XPathException.idl

    r106645 r106883  
    3030
    3131    interface [
    32         DontCheckEnums
     32        DoNotCheckConstants
    3333    ] XPathException {
    3434
Note: See TracChangeset for help on using the changeset viewer.