Changeset 106890 in webkit

Timestamp:

Feb 6, 2012 6:21:09 PM (12 years ago)

Author:

rniwa@webkit.org

Message:

Perf-o-matic should show min/max/stdev on graphs
​https://bugs.webkit.org/show_bug.cgi?id=77702

Reviewed by Andreas Kling.

Include min/max/stdev in test runs when available to be shown on the perf-o-matic.

Also merge a change to config.js and increment the version number by 1 (unreviewed).

• Websites/webkit-perf.appspot.com/app.yaml:
• Websites/webkit-perf.appspot.com/js/config.js:
• Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.get):

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Websites/webkit-perf.appspot.com/app.yaml (modified) (1 diff)
• Websites/webkit-perf.appspot.com/js/config.js (modified) (1 diff)
• Websites/webkit-perf.appspot.com/runs_handler.py (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2012-02-06  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Perf-o-matic should show min/max/stdev on graphs
+        https://bugs.webkit.org/show_bug.cgi?id=77702
+
+        Reviewed by Andreas Kling.
+
+        Include min/max/stdev in test runs when available to be shown on the perf-o-matic.
+
+        Also merge a change to config.js and increment the version number by 1 (unreviewed).
+
+        * Websites/webkit-perf.appspot.com/app.yaml:
+        * Websites/webkit-perf.appspot.com/js/config.js:
+        * Websites/webkit-perf.appspot.com/runs_handler.py:
+        (RunsHandler.get):
+
 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Websites/webkit-perf.appspot.com/app.yaml

@@ -1 +1 @@
 application: webkit-perf
-version: 10
+version: 11
 runtime: python27
 api_version: 1

trunk/Websites/webkit-perf.appspot.com/js/config.js

@@ -16 +16 @@
 var IMAGE_SERVER = SERVER;
 
-var LIGHT_COLORS = $.map(COLORS, function(color) {
-    return $.color.parse(color).add('a', -.5).toString();
-});
+if ($.color) {
+    var LIGHT_COLORS = $.map(COLORS, function(color) {
+        return $.color.parse(color).add('a', -.5).toString();
+    });
+}
 
 var PLOT_OPTIONS = {

trunk/Websites/webkit-perf.appspot.com/runs_handler.py

@@ -86 +86 @@
                 builderId = build.builder.key().id()
                 posixTimestamp = mktime(build.timestamp.timetuple())
+                statistics = None
+                if result.valueStdev != None and result.valueMin != None and result.valueMax != None:
+                    statistics = {'stdev': result.valueStdev, 'min': result.valueMin, 'max': result.valueMax}
                 test_runs.append([result.key().id(),
                     [build.key().id(), build.buildNumber, build.revision],
-                    posixTimestamp, result.value, 0, [], builderId])
+                    posixTimestamp, result.value, 0,  # runNumber
+                    [],  # annotations
+                    builderId, statistics])
                 # FIXME: Calculate the average; in practice, we wouldn't have more than one value for a given revision
                 averages[build.revision] = result.value