Changeset 106896 in webkit


Ignore:
Timestamp:
Feb 6, 2012 7:52:01 PM (12 years ago)
Author:
abarth@webkit.org
Message:

http/tests/security/mixedContent/insecure-script-in-iframe.html flaky in chromium debug
​https://bugs.webkit.org/show_bug.cgi?id=65567

Reviewed by Eric Seidel.

My theory is that the extra log message is caused by the preload
scanner requesting the script, which might occur if the test is running
extremely slowly (as it might on a debug bot).

This patch simplifies the test in the hopes of removing the flakiness.

  • http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
  • http/tests/security/mixedContent/insecure-script-in-iframe.html:
  • http/tests/security/mixedContent/resources/frame-with-insecure-script.html:
  • platform/chromium/test_expectations.txt:
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r106894 r106896  
     12012-02-06  Adam Barth  <abarth@webkit.org>
     2
     3        http/tests/security/mixedContent/insecure-script-in-iframe.html flaky in chromium debug
     4        https://bugs.webkit.org/show_bug.cgi?id=65567
     5
     6        Reviewed by Eric Seidel.
     7
     8        My theory is that the extra log message is caused by the preload
     9        scanner requesting the script, which might occur if the test is running
     10        extremely slowly (as it might on a debug bot).
     11
     12        This patch simplifies the test in the hopes of removing the flakiness.
     13
     14        * http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
     15        * http/tests/security/mixedContent/insecure-script-in-iframe.html:
     16        * http/tests/security/mixedContent/resources/frame-with-insecure-script.html:
     17        * platform/chromium/test_expectations.txt:
     18
    1192012-02-06  Adam Barth  <abarth@webkit.org>
    220

  • trunk/LayoutTests/http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt

    r104803 r106896  
    1 frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
    2 main frame - didFinishDocumentLoadForFrame
    3 frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
    41CONSOLE MESSAGE: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-script.html ran insecure content from http://127.0.0.1:8080/security/mixedContent/resources/script.js.
    52
    6 didRunInsecureContent
    7 frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
    8 frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
    9 main frame - didHandleOnloadEventsForFrame
    10 frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
    11 main frame - didFinishLoadForFrame
    123This test loads a secure iframe that loads an insecure script. We should trigger a mixed content callback even though the main frame is HTTP because the HTTPS frame's origin is contaminated with an insecure script.
    134

  • trunk/LayoutTests/http/tests/security/mixedContent/insecure-script-in-iframe.html

    r48284 r106896  
    22<body>
    33<script>
    4 if (window.layoutTestController) {
     4if (window.layoutTestController)
    55    layoutTestController.dumpAsText();
    6     layoutTestController.dumpFrameLoadCallbacks();
    7 }
    86</script>
    97<p>This test loads a secure iframe that loads an insecure script.  We should
    108trigger a mixed content callback even though the main frame is HTTP because the
    119HTTPS frame's origin is contaminated with an insecure script.</p>
    12 <iframe src="https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-script.html";
    13 ></iframe>
     10<iframe src="https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-script.html"></iframe>
    1411</body>
    1512</html>

  • trunk/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-script.html

    r88377 r106896  
    1 <body onload="frameLoaded()">
     1<script src="http://127.0.0.1:8080/security/mixedContent/resources/script.js"></script>
    22<script>
    3 function frameLoaded() {
    4   if (window.opener)
    5     window.opener.postMessage('done', '*');
    6 }
     3window.onload = function() {
     4    if (window.opener)
     5        window.opener.postMessage('done', '*');
     6};
    77</script>
    8 <script src="http://127.0.0.1:8080/security/mixedContent/resources/script.js"></script>
    9 </body>

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r106894 r106896  
    773773BUGCR31342 WIN RELEASE : security/block-test-no-port.html = PASS TEXT
    774774
    775 BUGWK65567 DEBUG : http/tests/security/mixedContent/insecure-script-in-iframe.html = PASS TEXT
    776775BUGCR20345 : http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html = TEXT
    777776BUGCR42044 WIN : http/tests/security/xss-DENIED-mime-type-execute-as-html.html = PASS TIMEOUT
Note: See TracChangeset for help on using the changeset viewer.