Changeset 106926 in webkit

Timestamp:

Feb 7, 2012 4:43:10 AM (12 years ago)

Author:

loislo@chromium.org

Message:

Unreviewed, rolling out r106909.
​http://trac.webkit.org/changeset/106909
​https://bugs.webkit.org/show_bug.cgi?id=77965

~20 tests are crashing on chromium win release bot. (Requested
by loislo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-07

• html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

• html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

• html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

• html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

• html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLDetailsElement.cpp (modified) (1 diff)
• html/HTMLKeygenElement.cpp (modified) (1 diff)
• html/HTMLMeterElement.cpp (modified) (1 diff)
• html/HTMLProgressElement.cpp (modified) (1 diff)
• html/HTMLSummaryElement.cpp (modified) (1 diff)
• html/HTMLTextAreaElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-07  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r106909.
+        http://trac.webkit.org/changeset/106909
+        https://bugs.webkit.org/show_bug.cgi?id=77965
+
+        ~20 tests are crashing on chromium win release bot. (Requested
+        by loislo on #webkit).
+
+        * html/HTMLDetailsElement.cpp:
+        (WebCore::HTMLDetailsElement::createShadowSubtree):
+        * html/HTMLKeygenElement.cpp:
+        (WebCore::HTMLKeygenElement::HTMLKeygenElement):
+        * html/HTMLMeterElement.cpp:
+        (WebCore::HTMLMeterElement::createShadowSubtree):
+        * html/HTMLProgressElement.cpp:
+        (WebCore::HTMLProgressElement::createShadowSubtree):
+        * html/HTMLSummaryElement.cpp:
+        (WebCore::HTMLSummaryElement::createShadowSubtree):
+        * html/HTMLTextAreaElement.cpp:
+        (WebCore::HTMLTextAreaElement::createShadowSubtree):
+
 2012-02-07  Andreas Kling  <awesomekling@apple.com>
 

trunk/Source/WebCore/html/HTMLDetailsElement.cpp

@@ -110 +110 @@
 {
     ASSERT(!shadowRoot());
-
-    RefPtr<ShadowRoot> root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
-    root->appendChild(DetailsSummaryElement::create(document()), ASSERT_NO_EXCEPTION, true);
-    root->appendChild(DetailsContentElement::create(document()), ASSERT_NO_EXCEPTION, true);
+    ensureShadowRoot()->appendChild(DetailsSummaryElement::create(document()), ASSERT_NO_EXCEPTION, true);
+    ensureShadowRoot()->appendChild(DetailsContentElement::create(document()), ASSERT_NO_EXCEPTION, true);
 }
 

trunk/Source/WebCore/html/HTMLKeygenElement.cpp

@@ -86 +86 @@
     }
 
-    ASSERT(!shadowRoot());
-    RefPtr<ShadowRoot> root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
-    root->appendChild(select, ec);
+    ensureShadowRoot()->appendChild(select, ec);
 }
 

trunk/Source/WebCore/html/HTMLMeterElement.cpp

@@ -235 +235 @@
 void HTMLMeterElement::createShadowSubtree()
 {
-    ASSERT(!shadowRoot());
-
     RefPtr<MeterBarElement> bar = MeterBarElement::create(document());
     m_value = MeterValueElement::create(document());
     ExceptionCode ec = 0;
     bar->appendChild(m_value, ec);
-
-    RefPtr<ShadowRoot> root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
-    root->appendChild(bar, ec);
+    ensureShadowRoot()->appendChild(bar, ec);
 }
 

trunk/Source/WebCore/html/HTMLProgressElement.cpp

@@ -154 +154 @@
 void HTMLProgressElement::createShadowSubtree()
 {
-    ASSERT(!shadowRoot());
-
     RefPtr<ProgressBarElement> bar = ProgressBarElement::create(document());
     m_value = ProgressValueElement::create(document());
-    bar->appendChild(m_value, ASSERT_NO_EXCEPTION);
-
-    RefPtr<ShadowRoot> root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
-    root->appendChild(bar, ASSERT_NO_EXCEPTION);
+    ExceptionCode ec = 0;
+    bar->appendChild(m_value, ec);
+    ensureShadowRoot()->appendChild(bar, ec);
 }
 

trunk/Source/WebCore/html/HTMLSummaryElement.cpp

@@ -74 +74 @@
 void HTMLSummaryElement::createShadowSubtree()
 {
-    ASSERT(!shadowRoot());
-    RefPtr<ShadowRoot> root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
-    root->appendChild(DetailsMarkerControl::create(document()), ASSERT_NO_EXCEPTION, true);
-    root->appendChild(SummaryContentElement::create(document()), ASSERT_NO_EXCEPTION, true);
+    ExceptionCode ec = 0;
+    ensureShadowRoot()->appendChild(DetailsMarkerControl::create(document()), ec, true);
+    ensureShadowRoot()->appendChild(SummaryContentElement::create(document()), ec, true);
 }
 

trunk/Source/WebCore/html/HTMLTextAreaElement.cpp

@@ -85 +85 @@
 void HTMLTextAreaElement::createShadowSubtree()
 {
-    ASSERT(!shadowRoot());
-    RefPtr<ShadowRoot> root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
-    root->appendChild(TextControlInnerTextElement::create(document()), ASSERT_NO_EXCEPTION);
+    ExceptionCode ec = 0;
+    ensureShadowRoot()->appendChild(TextControlInnerTextElement::create(document()), ec);
 }