Changeset 106991 in webkit

Timestamp:

Feb 7, 2012 2:18:29 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

IndexedDB createIndex should fail if options arg is invalid
​https://bugs.webkit.org/show_bug.cgi?id=58467

Patch by Eugene Girard <​girard@chromium.org> on 2012-02-07
Reviewed by Tony Chang.

This ticket was fixed as part of ​https://bugs.webkit.org/show_bug.cgi?id=58471
Adding unit tests to verify correct operation.

• storage/indexeddb/index-basics-expected.txt:
• storage/indexeddb/index-basics-workers-expected.txt:
• storage/indexeddb/resources/index-basics.js:

(deleteExisting):

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• storage/indexeddb/index-basics-expected.txt (modified) (1 diff)
• storage/indexeddb/index-basics-workers-expected.txt (modified) (1 diff)
• storage/indexeddb/resources/index-basics.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-07  Eugene Girard  <girard@chromium.org>
+
+        IndexedDB createIndex should fail if options arg is invalid
+        https://bugs.webkit.org/show_bug.cgi?id=58467
+
+        Reviewed by Tony Chang.
+
+        This ticket was fixed as part of https://bugs.webkit.org/show_bug.cgi?id=58471
+        Adding unit tests to verify correct operation.
+
+        * storage/indexeddb/index-basics-expected.txt:
+        * storage/indexeddb/index-basics-workers-expected.txt:
+        * storage/indexeddb/resources/index-basics.js:
+        (deleteExisting):
+
 2012-02-07  Julien Chaffraix  <jchaffraix@webkit.org>
 

trunk/LayoutTests/storage/indexeddb/index-basics-expected.txt

@@ -15 +15 @@
 store.createIndex('indexName2', 'y', {unique: false})
 store.createIndex('zIndex', 'z', {unique: true})
+PASS indexObject2.unique is false
+PASS indexObject3.unique is true
+Expecting TypeError exception from store.createIndex('failureIndex', 'zzz', true)
+PASS Exception was thrown.
+PASS store.createIndex('failureIndex', 'zzz', true) threw TypeError: Not an object.
+Expecting TypeError exception from store.createIndex('failureIndex', 'zzz', 'string')
+PASS Exception was thrown.
+PASS store.createIndex('failureIndex', 'zzz', 'string') threw TypeError: Not an object.
 PASS 'name' in indexObject is true
 PASS indexObject.name is "indexName"

trunk/LayoutTests/storage/indexeddb/index-basics-workers-expected.txt

@@ -16 +16 @@
 [Worker] store.createIndex('indexName2', 'y', {unique: false})
 [Worker] store.createIndex('zIndex', 'z', {unique: true})
+PASS [Worker] indexObject2.unique is false
+PASS [Worker] indexObject3.unique is true
+[Worker] Expecting TypeError exception from store.createIndex('failureIndex', 'zzz', true)
+PASS [Worker] Exception was thrown.
+PASS [Worker] store.createIndex('failureIndex', 'zzz', true) threw TypeError: Not an object.
+[Worker] Expecting TypeError exception from store.createIndex('failureIndex', 'zzz', 'string')
+PASS [Worker] Exception was thrown.
+PASS [Worker] store.createIndex('failureIndex', 'zzz', 'string') threw TypeError: Not an object.
 PASS [Worker] 'name' in indexObject is true
 PASS [Worker] indexObject.name is "indexName"

trunk/LayoutTests/storage/indexeddb/resources/index-basics.js

@@ -37 +37 @@
     self.indexObject2 = evalAndLog("store.createIndex('indexName2', 'y', {unique: false})");
     self.indexObject3 = evalAndLog("store.createIndex('zIndex', 'z', {unique: true})");
+    shouldBeFalse("indexObject2.unique");
+    shouldBeTrue("indexObject3.unique");
+    evalAndExpectExceptionClass("store.createIndex('failureIndex', 'zzz', true)", "TypeError");
+    evalAndExpectExceptionClass("store.createIndex('failureIndex', 'zzz', 'string')", "TypeError");
     addData();
 }