Changeset 106992 in webkit

Timestamp:

Feb 7, 2012 2:20:25 PM (12 years ago)

Author:

jamesr@google.com

Message:

[chromium] Allow retaining texture across frames in composited video playback and correctly handle lost context
​https://bugs.webkit.org/show_bug.cgi?id=77923

Reviewed by Kenneth Russell.

Thanks to r106840, we can improve the video playback mode a bit. Instead of creating a new texture on every
frame, this attempts to reuse the texture from the previous frame unless the context is lost. Also improves
error checking in case the TextureManager cannot successfully reserve memory for the texture.

Tested manually by killing the GPU process with an html5 video playing and verifying that the video playback
continues and that we don't create a new set of textures for each plane on each frame.

• platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::reserveTextures):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/cc/CCVideoLayerImpl.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-07  James Robinson  <jamesr@chromium.org>
+
+        [chromium] Allow retaining texture across frames in composited video playback and correctly handle lost context
+        https://bugs.webkit.org/show_bug.cgi?id=77923
+
+        Reviewed by Kenneth Russell.
+
+        Thanks to r106840, we can improve the video playback mode a bit. Instead of creating a new texture on every
+        frame, this attempts to reuse the texture from the previous frame unless the context is lost. Also improves
+        error checking in case the TextureManager cannot successfully reserve memory for the texture.
+
+        Tested manually by killing the GPU process with an html5 video playing and verifying that the video playback
+        continues and that we don't create a new set of textures for each plane on each frame.
+
+        * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
+        (WebCore::CCVideoLayerImpl::draw):
+        (WebCore::CCVideoLayerImpl::reserveTextures):
+
 2012-02-07  Matthew Delaney  <mdelaney@apple.com>
 

trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp

@@ -151 +151 @@
     }
 
-    for (unsigned plane = 0; plane < frame->planes(); ++plane) {
+    for (unsigned plane = 0; plane < frame->planes(); ++plane)
         m_textures[plane].m_texture->unreserve();
-        // FIXME: ManagedTexture's store a raw pointer to their TextureManager,
-        // and the textures we create use layerRenderer->renderSurfaceTextureManager().
-        // Since there is no guarantee layerRenderer will still be alive the
-        // next time we are called, we clear the texture reference. It would
-        // be nice if instead we could rely on textures being invalidated when
-        // their manager was deleted so that new textures didn't always have to
-        // be recreated for each frame.
-        m_textures[plane].m_texture.clear();
-    }
     m_provider->putCurrentFrame(frame);
 }
@@ -256 +247 @@
                 return false;
             m_textures[plane].m_visibleSize = IntSize();
+        } else {
+            // The renderSurfaceTextureManager may have been destroyed and recreated since the last frame, so pass the new one.
+            // This is a no-op if the TextureManager is still around.
+            m_textures[plane].m_texture->setTextureManager(layerRenderer->renderSurfaceTextureManager());
         }
         if (m_textures[plane].m_texture->size() != requiredTextureSize)
             m_textures[plane].m_visibleSize = computeVisibleSize(frame, plane);
-        m_textures[plane].m_texture->reserve(requiredTextureSize, format);
+        if (!m_textures[plane].m_texture->reserve(requiredTextureSize, format))
+            return false;
     }
     return true;