Changeset 106998 in webkit
- Timestamp:
- Feb 7, 2012 3:38:19 PM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r106997 r106998 1 2012-02-07 Kentaro Hara <haraken@chromium.org> 2 3 [Refactoring] Use the [IsWorkerContext] IDL in CodeGeneratorV8.pm 4 https://bugs.webkit.org/show_bug.cgi?id=77957 5 6 Reviewed by Adam Barth. 7 8 This patch replaces IsSubType("WorkerContext") and something equivalent that 9 with the [IsWorkerContext] IDL. 10 11 No tests. No change in behavior. 12 13 * bindings/scripts/CodeGeneratorV8.pm: 14 (GetInternalFields): 15 (GenerateConstructorGetter): 16 (GenerateImplementation): 17 1 18 2012-02-07 David Reveman <reveman@chromium.org> 2 19 -
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
r106892 r106998 506 506 my $dataNode = shift; 507 507 my $name = $dataNode->name; 508 508 509 509 my @customInternalFields = (); 510 511 # We can't ask whether a parent type has a given extendedAttribute,so special-case AbstractWorker and WorkerContext to include all sub-types.510 # We can't ask whether a parent type has a given extendedAttribute, 511 # so special-case AbstractWorker and WorkerContext to include all sub-types. 512 512 # Event listeners on DOM nodes are explicitly supported in the GC controller. 513 513 # FIXME: SVGElementInstance should probably have the EventTarget extended attribute, but doesn't. 514 if (!IsNodeSubType($dataNode) &&515 ($dataNode->extendedAttributes->{"EventTarget"} ||516 IsSubType($dataNode, "AbstractWorker") ||517 IsSubType($dataNode, "WorkerContext") ||518 $name eq "SVGElementInstance")) {514 if (!IsNodeSubType($dataNode) 515 && ($dataNode->extendedAttributes->{"EventTarget"} 516 || $dataNode->extendedAttributes->{"IsWorkerContext"} 517 || IsSubType($dataNode, "AbstractWorker") 518 || $name eq "SVGElementInstance")) { 519 519 push(@customInternalFields, "eventListenerCacheIndex"); 520 520 } … … 736 736 sub GenerateConstructorGetter 737 737 { 738 my $dataNode = shift; 738 739 my $implClassName = shift; 739 740 … … 754 755 return V8DOMWrapper::getConstructor(type, V8DOMWindow::toNative(info.Holder())); 755 756 END 756 } elsif ($ implClassName eq "DedicatedWorkerContext" or $implClassName eq "WorkerContext" or $implClassName eq "SharedWorkerContext") {757 } elsif ($dataNode->extendedAttributes->{"IsWorkerContext"}) { 757 758 push(@implContentDecls, <<END); 758 759 return V8DOMWrapper::getConstructor(type, V8WorkerContext::toNative(info.Holder())); … … 2311 2312 2312 2313 if ($hasConstructors) { 2313 GenerateConstructorGetter($ implClassName);2314 GenerateConstructorGetter($dataNode, $implClassName); 2314 2315 } 2315 2316
Note: See TracChangeset
for help on using the changeset viewer.