Changeset 107021 in webkit

Timestamp:

Feb 7, 2012 6:05:34 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] NetworkJob should stop redirecting when the request is cleared by client
​https://bugs.webkit.org/show_bug.cgi?id=78029

Patch by Yong Li <​yoli@rim.com> on 2012-02-07
Reviewed by Rob Buis.

When a redirect is rejected by security origin check, the ResourceRequest
will be cleared (see DocumentThreadableLoader::redirectReceived()). In this
case, we should stop handling the request.

No new tests because existing tests (like http:/tests/xmlhttprequest/redirect-cross
-origin-tripmine.html) can cover this.

• platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::startNewJobWithRequest):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/blackberry/NetworkJob.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-07  Yong Li  <yoli@rim.com>
+
+        [BlackBerry] NetworkJob should stop redirecting when the request is cleared by client
+        https://bugs.webkit.org/show_bug.cgi?id=78029
+
+        Reviewed by Rob Buis.
+
+        When a redirect is rejected by security origin check, the ResourceRequest
+        will be cleared (see DocumentThreadableLoader::redirectReceived()). In this
+        case, we should stop handling the request.
+
+        No new tests because existing tests (like http:/tests/xmlhttprequest/redirect-cross
+        -origin-tripmine.html) can cover this.
+
+        * platform/network/blackberry/NetworkJob.cpp:
+        (WebCore::NetworkJob::startNewJobWithRequest):
+
 2012-02-07  David Barton  <dbarton@mathscribe.com>
 

trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp

@@ -507 +507 @@
 
         // m_cancelled can become true if the url fails the policy check.
-        if (m_cancelled)
+        // newRequest can be cleared when the redirect is rejected.
+        if (m_cancelled || newRequest.isEmpty())
             return false;
     }