Changeset 107034 in webkit


Ignore:
Timestamp:
Feb 7, 2012 8:14:02 PM (12 years ago)
Author:
haraken@chromium.org
Message:

[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=78059

Reviewed by Adam Barth.

CodeGeneratorGObject.pm does not support custom attributes.
We can skip generating code for attributes with [Custom].
The change would make sense, since CodeGeneratorGObject.pm already
skips attributes with [CustomGetter] or [CustomSetter].

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r107032 r107034  
     12012-02-07  Kentaro Hara  <haraken@chromium.org>
     2
     3        [GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
     4        https://bugs.webkit.org/show_bug.cgi?id=78059
     5
     6        Reviewed by Adam Barth.
     7
     8        CodeGeneratorGObject.pm does not support custom attributes.
     9        We can skip generating code for attributes with [Custom].
     10        The change would make sense, since CodeGeneratorGObject.pm already
     11        skips attributes with [CustomGetter] or [CustomSetter].
     12
     13        Test: bindings/scripts/test/TestObj.idl
     14
     15        * bindings/scripts/CodeGeneratorGObject.pm:
     16        (SkipAttribute):
     17        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
     18
    1192012-02-07  Emil A Eklund  <eae@chromium.org>
    220
  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm

    r106639 r107034  
    153153sub SkipAttribute {
    154154    my $attribute = shift;
    155    
    156     if ($attribute->signature->extendedAttributes->{"CustomGetter"} ||
    157         $attribute->signature->extendedAttributes->{"CustomSetter"}) {
     155
     156    if ($attribute->signature->extendedAttributes->{"Custom"}
     157        || $attribute->signature->extendedAttributes->{"CustomGetter"}
     158        || $attribute->signature->extendedAttributes->{"CustomSetter"}) {
    158159        return 1;
    159160    }
  • trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp

    r106528 r107034  
    14071407    PROP_STRING_ATTR_WITH_GETTER_EXCEPTION,
    14081408    PROP_STRING_ATTR_WITH_SETTER_EXCEPTION,
    1409     PROP_CUSTOM_ATTR,
    14101409    PROP_WITH_SCRIPT_STATE_ATTRIBUTE,
    14111410    PROP_WITH_SCRIPT_EXECUTION_CONTEXT_ATTRIBUTE,
Note: See TracChangeset for help on using the changeset viewer.