Changeset 107051 in webkit

Timestamp:

Feb 8, 2012 12:57:50 AM (12 years ago)

Author:

haraken@chromium.org

Message:

Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL
​https://bugs.webkit.org/show_bug.cgi?id=77963

Reviewed by Adam Barth.

This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):

• bindings/scripts/test/TestInterface.idl:
• css/CSSStyleDeclaration.idl:
• dom/DOMStringMap.idl:
• html/HTMLAppletElement.idl:
• html/HTMLEmbedElement.idl:
• html/HTMLObjectElement.idl:
• page/History.idl:
• page/Location.idl:
• storage/Storage.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorJS.pm (modified) (5 diffs)
• bindings/scripts/CodeGeneratorV8.pm (modified) (4 diffs)
• bindings/scripts/test/TestInterface.idl (modified) (1 diff)
• css/CSSStyleDeclaration.idl (modified) (1 diff)
• dom/DOMStringMap.idl (modified) (1 diff)
• html/HTMLAppletElement.idl (modified) (1 diff)
• html/HTMLEmbedElement.idl (modified) (1 diff)
• html/HTMLObjectElement.idl (modified) (1 diff)
• page/History.idl (modified) (1 diff)
• page/Location.idl (modified) (1 diff)
• storage/Storage.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-08  Kentaro Hara  <haraken@chromium.org>
+
+        Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL
+        https://bugs.webkit.org/show_bug.cgi?id=77963
+
+        Reviewed by Adam Barth.
+
+        This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
+        for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateHeader):
+        (GenerateImplementation):
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (GenerateHeaderNamedAndIndexedPropertyAccessors):
+        (GenerateImplementationIndexer):
+        (GenerateImplementationNamedPropertyGetter):
+        * bindings/scripts/test/TestInterface.idl:
+        * css/CSSStyleDeclaration.idl:
+        * dom/DOMStringMap.idl:
+        * html/HTMLAppletElement.idl:
+        * html/HTMLEmbedElement.idl:
+        * html/HTMLObjectElement.idl:
+        * page/History.idl:
+        * page/Location.idl:
+        * storage/Storage.idl:
+
 2012-02-08  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -752 +752 @@
     $headerTrailingIncludes{"${className}Custom.h"} = 1 if $dataNode->extendedAttributes->{"CustomHeader"};
 
-    $implIncludes{"${className}Custom.h"} = 1 if !$dataNode->extendedAttributes->{"CustomHeader"} && ($dataNode->extendedAttributes->{"CustomPutFunction"} || $dataNode->extendedAttributes->{"DelegatingPutFunction"});
+    $implIncludes{"${className}Custom.h"} = 1 if !$dataNode->extendedAttributes->{"CustomHeader"} && ($dataNode->extendedAttributes->{"CustomPutFunction"} || $dataNode->extendedAttributes->{"CustomNamedSetter"});
 
     my $hasGetter = $numAttributes > 0
@@ -783 +783 @@
     my $hasSetter = $hasReadWriteProperties
                  || $dataNode->extendedAttributes->{"CustomPutFunction"}
-                 || $dataNode->extendedAttributes->{"DelegatingPutFunction"}
+                 || $dataNode->extendedAttributes->{"CustomNamedSetter"}
                  || $dataNode->extendedAttributes->{"CustomIndexedSetter"};
 
@@ -790 +790 @@
         push(@headerContent, "    static void put(JSC::JSCell*, JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);\n");
         push(@headerContent, "    static void putByIndex(JSC::JSCell*, JSC::ExecState*, unsigned propertyName, JSC::JSValue);\n") if $dataNode->extendedAttributes->{"CustomIndexedSetter"};
-        push(@headerContent, "    bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);\n") if $dataNode->extendedAttributes->{"DelegatingPutFunction"};
+        push(@headerContent, "    bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);\n") if $dataNode->extendedAttributes->{"CustomNamedSetter"};
     }
 
@@ -1826 +1826 @@
 
         my $hasSetter = $hasReadWriteProperties
-                     || $dataNode->extendedAttributes->{"DelegatingPutFunction"}
+                     || $dataNode->extendedAttributes->{"CustomNamedSetter"}
                      || $dataNode->extendedAttributes->{"CustomIndexedSetter"};
 
@@ -1843 +1843 @@
                     push(@implContent, "    }\n");
                 }
-                if ($dataNode->extendedAttributes->{"DelegatingPutFunction"}) {
+                if ($dataNode->extendedAttributes->{"CustomNamedSetter"}) {
                     push(@implContent, "    if (thisObject->putDelegate(exec, propertyName, value, slot))\n");
                     push(@implContent, "        return;\n");

trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -567 +567 @@
     my $hasCustomIndexedSetter = $dataNode->extendedAttributes->{"CustomIndexedSetter"} && !$dataNode->extendedAttributes->{"HasNumericIndexGetter"};
     my $hasCustomNamedGetter = $dataNode->extendedAttributes->{"NamedGetter"} || $dataNode->extendedAttributes->{"CustomNamedGetter"} || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
-    my $hasCustomNamedSetter = $dataNode->extendedAttributes->{"DelegatingPutFunction"};
+    my $hasCustomNamedSetter = $dataNode->extendedAttributes->{"CustomNamedSetter"};
     my $hasCustomDeleters = $dataNode->extendedAttributes->{"CustomDeleteProperty"};
     my $hasCustomEnumerator = $dataNode->extendedAttributes->{"CustomGetPropertyNames"};
@@ -2063 +2063 @@
     if ($isSpecialCase) {
         $hasGetter = 1;
-        if ($dataNode->extendedAttributes->{"DelegatingPutFunction"}) {
+        if ($dataNode->extendedAttributes->{"CustomNamedSetter"}) {
             $hasCustomSetter = 1;
         }
@@ -2169 +2169 @@
     }
 
-    my $hasSetter = $dataNode->extendedAttributes->{"DelegatingPutFunction"};
+    my $hasCustomNamedSetter = $dataNode->extendedAttributes->{"CustomNamedSetter"};
     my $hasDeleter = $dataNode->extendedAttributes->{"CustomDeleteProperty"};
     my $hasEnumerator = $dataNode->extendedAttributes->{"CustomGetPropertyNames"};
@@ -2185 +2185 @@
 
     push(@implContent, "    desc->${setOn}Template()->SetNamedPropertyHandler(V8${interfaceName}::namedPropertyGetter, ");
-    push(@implContent, $hasSetter ? "V8${interfaceName}::namedPropertySetter, " : "0, ");
+    push(@implContent, $hasCustomNamedSetter ? "V8${interfaceName}::namedPropertySetter, " : "0, ");
     # If there is a custom enumerator, there MUST be custom query to properly communicate property attributes.
     push(@implContent, $hasEnumerator ? "V8${interfaceName}::namedPropertyQuery, " : "0, ");

trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl

@@ -32 +32 @@
     interface [
         ActiveDOMObject,
-        DelegatingPutFunction,
+        CustomNamedSetter,
         Conditional=Condition1|Condition2,
         CallWith=ScriptExecutionContext,

trunk/Source/WebCore/css/CSSStyleDeclaration.idl

@@ -25 +25 @@
         JSCustomMarkFunction,
         JSGenerateIsReachable=ImplRoot,
-        DelegatingPutFunction,
+        CustomNamedSetter,
         NamedGetter,
         IndexedGetter,

trunk/Source/WebCore/dom/DOMStringMap.idl

@@ -31 +31 @@
         CustomDeleteProperty,
         CustomGetPropertyNames,
-        DelegatingPutFunction,
+        CustomNamedSetter,
     ] DOMStringMap {
     };

trunk/Source/WebCore/html/HTMLAppletElement.idl

@@ -22 +22 @@
 
     interface [
-        DelegatingPutFunction,
+        CustomNamedSetter,
         JSCustomGetOwnPropertySlotDelegate,
         CustomCall

trunk/Source/WebCore/html/HTMLEmbedElement.idl

@@ -22 +22 @@
 
     interface [
-        DelegatingPutFunction,
+        CustomNamedSetter,
         JSCustomGetOwnPropertySlotDelegate,
         CustomCall

trunk/Source/WebCore/html/HTMLObjectElement.idl

@@ -22 +22 @@
 
     interface [
-        DelegatingPutFunction,
+        CustomNamedSetter,
         JSCustomGetOwnPropertySlotDelegate,
         CustomCall

trunk/Source/WebCore/page/History.idl

@@ -31 +31 @@
 #endif
         JSCustomGetOwnPropertySlotDelegate,
-        DelegatingPutFunction,
+        CustomNamedSetter,
         JSGenerateIsReachable=ImplFrame,
         CustomDeleteProperty,

trunk/Source/WebCore/page/Location.idl

@@ -34 +34 @@
 #endif
         JSCustomGetOwnPropertySlotDelegate,
-        DelegatingPutFunction,
+        CustomNamedSetter,
         JSGenerateIsReachable=ImplFrame,
         CustomDeleteProperty,

trunk/Source/WebCore/storage/Storage.idl

@@ -31 +31 @@
         CustomDeleteProperty,
         CustomGetPropertyNames,
-        DelegatingPutFunction,
+        CustomNamedSetter,
     ] Storage {
         readonly attribute [NotEnumerable] unsigned long length;