Changeset 107115 in webkit

Timestamp:

Feb 8, 2012 12:16:21 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Chromium] Don't add selection from password fields to context menu.
​https://bugs.webkit.org/show_bug.cgi?id=77733

Patch by Bernhard Bauer <​bauerb@google.com> on 2012-02-08
Reviewed by Adam Barth.

• src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/ContextMenuClientImpl.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-02-08  Bernhard Bauer  <bauerb@google.com>
+
+        [Chromium] Don't add selection from password fields to context menu.
+        https://bugs.webkit.org/show_bug.cgi?id=77733
+
+        Reviewed by Adam Barth.
+
+        * src/ContextMenuClientImpl.cpp:
+        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
+
 2012-02-08  Nico Weber  <nicolasweber@gmx.de>
 

trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

@@ -260 +260 @@
     }
 
-    if (r.isSelected())
-        data.selectedText = selectedFrame->editor()->selectedText().stripWhiteSpace();
+    if (r.isSelected()) {
+        if (!r.innerNonSharedNode()->hasTagName(HTMLNames::inputTag) || !static_cast<HTMLInputElement*>(r.innerNonSharedNode())->isPasswordField())
+            data.selectedText = selectedFrame->editor()->selectedText().stripWhiteSpace();
+    }
 
     if (r.isContentEditable()) {