Changeset 107128 in webkit


Ignore:
Timestamp:
Feb 8, 2012 1:35:34 PM (12 years ago)
Author:
oliver@apple.com
Message:

Fix issue encountered while debugging stacktraces
https://bugs.webkit.org/show_bug.cgi?id=78147

Reviewed by Gavin Barraclough.

Debugging is easier if we always ensure that we have a non-null
inferred name.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):

Location:
trunk/Source/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r107126 r107128  
     12012-02-08  Oliver Hunt  <oliver@apple.com>
     2
     3        Fix issue encountered while debugging stacktraces
     4        https://bugs.webkit.org/show_bug.cgi?id=78147
     5
     6        Reviewed by Gavin Barraclough.
     7
     8        Debugging is easier if we always ensure that we have a non-null
     9        inferred name.
     10
     11        * runtime/Executable.cpp:
     12        (JSC::FunctionExecutable::FunctionExecutable):
     13
    1142012-02-08  Oliver Hunt  <oliver@apple.com>
    215
  • trunk/Source/JavaScriptCore/runtime/Executable.cpp

    r106504 r107128  
    138138    , m_parameters(parameters)
    139139    , m_name(name)
    140     , m_inferredName(inferredName)
     140    , m_inferredName(inferredName.isNull() ? exec->globalData().propertyNames->emptyIdentifier : inferredName)
    141141    , m_symbolTable(0)
    142142{
     
    149149    , m_parameters(parameters)
    150150    , m_name(name)
    151     , m_inferredName(inferredName)
     151    , m_inferredName(inferredName.isNull() ? exec->globalData().propertyNames->emptyIdentifier : inferredName)
    152152    , m_symbolTable(0)
    153153{
  • trunk/Source/JavaScriptCore/runtime/JSFunction.cpp

    r106783 r107128  
    371371    if (InternalFunction* function = jsDynamicCast<InternalFunction*>(object))
    372372        return function->calculatedDisplayName(callFrame);
    373     return UString();
     373    return callFrame->globalData().propertyNames->emptyIdentifier.ustring();
    374374}
    375375
Note: See TracChangeset for help on using the changeset viewer.