Changeset 107209 in webkit

Timestamp:

Feb 9, 2012 3:28:57 AM (12 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: Scripts navigator fails to reopen previously closed script.
​https://bugs.webkit.org/show_bug.cgi?id=78212

Reviewed by Pavel Feldman.

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._editorClosed):

• inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._tabClosed):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ScriptsPanel.js (modified) (3 diffs)
• inspector/front-end/TabbedEditorContainer.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-09  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Scripts navigator fails to reopen previously closed script.
+        https://bugs.webkit.org/show_bug.cgi?id=78212
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._reset):
+        (WebInspector.ScriptsPanel.prototype._showFile):
+        (WebInspector.ScriptsPanel.prototype._editorClosed):
+        * inspector/front-end/TabbedEditorContainer.js:
+        (WebInspector.TabbedEditorContainer.prototype._tabClosed):
+
 2012-02-09  Shinya Kawanaka  <shinyak@google.com>
 

trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js

@@ -405 +405 @@
         this._debuggerResumed();
 
-        delete this._curentUISourceCode;
+        delete this._currentUISourceCode;
         this._editorContainer.reset();
         this._updateScriptViewStatusBarItems();
@@ -476 +476 @@
 
         var sourceFrame = this._getOrCreateSourceFrame(uiSourceCode);
-        if (this._curentUISourceCode === uiSourceCode)
+        if (this._currentUISourceCode === uiSourceCode)
             return sourceFrame;
-        this._curentUISourceCode = uiSourceCode;
+        this._currentUISourceCode = uiSourceCode;
 
         this._fileSelector.revealUISourceCode(uiSourceCode);
@@ -630 +630 @@
         var uiSourceCode = /** @type {WebInspector.UISourceCode} */ event.data;
 
+        if (this._currentUISourceCode === uiSourceCode)
+            delete this._currentUISourceCode;
+        
         // We don't need to update file selector here regardless of whether useScriptsNavigator is set or not:
         // SingleFileEditorContainer never dispatches EditorClosed, so no need to update ComboBoxFileSelector; 

trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js

@@ -207 +207 @@
         this._tabIds.remove(uiSourceCode);
         delete this._files[tabId];
+        delete this._currentFile;
 
         this.dispatchEventToListeners(WebInspector.EditorContainer.Events.EditorClosed, uiSourceCode);