Changeset 107214 in webkit


Ignore:
Timestamp:
Feb 9, 2012 3:56:43 AM (12 years ago)
Author:
rolandsteiner@chromium.org
Message:

2012-02-09 Roland Steiner <​rolandsteiner@chromium.org>

SelectorChecker::checkSelector: move parameters into a struct
​https://bugs.webkit.org/show_bug.cgi?id=77525

Added 'SelectorCheckingContext' struct to hold parameters for the function.
Adapted calling sites.
(fixing change log after the commit message got bungled up).

Reviewed by Antti Koivisto.

No new tests. (refactoring)

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector):
  • css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkSelector): (WebCore): (WebCore::SelectorChecker::checkOneSelector):
  • css/SelectorChecker.h: (SelectorCheckingContext): (WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): (SelectorChecker):
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r107212 r107214  
    1 2012-02-09  Philip Rogers  <pdr@google.com>
    2 
    3         Fix mirroring with SVG fonts
    4         https://bugs.webkit.org/show_bug.cgi?id=77067
    5 
    6         Reviewed by Nikolas Zimmermann.
    7 
    8         SVG fonts were incorrectly handling mirrored characters in bidi text.
    9         In this change I added the function createStringWithMirroredCharacters
    10         which handles mirroring the characters when selecting glyphs for SVG
    11         fonts. I also made a small cosmetic change in the function
    12         charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
    13         which better reflects what it actually does.
    14 
    15         Several new tests were added to test mirroring with SVG fonts in the
    16         presence of Arabic forms and non-BMP characters.
    17 
    18         Tests: svg/custom/glyph-selection-arabic-forms.svg
    19                svg/custom/glyph-selection-bidi-mirror.svg
    20                svg/custom/glyph-selection-non-bmp.svg
    21 
    22         * platform/graphics/SVGGlyph.cpp:
    23         (WebCore::charactersWithArabicForm):
    24         * svg/SVGFontData.cpp:
    25         (WebCore::SVGFontData::applySVGGlyphSelection):
    26         (WebCore::SVGFontData::createStringWithMirroredCharacters):
    27         * svg/SVGFontData.h:
    28         (SVGFontData):
    29 
    30 2012-02-09  Vsevolod Vlasov  <vsevik@chromium.org>
    31 
    32         Web Inspector: Scripts navigator fails to reopen previously closed script.
    33         https://bugs.webkit.org/show_bug.cgi?id=78212
    34 
    35         Reviewed by Pavel Feldman.
    36 
    37         * inspector/front-end/ScriptsPanel.js:
    38         (WebInspector.ScriptsPanel.prototype._reset):
    39         (WebInspector.ScriptsPanel.prototype._showFile):
    40         (WebInspector.ScriptsPanel.prototype._editorClosed):
    41         * inspector/front-end/TabbedEditorContainer.js:
    42         (WebInspector.TabbedEditorContainer.prototype._tabClosed):
    43 
    44 2012-02-09  Shinya Kawanaka  <shinyak@google.com>
    45 
    46         ASSERT_NO_EXCEPTION should be initialized with non-zero value.
    47         https://bugs.webkit.org/show_bug.cgi?id=78194
    48 
    49         Reviewed by Hajime Morita.
    50 
    51         ExceptionCode should not be checked without initializing it.
    52         However, we encountered a bug that breaks this rule.
    53         It was missed until now because ExceptionCode is sometimes set to 0 even if it is not initialized.
    54         This patch ensures it is initialized as non-zero value.
    55 
    56         No new tests, no change in behavior.
    57 
    58         * dom/ExceptionCodePlaceholder.cpp:
    59         (WebCore::NoExceptionAssertionChecker::NoExceptionAssertionChecker):
    60         (WebCore::NoExceptionAssertionChecker::~NoExceptionAssertionChecker):
    61         * dom/ExceptionCodePlaceholder.h:
    62         (NoExceptionAssertionChecker):
    63 
    6412012-02-09  Roland Steiner  <rolandsteiner@chromium.org>
    652
    … …  
    696        Added 'SelectorCheckingContext' struct to hold parameters for the function.
    707        Adapted calling sites.
     8        (fixing change log after the commit message got bungled up).
    719
    7210        Reviewed by Antti Koivisto.
    … …  
    8422        (WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
    8523        (SelectorChecker):
     24
     252012-02-09  Philip Rogers  <pdr@google.com>
     26
     27        Fix mirroring with SVG fonts
     28        https://bugs.webkit.org/show_bug.cgi?id=77067
     29
     30        Reviewed by Nikolas Zimmermann.
     31
     32        SVG fonts were incorrectly handling mirrored characters in bidi text.
     33        In this change I added the function createStringWithMirroredCharacters
     34        which handles mirroring the characters when selecting glyphs for SVG
     35        fonts. I also made a small cosmetic change in the function
     36        charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
     37        which better reflects what it actually does.
     38
     39        Several new tests were added to test mirroring with SVG fonts in the
     40        presence of Arabic forms and non-BMP characters.
     41
     42        Tests: svg/custom/glyph-selection-arabic-forms.svg
     43               svg/custom/glyph-selection-bidi-mirror.svg
     44               svg/custom/glyph-selection-non-bmp.svg
     45
     46        * platform/graphics/SVGGlyph.cpp:
     47        (WebCore::charactersWithArabicForm):
     48        * svg/SVGFontData.cpp:
     49        (WebCore::SVGFontData::applySVGGlyphSelection):
     50        (WebCore::SVGFontData::createStringWithMirroredCharacters):
     51        * svg/SVGFontData.h:
     52        (SVGFontData):
     53
     542012-02-09  Vsevolod Vlasov  <vsevik@chromium.org>
     55
     56        Web Inspector: Scripts navigator fails to reopen previously closed script.
     57        https://bugs.webkit.org/show_bug.cgi?id=78212
     58
     59        Reviewed by Pavel Feldman.
     60
     61        * inspector/front-end/ScriptsPanel.js:
     62        (WebInspector.ScriptsPanel.prototype._reset):
     63        (WebInspector.ScriptsPanel.prototype._showFile):
     64        (WebInspector.ScriptsPanel.prototype._editorClosed):
     65        * inspector/front-end/TabbedEditorContainer.js:
     66        (WebInspector.TabbedEditorContainer.prototype._tabClosed):
     67
     682012-02-09  Shinya Kawanaka  <shinyak@google.com>
     69
     70        ASSERT_NO_EXCEPTION should be initialized with non-zero value.
     71        https://bugs.webkit.org/show_bug.cgi?id=78194
     72
     73        Reviewed by Hajime Morita.
     74
     75        ExceptionCode should not be checked without initializing it.
     76        However, we encountered a bug that breaks this rule.
     77        It was missed until now because ExceptionCode is sometimes set to 0 even if it is not initialized.
     78        This patch ensures it is initialized as non-zero value.
     79
     80        No new tests, no change in behavior.
     81
     82        * dom/ExceptionCodePlaceholder.cpp:
     83        (WebCore::NoExceptionAssertionChecker::NoExceptionAssertionChecker):
     84        (WebCore::NoExceptionAssertionChecker::~NoExceptionAssertionChecker):
     85        * dom/ExceptionCodePlaceholder.h:
     86        (NoExceptionAssertionChecker):
    8687
    87882012-02-09  Roland Steiner  <rolandsteiner@chromium.org>
Note: See TracChangeset for help on using the changeset viewer.