Changeset 107223 in webkit


Ignore:
Timestamp:
Feb 9, 2012 5:04:13 AM (12 years ago)
Author:
loislo@chromium.org
Message:

Web Inspector: Timeline memory graph would have been more useful if it had used minUsedHeapSize as the lower bound. Currently it uses zero as the lower bound.
https://bugs.webkit.org/show_bug.cgi?id=78222

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.HeapGraph):
(WebInspector.HeapGraph.prototype.update):

  • inspector/front-end/timelinePanel.css:

(.memory-graph-label):
(.max.memory-graph-label):
(.min.memory-graph-label):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r107220 r107223  
     12012-02-09  Ilya Tikhonovsky  <loislo@chromium.org>
     2
     3        Web Inspector: Timeline memory graph would have been more useful if it had used minUsedHeapSize as the lower bound. Currently it uses zero as the lower bound.
     4        https://bugs.webkit.org/show_bug.cgi?id=78222
     5
     6        Reviewed by Pavel Feldman.
     7
     8        * inspector/front-end/TimelineOverviewPane.js:
     9        (WebInspector.HeapGraph):
     10        (WebInspector.HeapGraph.prototype.update):
     11        * inspector/front-end/timelinePanel.css:
     12        (.memory-graph-label):
     13        (.max.memory-graph-label):
     14        (.min.memory-graph-label):
     15
    1162012-02-09  Alexander Pavlov  <apavlov@chromium.org>
    217
  • trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js

    r100991 r107223  
    525525
    526526    this._maxHeapSizeLabel = document.createElement("div");
     527    this._maxHeapSizeLabel.addStyleClass("max");
    527528    this._maxHeapSizeLabel.addStyleClass("memory-graph-label");
     529    this._minHeapSizeLabel = document.createElement("div");
     530    this._minHeapSizeLabel.addStyleClass("min");
     531    this._minHeapSizeLabel.addStyleClass("memory-graph-label");
    528532
    529533    this._element = document.createElement("div");
     
    531535    this._element.appendChild(this._canvas);
    532536    this._element.appendChild(this._maxHeapSizeLabel);
     537    this._element.appendChild(this._minHeapSizeLabel);
    533538}
    534539
     
    561566            return;
    562567
    563         var maxTotalHeapSize = 0;
     568        const lowerOffset = 3;
     569        var maxUsedHeapSize = 0;
     570        var minUsedHeapSize = 100000000000;
    564571        var minTime;
    565572        var maxTime;
    566573        this._forAllRecords(records, function(r) {
    567             if (r.totalHeapSize && r.totalHeapSize > maxTotalHeapSize)
    568                 maxTotalHeapSize = r.totalHeapSize;
     574            maxUsedHeapSize = Math.max(maxUsedHeapSize, r.usedHeapSize || maxUsedHeapSize);
     575            minUsedHeapSize = Math.min(minUsedHeapSize, r.usedHeapSize || minUsedHeapSize);
    569576
    570577            if (typeof minTime === "undefined" || r.startTime < minTime)
     
    573580                maxTime = r.endTime;
    574581        });
     582        minUsedHeapSize = Math.min(minUsedHeapSize, maxUsedHeapSize);
    575583
    576584        var width = this._canvas.width;
    577         var height = this._canvas.height;
     585        var height = this._canvas.height - lowerOffset;
    578586        var xFactor = width / (maxTime - minTime);
    579         var yFactor = height / maxTotalHeapSize;
     587        var yFactor = height / (maxUsedHeapSize - minUsedHeapSize);
    580588
    581589        var histogram = new Array(width);
     
    584592                return;
    585593             var x = Math.round((r.endTime - minTime) * xFactor);
    586              var y = Math.round(r.usedHeapSize * yFactor);
     594             var y = Math.round((r.usedHeapSize - minUsedHeapSize) * yFactor);
    587595             histogram[x] = Math.max(histogram[x] || 0, y);
    588596        });
     
    621629        ctx.closePath();
    622630
    623         this._maxHeapSizeLabel.textContent = Number.bytesToString(maxTotalHeapSize);
     631        this._maxHeapSizeLabel.textContent = Number.bytesToString(maxUsedHeapSize);
     632        this._minHeapSizeLabel.textContent = Number.bytesToString(minUsedHeapSize);
    624633    },
    625634
  • trunk/Source/WebCore/inspector/front-end/timelinePanel.css

    r105877 r107223  
    497497.memory-graph-label {
    498498    position: absolute;
    499     top: 5px;
    500499    left: 5px;
    501500    font-size: 9px;
     
    504503}
    505504
     505.max.memory-graph-label {
     506    top: 5px;
     507}
     508
     509.min.memory-graph-label {
     510    bottom: 5px;
     511}
     512
    506513#timeline-memory-splitter {
    507514    position: absolute;
Note: See TracChangeset for help on using the changeset viewer.