Changeset 107223 in webkit
- Timestamp:
- Feb 9, 2012 5:04:13 AM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r107220 r107223 1 2012-02-09 Ilya Tikhonovsky <loislo@chromium.org> 2 3 Web Inspector: Timeline memory graph would have been more useful if it had used minUsedHeapSize as the lower bound. Currently it uses zero as the lower bound. 4 https://bugs.webkit.org/show_bug.cgi?id=78222 5 6 Reviewed by Pavel Feldman. 7 8 * inspector/front-end/TimelineOverviewPane.js: 9 (WebInspector.HeapGraph): 10 (WebInspector.HeapGraph.prototype.update): 11 * inspector/front-end/timelinePanel.css: 12 (.memory-graph-label): 13 (.max.memory-graph-label): 14 (.min.memory-graph-label): 15 1 16 2012-02-09 Alexander Pavlov <apavlov@chromium.org> 2 17 -
trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js
r100991 r107223 525 525 526 526 this._maxHeapSizeLabel = document.createElement("div"); 527 this._maxHeapSizeLabel.addStyleClass("max"); 527 528 this._maxHeapSizeLabel.addStyleClass("memory-graph-label"); 529 this._minHeapSizeLabel = document.createElement("div"); 530 this._minHeapSizeLabel.addStyleClass("min"); 531 this._minHeapSizeLabel.addStyleClass("memory-graph-label"); 528 532 529 533 this._element = document.createElement("div"); … … 531 535 this._element.appendChild(this._canvas); 532 536 this._element.appendChild(this._maxHeapSizeLabel); 537 this._element.appendChild(this._minHeapSizeLabel); 533 538 } 534 539 … … 561 566 return; 562 567 563 var maxTotalHeapSize = 0; 568 const lowerOffset = 3; 569 var maxUsedHeapSize = 0; 570 var minUsedHeapSize = 100000000000; 564 571 var minTime; 565 572 var maxTime; 566 573 this._forAllRecords(records, function(r) { 567 if (r.totalHeapSize && r.totalHeapSize > maxTotalHeapSize)568 maxTotalHeapSize = r.totalHeapSize;574 maxUsedHeapSize = Math.max(maxUsedHeapSize, r.usedHeapSize || maxUsedHeapSize); 575 minUsedHeapSize = Math.min(minUsedHeapSize, r.usedHeapSize || minUsedHeapSize); 569 576 570 577 if (typeof minTime === "undefined" || r.startTime < minTime) … … 573 580 maxTime = r.endTime; 574 581 }); 582 minUsedHeapSize = Math.min(minUsedHeapSize, maxUsedHeapSize); 575 583 576 584 var width = this._canvas.width; 577 var height = this._canvas.height ;585 var height = this._canvas.height - lowerOffset; 578 586 var xFactor = width / (maxTime - minTime); 579 var yFactor = height / maxTotalHeapSize;587 var yFactor = height / (maxUsedHeapSize - minUsedHeapSize); 580 588 581 589 var histogram = new Array(width); … … 584 592 return; 585 593 var x = Math.round((r.endTime - minTime) * xFactor); 586 var y = Math.round( r.usedHeapSize* yFactor);594 var y = Math.round((r.usedHeapSize - minUsedHeapSize) * yFactor); 587 595 histogram[x] = Math.max(histogram[x] || 0, y); 588 596 }); … … 621 629 ctx.closePath(); 622 630 623 this._maxHeapSizeLabel.textContent = Number.bytesToString(maxTotalHeapSize); 631 this._maxHeapSizeLabel.textContent = Number.bytesToString(maxUsedHeapSize); 632 this._minHeapSizeLabel.textContent = Number.bytesToString(minUsedHeapSize); 624 633 }, 625 634 -
trunk/Source/WebCore/inspector/front-end/timelinePanel.css
r105877 r107223 497 497 .memory-graph-label { 498 498 position: absolute; 499 top: 5px;500 499 left: 5px; 501 500 font-size: 9px; … … 504 503 } 505 504 505 .max.memory-graph-label { 506 top: 5px; 507 } 508 509 .min.memory-graph-label { 510 bottom: 5px; 511 } 512 506 513 #timeline-memory-splitter { 507 514 position: absolute;
Note: See TracChangeset
for help on using the changeset viewer.