Changeset 107225 in webkit

Timestamp:

Feb 9, 2012 5:23:58 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Source/WebCore: Web Inspector: Show percentage by default in heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=78103

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-02-09
Reviewed by Pavel Feldman.

• inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):

• inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.profileCallback):
(WebInspector.DetailedHeapshotView):
(WebInspector.DetailedHeapshotView.prototype.get statusBarItems):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._updateFilterOptions):

• inspector/front-end/UIUtils.js:

(Number.withThousandsSeparator):

• inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .data-grid span.percent-column):

LayoutTests: WebInspector: Show percentage by default in heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=78103

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-02-09
Reviewed by Pavel Feldman.

• inspector/profiler/detailed-heapshots-test.js:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/profiler/detailed-heapshots-test.js (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js (modified) (5 diffs)
• Source/WebCore/inspector/front-end/DetailedHeapshotView.js (modified) (8 diffs)
• Source/WebCore/inspector/front-end/UIUtils.js (modified) (1 diff)
• Source/WebCore/inspector/front-end/heapProfiler.css (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-09  Alexei Filippov  <alexeif@chromium.org>
+
+        WebInspector: Show percentage by default in heap profiler.
+        https://bugs.webkit.org/show_bug.cgi?id=78103
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/profiler/detailed-heapshots-test.js:
+
 2012-02-09  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/LayoutTests/inspector/profiler/detailed-heapshots-test.js

@@ -13 +13 @@
         // so we provide synthetic snapshots.
         InspectorTest._panelReset = InspectorTest.override(WebInspector.panels.profiles, "_reset", function(){}, true);
-        InspectorTest.addSniffer(WebInspector.DetailedHeapshotView.prototype, "_updatePercentButton", InspectorTest._snapshotViewShown, true);
+        InspectorTest.addSniffer(WebInspector.DetailedHeapshotView.prototype, "_loadProfile", InspectorTest._snapshotViewShown, true);
 
         detailedHeapProfilesEnabled();

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-09  Alexei Filippov  <alexeif@chromium.org>
+
+        Web Inspector: Show percentage by default in heap profiler.
+        https://bugs.webkit.org/show_bug.cgi?id=78103
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/DetailedHeapshotGridNodes.js:
+        (WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
+        (WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
+        (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
+        (WebInspector.HeapSnapshotConstructorNode.prototype.get data):
+        * inspector/front-end/DetailedHeapshotView.js:
+        (WebInspector.DetailedHeapshotView.profileCallback):
+        (WebInspector.DetailedHeapshotView):
+        (WebInspector.DetailedHeapshotView.prototype.get statusBarItems):
+        (WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
+        (WebInspector.DetailedHeapshotView.prototype._updateFilterOptions):
+        * inspector/front-end/UIUtils.js:
+        (Number.withThousandsSeparator):
+        * inspector/front-end/heapProfiler.css:
+        (.detailed-heapshot-view .data-grid span.percent-column):
+
 2012-02-09  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js

@@ -63 +63 @@
     _toPercentString: function(num)
     {
-        return num.toFixed(2) + "%";
+        return num.toFixed(0) + "\u2009%"; // \u2009 is a thin space.
     },
 
@@ -73 +73 @@
         var valueSpan = document.createElement("span");
         valueSpan.textContent = this.data[columnIdentifier];
+        div.appendChild(valueSpan);
         var percentColumn = columnIdentifier + "-percent";
         if (percentColumn in this.data) {
@@ -80 +81 @@
             div.appendChild(percentSpan);
         }
-        div.appendChild(valueSpan);
         cell.appendChild(div);
         return cell;
@@ -301 +301 @@
         data["shallowSize"] = Number.withThousandsSeparator(this._shallowSize);
         data["retainedSize"] = Number.withThousandsSeparator(this._retainedSize);
-        if (view._showPercentage) {
-            data["shallowSize-percent"] = this._toPercentString(this._shallowSizePercent);
-            data["retainedSize-percent"] = this._toPercentString(this._retainedSizePercent);
-        }
+        data["shallowSize-percent"] = this._toPercentString(this._shallowSizePercent);
+        data["retainedSize-percent"] = this._toPercentString(this._retainedSizePercent);
 
         return this._enhanceData ? this._enhanceData(data) : data;
@@ -626 +624 @@
         data["shallowSize"] = Number.withThousandsSeparator(this._shallowSize);
         data["retainedSize"] = Number.withThousandsSeparator(this._retainedSize);
-        if (view._showPercentage) {
-            data["shallowSize-percent"] = this._toPercentString(this._shallowSizePercent);
-            data["retainedSize-percent"] = this._toPercentString(this._retainedSizePercent);
-        }
+        data["count-percent"] =  this._toPercentString(this._countPercent);
+        data["shallowSize-percent"] = this._toPercentString(this._shallowSizePercent);
+        data["retainedSize-percent"] = this._toPercentString(this._retainedSizePercent);
         return data;
     },

trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js

@@ -431 +431 @@
     this.parent.addEventListener("profile added", this._updateFilterOptions, this);
 
-    this._showPercentage = false;
-
     this.viewsContainer = document.createElement("div");
     this.viewsContainer.addStyleClass("views-container");
@@ -515 +513 @@
     this._updateFilterOptions();
 
-    this.percentButton = new WebInspector.StatusBarButton("", "percent-time-status-bar-item status-bar-item");
-    this.percentButton.addEventListener("click", this._percentClicked.bind(this), false);
     this.helpButton = new WebInspector.StatusBarButton("", "heapshot-help-status-bar-item status-bar-item");
     this.helpButton.addEventListener("click", this._helpClicked.bind(this), false);
@@ -540 +536 @@
             this.baseSelectElement.selectedIndex = profileIndex;
         this.dataGrid.setDataSource(this, this.profileWrapper);
-        this._updatePercentButton();
     }
 }
@@ -559 +554 @@
     get statusBarItems()
     {
-        return [this.viewSelectElement, this.baseSelectElement, this.filterSelectElement, this.percentButton.element, this.helpButton.element];
+        return [this.viewSelectElement, this.baseSelectElement, this.filterSelectElement, this.helpButton.element];
     },
 
@@ -611 +606 @@
         var height = this.retainmentView.element.clientHeight;
         this._updateRetainmentViewHeight(height);
-    },
-
-    refreshShowPercents: function()
-    {
-        this._updatePercentButton();
-        this.refreshVisibleData();
     },
 
@@ -843 +832 @@
         if (!cell || (!cell.hasStyleClass("count-column") && !cell.hasStyleClass("shallowSize-column") && !cell.hasStyleClass("retainedSize-column")))
             return;
-
-        this.refreshShowPercents();
 
         event.preventDefault();
@@ -945 +932 @@
         span.node = gridNode;
         return span;
-    },
-
-    _percentClicked: function(event)
-    {
-        this._showPercentage = !this._showPercentage;
-        this.refreshShowPercents();
     },
 
@@ -1096 +1077 @@
             this.filterSelectElement.appendChild(filterOption);
         }
-    },
-
-    _updatePercentButton: function()
-    {
-        if (this._showPercentage) {
-            this.percentButton.title = WebInspector.UIString("Hide percentages of counts and sizes.");
-            this.percentButton.toggled = true;
-        } else {
-            this.percentButton.title = WebInspector.UIString("Show percentages of counts and sizes.");
-            this.percentButton.toggled = false;
-        }
     }
 };

trunk/Source/WebCore/inspector/front-end/UIUtils.js

@@ -448 +448 @@
     var re = /(\d+)(\d{3})/;
     while (str.match(re))
-        str = str.replace(re, "$1,$2");
+        str = str.replace(re, "$1\u2009$2"); // \u2009 is a thin space.
     return str;
 }

trunk/Source/WebCore/inspector/front-end/heapProfiler.css

@@ -122 +122 @@
 .detailed-heapshot-view .data-grid span.percent-column {
     color: grey;
-    width: 42px;
-    float: left;
+    width: 32px;
+    float: right;
 }