Changeset 107251 in webkit

Timestamp:

Feb 9, 2012 8:53:55 AM (12 years ago)

Author:

caseq@chromium.org

Message:

Web Inspector: [refactoring] take _showShortEvents out of timeline calculator
​https://bugs.webkit.org/show_bug.cgi?id=78230

Reviewed by Pavel Feldman.

• inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._addToRecordsWindow):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TimelinePanel.js (modified) (5 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-09  Andrey Kosyakov  <caseq@chromium.org>
+
+        Web Inspector: [refactoring] take _showShortEvents out of timeline calculator
+        https://bugs.webkit.org/show_bug.cgi?id=78230
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel):
+        (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
+        (WebInspector.TimelinePanel.prototype._refresh):
+        (WebInspector.TimelinePanel.prototype._addToRecordsWindow):
+
 2012-02-08  Dan Vrátil  <dvratil@redhat.com>, Milan Crha <mcrha@redhat.com>
 

trunk/Source/WebCore/inspector/front-end/TimelinePanel.js

@@ -96 +96 @@
 
     this._calculator = new WebInspector.TimelineCalculator();
-    this._calculator._showShortEvents = false;
     var shortRecordThresholdTitle = Number.secondsToString(WebInspector.TimelinePanel.shortRecordThreshold);
     this._showShortRecordsTitleText = WebInspector.UIString("Show the records that are shorter than %s", shortRecordThresholdTitle);
@@ -111 +110 @@
     // Disable short events filter by default.
     this.toggleFilterButton.toggled = true;
-    this._calculator._showShortEvents = this.toggleFilterButton.toggled;
+    this._showShortEvents = this.toggleFilterButton.toggled;
     this._timeStampRecords = [];
     this._expandOffset = 15;
@@ -436 +435 @@
     {
         this.toggleFilterButton.toggled = !this.toggleFilterButton.toggled;
-        this._calculator._showShortEvents = this.toggleFilterButton.toggled;
-        this.toggleFilterButton.element.title = this._calculator._showShortEvents ? this._hideShortRecordsTitleText : this._showShortRecordsTitleText;
+        this._showShortEvents = this.toggleFilterButton.toggled;
+        this.toggleFilterButton.element.title = this._showShortEvents ? this._hideShortRecordsTitleText : this._showShortRecordsTitleText;
         this._scheduleRefresh(true);
     },
@@ -673 +672 @@
         }
 
-        this._overviewPane.update(this._rootRecord.children, this._calculator._showShortEvents);
+        this._overviewPane.update(this._rootRecord.children, this._showShortEvents);
 
         this._refreshRecords(!this._boundariesAreValid);
@@ -701 +700 @@
     _addToRecordsWindow: function(record, recordsWindow, parentIsCollapsed)
     {
-        if (!this._calculator._showShortEvents && !record.isLong())
+        if (!this._showShortEvents && !record.isLong())
             return;
         var percentages = this._calculator.computeBarGraphPercentages(record);