Changeset 107270 in webkit

Timestamp:

Feb 9, 2012 12:04:02 PM (12 years ago)

Author:

wangxianzhu@chromium.org

Message:

Unnecessary and incorrect invalidation about composited fixed-position layers
​https://bugs.webkit.org/show_bug.cgi?id=75638

When a FrameView scrolls, composited fixed-position layers should
not contribute to the invalidation rect of the root layer.

Reviewed by Simon Fraser.

No new tests. Haven't found a good way to test this programatically.

• page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-09  Xianzhu Wang  <wangxianzhu@chromium.org>
+
+        Unnecessary and incorrect invalidation about composited fixed-position layers
+        https://bugs.webkit.org/show_bug.cgi?id=75638
+
+        When a FrameView scrolls, composited fixed-position layers should
+        not contribute to the invalidation rect of the root layer.
+
+        Reviewed by Simon Fraser.
+
+        No new tests. Haven't found a good way to test this programatically.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::scrollContentsFastPath):
+
 2012-02-09  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -1464 +1464 @@
         if (renderBox->style()->position() != FixedPosition)
             continue;
+#if USE(ACCELERATED_COMPOSITING)
+        if (renderBox->layer()->isComposited())
+            continue;
+#endif
         IntRect updateRect = renderBox->layer()->repaintRectIncludingDescendants();
         updateRect = contentsToRootView(updateRect);