Changeset 107297 in webkit


Ignore:
Timestamp:
Feb 9, 2012 3:09:51 PM (12 years ago)
Author:
eric@webkit.org
Message:

Remove the cr-mac-ews (it's long been dead)
https://bugs.webkit.org/show_bug.cgi?id=78267

Reviewed by Adam Barth.

  • QueueStatusServer/model/queues.py:

(Queue):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(ChromiumWindowsEWS):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSytemTest._test_builder_ews):
(EarlyWarningSytemTest._test_testing_ews):

Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r107293 r107297  
     12012-02-09  Eric Seidel  <eric@webkit.org>
     2
     3        Remove the cr-mac-ews (it's long been dead)
     4        https://bugs.webkit.org/show_bug.cgi?id=78267
     5
     6        Reviewed by Adam Barth.
     7
     8        * QueueStatusServer/model/queues.py:
     9        (Queue):
     10        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
     11        (ChromiumWindowsEWS):
     12        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
     13        (EarlyWarningSytemTest._test_builder_ews):
     14        (EarlyWarningSytemTest._test_testing_ews):
     15
    1162012-02-09  Dirk Pranke  <dpranke@chromium.org>
    217
  • trunk/Tools/QueueStatusServer/model/queues.py

    r84216 r107297  
    4040        "commit-queue",
    4141        "style-queue",
    42         "chromium-ews",
     42        "chromium-ews",  # aka cr-linux-ews
    4343        "qt-ews",
    4444        "gtk-ews",
     
    4646        "win-ews",
    4747        "efl-ews",
    48         "cr-mac-ews",
    4948    ]
    5049
  • trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py

    r107271 r107297  
    187187
    188188
    189 # For platforms that we can't run inside a VM (like Mac OS X), we require
    190 # patches to be uploaded by committers, who are generally trustworthy folk. :)
    191 class AbstractCommitterOnlyEWS(AbstractEarlyWarningSystem):
    192     def process_work_item(self, patch):
    193         if not patch.attacher() or not patch.attacher().can_commit:
    194             self._did_error(patch, "%s cannot process patches from non-committers :(" % self.name)
    195             return False
    196         return AbstractEarlyWarningSystem.process_work_item(self, patch)
    197 
    198 
    199 # FIXME: Inheriting from AbstractCommitterOnlyEWS is kinda a hack, but it
    200 # happens to work because AbstractChromiumEWS and AbstractCommitterOnlyEWS
    201 # provide disjoint sets of functionality, and Python is otherwise smart
    202 # enough to handle the diamond inheritance.
    203 class ChromiumMacEWS(AbstractChromiumEWS, AbstractCommitterOnlyEWS):
    204     name = "cr-mac-ews"
    205 
    206 
    207189class MacEWS(AbstractEarlyWarningSystem):
    208190    name = "mac-ews"
  • trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py

    r106520 r107297  
    7272        self.assert_queue_outputs(ews, expected_stderr=self._default_expected_stderr(ews))
    7373
    74     def _test_committer_only_ews(self, ews):
    75         ews.bind_to_tool(MockTool())
    76         expected_stderr = self._default_expected_stderr(ews)
    77         string_replacemnts = {"name": ews.name}
    78         expected_stderr["process_work_item"] = "MOCK: update_status: %(name)s Error: %(name)s cannot process patches from non-committers :(\nMOCK: release_work_item: %(name)s 10000\n" % string_replacemnts
    79         self.assert_queue_outputs(ews, expected_stderr=expected_stderr)
    80 
    8174    def _test_testing_ews(self, ews):
    8275        ews.layout_test_results = lambda: None
     
    8578        expected_stderr["handle_script_error"] = "ScriptError error message\n"
    8679        self.assert_queue_outputs(ews, expected_stderr=expected_stderr)
    87 
    88     def test_committer_only_ewses(self):
    89         self._test_committer_only_ews(ChromiumMacEWS())
    9080
    9181    def test_builder_ewses(self):
Note: See TracChangeset for help on using the changeset viewer.