Changeset 107299 in webkit


Ignore:
Timestamp:
Feb 9, 2012 3:41:30 PM (12 years ago)
Author:
haraken@chromium.org
Message:

Rename [Return] to [CustomReturn]
​https://bugs.webkit.org/show_bug.cgi?id=78225

Reviewed by Adam Barth.

[Return] is used to handle custom code for a returned value.
To clarify it, this patch renames [Return] to [CustomReturn].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • dom/Node.idl:
Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r107296 r107299  
     12012-02-09  Kentaro Hara  <haraken@chromium.org>
     2
     3        Rename [Return] to [CustomReturn]
     4        https://bugs.webkit.org/show_bug.cgi?id=78225
     5
     6        Reviewed by Adam Barth.
     7
     8        [Return] is used to handle custom code for a returned value.
     9        To clarify it, this patch renames [Return] to [CustomReturn].
     10
     11        No tests. No change in behavior.
     12
     13        * bindings/scripts/CodeGeneratorCPP.pm:
     14        (GenerateImplementation):
     15        * bindings/scripts/CodeGeneratorGObject.pm:
     16        (GenerateFunction):
     17        * bindings/scripts/CodeGeneratorObjC.pm:
     18        (GenerateImplementation):
     19        * dom/Node.idl:
     20
    1212012-02-09  Levi Weintraub  <leviw@chromium.org>
    222

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm

    r107148 r107299  
    808808
    809809                push(@parameterNames, $implGetter);
    810                 $needsCustom{"NodeToReturn"} = $paramName if $param->extendedAttributes->{"Return"};
     810                $needsCustom{"NodeToReturn"} = $paramName if $param->extendedAttributes->{"CustomReturn"};
    811811
    812812                unless ($codeGenerator->IsPrimitiveType($idlType) or $codeGenerator->IsStringType($idlType)) {

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm

    r107034 r107299  
    869869            push(@cBody, "    }\n");
    870870        }
    871         $returnParamName = "converted_".$paramName if $param->extendedAttributes->{"Return"};
     871        $returnParamName = "converted_".$paramName if $param->extendedAttributes->{"CustomReturn"};
    872872    }
    873873

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm

    r107148 r107299  
    14961496                $needsCustom{"EventListener"} = $paramName if $idlType eq "EventListener";
    14971497                $needsCustom{"EventTarget"} = $paramName if $idlType eq "EventTarget";
    1498                 $needsCustom{"NodeToReturn"} = $paramName if $param->extendedAttributes->{"Return"};
     1498                $needsCustom{"NodeToReturn"} = $paramName if $param->extendedAttributes->{"CustomReturn"};
    14991499
    15001500                unless ($codeGenerator->IsPrimitiveType($idlType) or $codeGenerator->IsStringType($idlType)) {

  • trunk/Source/WebCore/dom/Node.idl

    r107204 r107299  
    6868        readonly attribute Document         ownerDocument;
    6969
    70         [ObjCLegacyUnnamedParameters, Custom] Node insertBefore(in [Return] Node newChild,
    71                                                  in Node refChild)
     70        [ObjCLegacyUnnamedParameters, Custom] Node insertBefore(in [CustomReturn] Node newChild,
     71                                                                in Node refChild)
    7272            raises(DOMException);
    7373        [ObjCLegacyUnnamedParameters, Custom] Node replaceChild(in Node newChild,
    74                                                  in [Return] Node oldChild)
     74                                                                in [CustomReturn] Node oldChild)
    7575            raises(DOMExceptionJSC);
    76         [Custom] Node               removeChild(in [Return] Node oldChild)
     76        [Custom] Node               removeChild(in [CustomReturn] Node oldChild)
    7777            raises(DOMException);
    78         [Custom] Node               appendChild(in [Return] Node newChild)
     78        [Custom] Node               appendChild(in [CustomReturn] Node newChild)
    7979            raises(DOMException);
    8080
Note: See TracChangeset for help on using the changeset viewer.