Changeset 107302 in webkit
- Timestamp:
- Feb 9, 2012 4:09:31 PM (12 years ago)
- Location:
- trunk/Tools
- Files:
-
- 28 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r107297 r107302 1 2012-02-09 Eric Seidel <eric@webkit.org> 2 3 Remove more uses of "os" from our webkitpy code 4 https://bugs.webkit.org/show_bug.cgi?id=78292 5 6 Reviewed by Adam Barth. 7 8 * Scripts/webkitpy/common/checkout/checkout_mock.py: 9 (MockCheckout.__init__): 10 (MockCheckout.is_path_to_changelog): 11 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 12 * Scripts/webkitpy/common/system/filesystem_mock.py: 13 (MockFileSystem._split): 14 * Scripts/webkitpy/common/system/zipfileset_unittest.py: 15 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: 16 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 17 * Scripts/webkitpy/layout_tests/port/webkit.py: 18 * Scripts/webkitpy/tool/bot/queueengine.py: 19 * Scripts/webkitpy/tool/bot/sheriff_unittest.py: 20 * Scripts/webkitpy/tool/commands/download.py: 21 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 22 * Scripts/webkitpy/tool/commands/rebaselineserver.py: 23 * Scripts/webkitpy/tool/commands/sheriffbot.py: 24 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 25 * Scripts/webkitpy/tool/commands/upload.py: 26 (CreateBug.prompt_for_bug_title_and_comment): 27 * Scripts/webkitpy/tool/servers/reflectionhandler.py: 28 * Scripts/webkitpy/tool/steps/attachtobug.py: 29 (AttachToBug.run): 30 * Scripts/webkitpy/tool/steps/checkstyle.py: 31 * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py: 32 * Scripts/webkitpy/tool/steps/commit_unittest.py: 33 * Scripts/webkitpy/tool/steps/editchangelog.py: 34 * Scripts/webkitpy/tool/steps/preparechangelog.py: 35 * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: 36 (PrepareChangeLogTest.test_ensure_bug_url): 37 * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: 38 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: 39 * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 40 * Scripts/webkitpy/tool/steps/validatereviewer.py: 41 1 42 2012-02-09 Eric Seidel <eric@webkit.org> 2 43 -
trunk/Tools/Scripts/webkitpy/common/checkout/checkout_mock.py
r105945 r107302 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 28 29 import os30 31 29 from .deps_mock import MockDEPS 32 30 from .commitinfo import CommitInfo … … 35 33 from webkitpy.common.config.committers import CommitterList 36 34 from webkitpy.common.net.bugzilla.bugzilla_mock import _mock_reviewers 35 from webkitpy.common.system.filesystem_mock import MockFileSystem 37 36 38 37 … … 43 42 44 43 class MockCheckout(object): 44 def __init__(self): 45 # FIXME: It's unclear if a MockCheckout is very useful. A normal Checkout 46 # with a MockSCM/MockFileSystem/MockExecutive is probably better. 47 self._filesystem = MockFileSystem() 45 48 46 49 # FIXME: This should move onto the Host object, and we should use a MockCommitterList for tests. … … 65 68 66 69 def is_path_to_changelog(self, path): 67 # FIXME: This should self._filesystem.basename. 68 return os.path.basename(path) == "ChangeLog" 70 return self._filesystem.basename(path) == "ChangeLog" 69 71 70 72 def bug_id_for_revision(self, svn_revision): -
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
r105842 r107302 32 32 33 33 import mimetypes 34 import os.path35 34 import re 36 35 import StringIO -
trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py
r107145 r107302 72 72 73 73 def _split(self, path): 74 return path.rsplit(self.sep, 1) 74 # This is not quite a full implementation of os.path.split 75 # http://docs.python.org/library/os.path.html#os.path.split 76 if self.sep in path: 77 return path.rsplit(self.sep, 1) 78 return ('', path) 75 79 76 80 def abspath(self, path): -
trunk/Tools/Scripts/webkitpy/common/system/zipfileset_unittest.py
r77093 r107302 22 22 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 23 24 import os25 24 import shutil 26 25 import tempfile -
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py
r101907 r107302 29 29 30 30 import logging 31 import os32 31 33 32 from webkitpy.common.system.crashlogs import CrashLogs -
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py
r107139 r107302 29 29 import json 30 30 import logging 31 import os32 31 import subprocess 33 32 import sys -
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
r107284 r107302 36 36 import logging 37 37 import operator 38 import os39 38 import re 40 39 import sys -
trunk/Tools/Scripts/webkitpy/tool/bot/queueengine.py
r106721 r107302 28 28 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 29 29 30 import os31 30 import sys 32 import time33 31 import traceback 34 32 -
trunk/Tools/Scripts/webkitpy/tool/bot/sheriff_unittest.py
r68746 r107302 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 28 29 import os30 29 import unittest 31 30 -
trunk/Tools/Scripts/webkitpy/tool/commands/download.py
r106832 r107302 28 28 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 29 29 30 import os31 32 30 from webkitpy.tool import steps 33 31 -
trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py
r107297 r107302 26 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 29 import os30 28 31 29 from webkitpy.thirdparty.mock import Mock -
trunk/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py
r99233 r107302 30 30 results directory), provides comparisons of expected and actual results (both 31 31 images and text) and allows one-click rebaselining of tests.""" 32 33 import os34 import os.path35 32 36 33 from webkitpy.common import system -
trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py
r107271 r107302 26 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 29 import os30 28 31 29 from webkitpy.common.system.deprecated_logging import log -
trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py
r90636 r107302 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 28 29 import os30 31 29 from webkitpy.tool.commands.queuestest import QueuesTest 32 from webkitpy.tool.commands.sheriffbot import SheriffBot33 from webkitpy.tool.mocktool import *34 30 35 31 -
trunk/Tools/Scripts/webkitpy/tool/commands/upload.py
r106721 r107302 483 483 def prompt_for_bug_title_and_comment(self): 484 484 bug_title = User.prompt("Bug title: ") 485 # FIXME: User should provide a function for doing this multi-line prompt. 485 486 print "Bug comment (hit ^D on blank line to end):" 486 487 lines = sys.stdin.readlines() -
trunk/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py
r107139 r107302 35 35 import json 36 36 import mimetypes 37 import os38 37 import os.path 39 38 import shutil … … 43 42 import wsgiref.handlers 44 43 import BaseHTTPServer 44 45 45 46 46 class ReflectionHandler(BaseHTTPServer.BaseHTTPRequestHandler): -
trunk/Tools/Scripts/webkitpy/tool/steps/attachtobug.py
r80537 r107302 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 28 29 import os30 31 29 from webkitpy.tool.steps.abstractstep import AbstractStep 32 30 from webkitpy.tool.steps.options import Options … … 44 42 filepath = state["filepath"] 45 43 bug_id = state["bug_id"] 46 description = self._options.description or filepath.split(os.sep)[-1]44 description = self._options.description or self._tool.filesystem.basename(filepath) 47 45 comment_text = self._options.comment 48 46 -
trunk/Tools/Scripts/webkitpy/tool/steps/checkstyle.py
r106721 r107302 26 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 29 import os30 28 31 29 from webkitpy.common.system.executive import ScriptError -
trunk/Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py
r90978 r107302 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 28 29 import os30 31 29 from webkitpy.tool.steps.abstractstep import AbstractStep 32 30 from webkitpy.tool.steps.options import Options -
trunk/Tools/Scripts/webkitpy/tool/steps/commit_unittest.py
r105213 r107302 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 28 29 import os30 29 import unittest 31 30 -
trunk/Tools/Scripts/webkitpy/tool/steps/editchangelog.py
r91210 r107302 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 28 29 import os30 31 29 from webkitpy.tool.steps.abstractstep import AbstractStep 32 30 -
trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py
r101834 r107302 26 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 29 import os30 28 31 29 from webkitpy.common.checkout.changelog import ChangeLog -
trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelog_unittest.py
r107293 r107302 40 40 class PrepareChangeLogTest(changelog_unittest.ChangeLogTest): 41 41 def test_ensure_bug_url(self): 42 # FIXME: This should use a MockFileSystem instead of a real FileSystem. 42 43 capture = OutputCapture() 43 44 step = PrepareChangeLog(MockTool(), MockOptions()) -
trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py
r90537 r107302 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 28 29 import os30 31 29 from webkitpy.common.checkout.changelog import ChangeLog 32 30 from webkitpy.tool.steps.abstractstep import AbstractStep -
trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py
r91210 r107302 26 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 29 import os30 28 31 29 from webkitpy.common.checkout.changelog import ChangeLog -
trunk/Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py
r101834 r107302 26 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 29 import os30 28 31 29 from webkitpy.common.checkout.changelog import ChangeLog -
trunk/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py
r100407 r107302 27 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 28 29 import os30 import re31 32 29 from webkitpy.common.checkout.changelog import ChangeLog 33 30 from webkitpy.tool.steps.abstractstep import AbstractStep
Note: See TracChangeset
for help on using the changeset viewer.