Changeset 107350 in webkit
- Timestamp:
- Feb 9, 2012 8:30:52 PM (12 years ago)
- Location:
- trunk
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r107349 r107350 1 2012-02-09 Zan Dobersek <zandobersek@gmail.com> 2 3 [Gtk] security/set-form-autocomplete-attribute.html fails 4 https://bugs.webkit.org/show_bug.cgi?id=78261 5 6 Reviewed by Martin Robinson. 7 8 Unskip the newly-passing test 9 10 * platform/gtk/Skipped: 11 1 12 2012-02-09 MORITA Hajime <morrita@google.com> 2 13 -
trunk/LayoutTests/platform/gtk/Skipped
r107202 r107350 619 619 # Need to implement getFormValue(). 620 620 plugins/form-value.html 621 622 # Tests in security/ directory623 # Tests failing624 security/set-form-autocomplete-attribute.html625 621 626 622 # Tests that failed because we don't have an eventSender implementation -
trunk/Source/WebKit/gtk/ChangeLog
r107252 r107350 1 2012-02-09 Zan Dobersek <zandobersek@gmail.com> 2 3 [Gtk] security/set-form-autocomplete-attribute.html fails 4 https://bugs.webkit.org/show_bug.cgi?id=78261 5 6 Reviewed by Martin Robinson. 7 8 Add a helper function to DumpRenderTreeSupportGtk, returning 9 whether or not an element does perform autocompletion. 10 11 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 12 (DumpRenderTreeSupportGtk::elementDoesAutoCompleteForElementWithId): 13 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 14 (DumpRenderTreeSupportGtk): 15 1 16 2012-02-09 Martin Robinson <mrobinson@igalia.com> 2 17 -
trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp
r105607 r107350 914 914 #endif 915 915 } 916 917 bool DumpRenderTreeSupportGtk::elementDoesAutoCompleteForElementWithId(WebKitWebFrame* frame, JSStringRef id) 918 { 919 Frame* coreFrame = core(frame); 920 if (!coreFrame) 921 return false; 922 923 Document* document = coreFrame->document(); 924 ASSERT(document); 925 926 size_t bufferSize = JSStringGetMaximumUTF8CStringSize(id); 927 GOwnPtr<gchar> idBuffer(static_cast<gchar*>(g_malloc(bufferSize))); 928 JSStringGetUTF8CString(id, idBuffer.get(), bufferSize); 929 Node* coreNode = document->getElementById(String::fromUTF8(idBuffer.get())); 930 if (!coreNode || !coreNode->renderer()) 931 return false; 932 933 HTMLInputElement* inputElement = static_cast<HTMLInputElement*>(coreNode); 934 if (!inputElement) 935 return false; 936 937 return inputElement->isTextField() && !inputElement->isPasswordField() && inputElement->shouldAutocomplete(); 938 } -
trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h
r104591 r107350 88 88 static void setValueForUser(JSContextRef, JSValueRef, JSStringRef); 89 89 static bool shouldClose(WebKitWebFrame*); 90 static bool elementDoesAutoCompleteForElementWithId(WebKitWebFrame*, JSStringRef); 90 91 91 92 // WebKitWebView -
trunk/Tools/ChangeLog
r107329 r107350 1 2012-02-09 Zan Dobersek <zandobersek@gmail.com> 2 3 [Gtk] security/set-form-autocomplete-attribute.html fails 4 https://bugs.webkit.org/show_bug.cgi?id=78261 5 6 Reviewed by Martin Robinson. 7 8 Use the new helper in DumpRenderTreeSupportGtk to properly 9 test whether an element performs autocompletion. 10 11 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 12 (LayoutTestController::elementDoesAutoCompleteForElementWithId): 13 1 14 2012-02-09 James Robinson <jamesr@chromium.org> 2 15 -
trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
r106438 r107350 586 586 bool LayoutTestController::elementDoesAutoCompleteForElementWithId(JSStringRef id) 587 587 { 588 // FIXME: implement 589 return false; 588 return DumpRenderTreeSupportGtk::elementDoesAutoCompleteForElementWithId(mainFrame, id); 590 589 } 591 590
Note: See TracChangeset
for help on using the changeset viewer.