Changeset 107358 in webkit


Ignore:
Timestamp:
Feb 9, 2012 9:58:51 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Make WebGLRenderingContext::printWarningToConsole safer
https://bugs.webkit.org/show_bug.cgi?id=78284

Patch by Gregg Tavares <gman@google.com> on 2012-02-09
Reviewed by Kenneth Russell.

No new tests because no change in functionality.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r107357 r107358  
     12012-02-09  Gregg Tavares  <gman@google.com>
     2
     3        Make WebGLRenderingContext::printWarningToConsole safer
     4        https://bugs.webkit.org/show_bug.cgi?id=78284
     5
     6        Reviewed by Kenneth Russell.
     7
     8        No new tests because no change in functionality.
     9
     10        * html/canvas/WebGLRenderingContext.cpp:
     11        (WebCore):
     12        (WebCore::WebGLRenderingContext::printWarningToConsole):
     13
    1142012-02-09  W. James MacLean  <wjmaclean@chromium.org>
    215
  • trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp

    r107121 r107358  
    48914891void WebGLRenderingContext::printWarningToConsole(const String& message)
    48924892{
    4893     canvas()->document()->frame()->domWindow()->console()->addMessage(HTMLMessageSource, LogMessageType, WarningMessageLevel, message, canvas()->document()->url().string());
     4893    if (!canvas())
     4894        return;
     4895    Document* document = canvas()->document();
     4896    if (!document)
     4897        return;
     4898    Frame* frame = document->frame();
     4899    if (!frame)
     4900        return;
     4901    DOMWindow* window = frame->domWindow();
     4902    if (!window)
     4903        return;
     4904    Console* console = window->console();
     4905    if (!console)
     4906        return;
     4907    console->addMessage(HTMLMessageSource, LogMessageType, WarningMessageLevel, message, document->url().string());
    48944908}
    48954909
Note: See TracChangeset for help on using the changeset viewer.