Changeset 107374 in webkit

Timestamp:

Feb 10, 2012 12:05:53 AM (12 years ago)

Author:

Philippe Normand

Message:

[GTK] EWS command-line option to run the tests
​https://bugs.webkit.org/show_bug.cgi?id=78211

Reviewed by Adam Barth.

New --run-tests option (defaults to False) for the EWS commands.

• Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.init):
(AbstractEarlyWarningSystem.review_patch):
(ChromiumLinuxEWS):

• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSytemTest._test_builder_ews):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/commands/earlywarningsystem.py (modified) (4 diffs)
• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-02-09  Philippe Normand  <pnormand@igalia.com>
+
+        [GTK] EWS command-line option to run the tests
+        https://bugs.webkit.org/show_bug.cgi?id=78211
+
+        Reviewed by Adam Barth.
+
+        New --run-tests option (defaults to False) for the EWS commands.
+
+        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+        (AbstractEarlyWarningSystem):
+        (AbstractEarlyWarningSystem.__init__):
+        (AbstractEarlyWarningSystem.review_patch):
+        (ChromiumLinuxEWS):
+        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+        (EarlyWarningSytemTest._test_builder_ews):
+
 2012-02-09  Eric Seidel  <eric@webkit.org>
 

trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py

@@ -27 +27 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+from optparse import make_option
+
 from webkitpy.common.config.committers import CommitterList
 from webkitpy.common.config.ports import DeprecatedPort
@@ -40 +42 @@
 class AbstractEarlyWarningSystem(AbstractReviewQueue, EarlyWarningSystemTaskDelegate):
     _build_style = "release"
-    # FIXME: Switch _run_tests from opt-in to opt-out once more bots are ready to run tests.
-    _run_tests = False
+    # FIXME: Switch _default_run_tests from opt-in to opt-out once more bots are ready to run tests.
+    _default_run_tests = False
 
     def __init__(self):
-        AbstractReviewQueue.__init__(self)
+        options = [make_option("--run-tests", action="store_true", dest="run_tests", default=self._default_run_tests, help="Run the Layout tests for each patch")]
+        AbstractReviewQueue.__init__(self, options=options)
         self.port = DeprecatedPort.port(self.port_name)
 
@@ -74 +77 @@
 
     def review_patch(self, patch):
-        task = EarlyWarningSystemTask(self, patch, self._run_tests)
+        task = EarlyWarningSystemTask(self, patch, self._options.run_tests)
         if not task.validate():
             self._did_error(patch, "%s did not process patch." % self.name)
@@ -180 +183 @@
     name = "chromium-ews"
     port_name = "chromium-xvfb"
-    _run_tests = True
+    _default_run_tests = True
 
 

trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py

@@ -68 +68 @@
     def _test_builder_ews(self, ews):
         ews.bind_to_tool(MockTool())
-        self.assert_queue_outputs(ews, expected_stderr=self._default_expected_stderr(ews))
+        options = Mock()
+        options.port = None
+        options.run_tests = ews._default_run_tests
+        self.assert_queue_outputs(ews, expected_stderr=self._default_expected_stderr(ews), options=options)
 
     def _test_testing_ews(self, ews):