Changeset 107380 in webkit


Ignore:
Timestamp:
Feb 10, 2012 1:06:04 AM (12 years ago)
Author:
pfeldman@chromium.org
Message:

[Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode
https://bugs.webkit.org/show_bug.cgi?id=78330

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::innerPatchChildren):

LayoutTests:

  • platform/chromium/test_expectations.txt:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r107379 r107380  
     12012-02-10  Pavel Feldman  <pfeldman@google.com>
     2
     3        [Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode
     4        https://bugs.webkit.org/show_bug.cgi?id=78330
     5
     6        Reviewed by Yury Semikhatsky.
     7
     8        * platform/chromium/test_expectations.txt:
     9
    1102012-02-10  Adam Barth  <abarth@webkit.org>
    211
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r107379 r107380  
    39833983BUGWK47907 : media/video-empty-source.html = IMAGE+TEXT
    39843984
    3985 // Started crashing after r107242.
    3986 BUGWK78251 DEBUG XP : inspector/elements/edit-dom-actions.html = CRASH
    3987 BUGWK78251 DEBUG XP : inspector/elements/set-outer-html-body.html = CRASH
    3988 BUGWK78251 DEBUG XP : inspector/elements/undo-dom-edits.html = CRASH
    3989 
    39903985// Started to fail after r107349.
    39913986BUGWK78331 editing/spelling/spelling-marker-description.html = TEXT
  • trunk/LayoutTests/platform/qt/Skipped

    r107378 r107380  
    26182618fast/text/synthetic-bold-transformed.html
    26192619
    2620 # [Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode
    2621 # https://bugs.webkit.org/show_bug.cgi?id=78330
    2622 inspector/elements/set-outer-html-body.html
    2623 inspector/elements/set-outer-html-2.html
    2624 inspector/elements/undo-dom-edits.html
    2625 inspector/elements/set-outer-html.html
    2626 inspector/elements/edit-dom-actions.html
  • trunk/Source/WebCore/ChangeLog

    r107373 r107380  
     12012-02-10  Pavel Feldman  <pfeldman@google.com>
     2
     3        [Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode
     4        https://bugs.webkit.org/show_bug.cgi?id=78330
     5
     6        Reviewed by Yury Semikhatsky.
     7
     8        * inspector/DOMPatchSupport.cpp:
     9        (WebCore::DOMPatchSupport::innerPatchChildren):
     10
    1112012-02-09  Andrey Kosyakov  <caseq@chromium.org>
    212
  • trunk/Source/WebCore/inspector/DOMPatchSupport.cpp

    r107257 r107380  
    4646
    4747#include <wtf/Deque.h>
     48#include <wtf/HashTraits.h>
    4849#include <wtf/RefPtr.h>
    4950#include <wtf/SHA1.h>
     
    280281    // 1. First strip everything except for the nodes that retain. Collect pending merges.
    281282    HashMap<Digest*, Digest*> merges;
    282     HashSet<size_t> usedNewOrdinals;
     283    HashSet<size_t, WTF::IntHash<size_t>, WTF::UnsignedWithZeroKeyHashTraits<size_t> > usedNewOrdinals;
    283284    for (size_t i = 0; i < oldList.size(); ++i) {
    284285        if (oldMap[i].first) {
     
    321322
    322323    // Mark retained nodes as used, do not reuse node more than once.
    323     HashSet<size_t> usedOldOrdinals;
     324    HashSet<size_t, WTF::IntHash<size_t>, WTF::UnsignedWithZeroKeyHashTraits<size_t> > usedOldOrdinals;
    324325    for (size_t i = 0; i < newList.size(); ++i) {
    325326        if (!newMap[i].first)
Note: See TracChangeset for help on using the changeset viewer.