Changeset 107382 in webkit

Timestamp:

Feb 10, 2012 1:28:05 AM (12 years ago)

Author:

haraken@chromium.org

Message:

Remove [ConvertingNullStringTo] from CloseEvent.idl
​https://bugs.webkit.org/show_bug.cgi?id=78328

Reviewed by Adam Barth.

In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo],
(although in bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]).

Anyway, the spec says that "The reason attribute must return the value it was
initialized to. When the object is created, this attribute must be initialized to empty string."
​http://dev.w3.org/html5/websockets/#event-definitions
Thus, this patch removes [ConvertingNullStringTo] from CloseEvent.idl.

Test: fast/events/constructors/close-event-constructor.html

• websockets/CloseEvent.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• websockets/CloseEvent.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-10  Kentaro Hara  <haraken@chromium.org>
+
+        Remove [ConvertingNullStringTo] from CloseEvent.idl
+        https://bugs.webkit.org/show_bug.cgi?id=78328
+
+        Reviewed by Adam Barth.
+
+        In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo],
+        (although in bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]).
+
+        Anyway, the spec says that "The reason attribute must return the value it was
+        initialized to. When the object is created, this attribute must be initialized to empty string."
+        http://dev.w3.org/html5/websockets/#event-definitions
+        Thus, this patch removes [ConvertingNullStringTo] from CloseEvent.idl.
+
+        Test: fast/events/constructors/close-event-constructor.html
+
+        * websockets/CloseEvent.idl:
+
 2012-02-10  Pavel Feldman  <pfeldman@google.com>
 

trunk/Source/WebCore/websockets/CloseEvent.idl

@@ -37 +37 @@
         readonly attribute [InitializedByEventConstructor] boolean wasClean;
         readonly attribute [InitializedByEventConstructor] unsigned short code;
-        readonly attribute [InitializedByEventConstructor, ConvertingNullStringTo=Undefined] DOMString reason;
+        readonly attribute [InitializedByEventConstructor] DOMString reason;
     };