Changeset 107389 in webkit
- Timestamp:
- Feb 10, 2012 2:46:09 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r107388 r107389 1 2012-02-10 Noel Gordon <noel.gordon@gmail.com> 2 3 [chromium] Increase JPEG decoding performance some more 4 https://bugs.webkit.org/show_bug.cgi?id=78323 5 6 Reviewed by Adam Barth. 7 8 * platform/chromium/test_expectations.txt: tests containing jpeg images that will require 9 rebaselines, mostly together in a group, but some other expectations unattended to at the 10 current time, spread changes throughout the file. The following lists changed tests for 11 chrome mac and win: 12 13 compositing/geometry/horizontal-scroll-composited.html 14 compositing/geometry/vertical-scroll-composited.html 15 compositing/overflow/overflow-scaled-descendant-overlapping.html 16 fast/backgrounds/size/backgroundSize17.html 17 fast/backgrounds/size/backgroundSize18.html 18 fast/backgrounds/size/backgroundSize19.html 19 fast/backgrounds/size/backgroundSize20.html 20 fast/backgrounds/size/backgroundSize21.html 21 fast/backgrounds/size/backgroundSize22.html 22 fast/block/float/014.html 23 fast/images/color-jpeg-with-color-profile.html 24 fast/images/gray-scale-jpeg-with-color-profile.html 25 fast/images/image-css3-content-data.html 26 fast/images/ycbcr-with-cmyk-color-profile.html 27 fast/repaint/backgroundSizeRepaint.html 28 fast/repaint/block-layout-inline-children-replaced.html 29 fast/repaint/clipped-relative.html 30 fast/repaint/selected-replaced.html 31 fast/replaced/absolute-image-sizing.html 32 fast/replaced/image-onload.html 33 fast/replaced/image-sizing.html 34 fast/replaced/image-tag.html 35 fast/replaced/width100percent-image.html 36 fast/writing-mode/background-horizontal-bt.html 37 fast/writing-mode/background-vertical-lr.html 38 fast/writing-mode/background-vertical-rl.html 39 platform/chromium/compositing/img-layer-grow.html 40 svg/W3C-SVG-1.1/animate-elem-30-t.svg 41 svg/W3C-SVG-1.1/animate-elem-36-t.svg 42 svg/W3C-SVG-1.1/animate-elem-39-t.svg 43 svg/W3C-SVG-1.1/animate-elem-40-t.svg 44 svg/W3C-SVG-1.1/coords-viewattr-02-b.svg 45 svg/W3C-SVG-1.1/filters-image-01-b.svg 46 svg/W3C-SVG-1.1/struct-image-01-t.svg 47 svg/W3C-SVG-1.1/struct-image-02-b.svg 48 svg/W3C-SVG-1.1/struct-image-04-t.svg 49 svg/carto.net/scrollbar.svg 50 svg/carto.net/selectionlist.svg 51 svg/custom/image-rescale-clip.html 52 svg/custom/image-rescale-scroll.html 53 svg/custom/image-rescale.svg 54 svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html 55 svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html 56 tables/mozilla/bugs/bug101674.html 57 tables/mozilla/bugs/bug10565.html 58 tables/mozilla/bugs/bug11026.html 59 tables/mozilla/bugs/bug1188.html 60 tables/mozilla/bugs/bug120107.html 61 tables/mozilla/bugs/bug1271.html 62 tables/mozilla/bugs/bug12908-1.html 63 tables/mozilla/bugs/bug12908-2.html 64 tables/mozilla/bugs/bug1296.html 65 tables/mozilla/bugs/bug13169.html 66 tables/mozilla/bugs/bug1430.html 67 tables/mozilla/bugs/bug15544.html 68 tables/mozilla/bugs/bug17138.html 69 tables/mozilla/bugs/bug196870.html 70 tables/mozilla/bugs/bug29314.html 71 tables/mozilla/bugs/bug2981-2.html 72 tables/mozilla/bugs/bug4093.html 73 tables/mozilla/bugs/bug4284.html 74 tables/mozilla/bugs/bug4427.html 75 tables/mozilla/bugs/bug50695-2.html 76 tables/mozilla/bugs/bug56563.html 77 tables/mozilla/bugs/bug5797.html 78 tables/mozilla/bugs/bug625.html 79 tables/mozilla/bugs/bug6404.html 80 tables/mozilla/bugs/bug82946-2.html 81 tables/mozilla/bugs/bug86708.html 82 tables/mozilla/core/bloomberg.html 83 tables/mozilla/core/col_widths_auto_autoFix.html 84 tables/mozilla/core/misc.html 85 tables/mozilla/core/row_span.html 86 tables/mozilla/marvin/tbody_valign_baseline.html 87 tables/mozilla/marvin/tbody_valign_bottom.html 88 tables/mozilla/marvin/tbody_valign_middle.html 89 tables/mozilla/marvin/tbody_valign_top.html 90 tables/mozilla/marvin/td_valign_baseline.html 91 tables/mozilla/marvin/td_valign_bottom.html 92 tables/mozilla/marvin/td_valign_middle.html 93 tables/mozilla/marvin/td_valign_top.html 94 tables/mozilla/marvin/tfoot_valign_baseline.html 95 tables/mozilla/marvin/tfoot_valign_bottom.html 96 tables/mozilla/marvin/tfoot_valign_middle.html 97 tables/mozilla/marvin/tfoot_valign_top.html 98 tables/mozilla/marvin/th_valign_baseline.html 99 tables/mozilla/marvin/th_valign_bottom.html 100 tables/mozilla/marvin/th_valign_middle.html 101 tables/mozilla/marvin/th_valign_top.html 102 tables/mozilla/marvin/thead_valign_baseline.html 103 tables/mozilla/marvin/thead_valign_bottom.html 104 tables/mozilla/marvin/thead_valign_middle.html 105 tables/mozilla/marvin/thead_valign_top.html 106 tables/mozilla/marvin/tr_valign_baseline.html 107 tables/mozilla/marvin/tr_valign_bottom.html 108 tables/mozilla/marvin/tr_valign_middle.html 109 tables/mozilla/marvin/tr_valign_top.html 110 tables/mozilla/other/cell_widths.html 111 tables/mozilla_expected_failures/bugs/bug6933.html 112 tables/mozilla_expected_failures/bugs/bug85016.html 113 tables/mozilla_expected_failures/other/test4.html 114 1 115 2012-02-10 Pavel Podivilov <podivilov@chromium.org> 2 116 -
trunk/LayoutTests/platform/chromium/test_expectations.txt
r107385 r107389 102 102 // Unskip after changes on both sides have landed and rolled together. 103 103 BUGCR103939 SKIP : http/tests/appcache/wrong-content-type.html = TEXT 104 105 // Unskip and rebaseline all chromes once ifast jpeg decoder patch lands 106 BUGNOEL SKIP : compositing/geometry/horizontal-scroll-composited.html = IMAGE 107 BUGNOEL SKIP : compositing/geometry/vertical-scroll-composited.html = IMAGE 108 BUGNOEL SKIP : fast/backgrounds/size/backgroundSize17.html = IMAGE 109 BUGNOEL SKIP : fast/backgrounds/size/backgroundSize18.html = IMAGE 110 BUGNOEL SKIP : fast/backgrounds/size/backgroundSize19.html = IMAGE 111 BUGNOEL SKIP : fast/backgrounds/size/backgroundSize20.html = IMAGE 112 BUGNOEL SKIP : fast/backgrounds/size/backgroundSize21.html = IMAGE 113 BUGNOEL SKIP : fast/backgrounds/size/backgroundSize22.html = IMAGE 114 BUGNOEL SKIP : fast/block/float/014.html = IMAGE 115 BUGNOEL SKIP : fast/images/gray-scale-jpeg-with-color-profile.html = IMAGE 116 BUGNOEL SKIP : fast/images/image-css3-content-data.html = IMAGE 117 BUGNOEL SKIP : fast/images/ycbcr-with-cmyk-color-profile.html = IMAGE 118 BUGNOEL SKIP : fast/repaint/block-layout-inline-children-replaced.html = IMAGE 119 BUGNOEL SKIP : fast/replaced/absolute-image-sizing.html = IMAGE 120 BUGNOEL SKIP : fast/replaced/image-onload.html = IMAGE 121 BUGNOEL SKIP : fast/replaced/image-sizing.html = IMAGE 122 BUGNOEL SKIP : fast/replaced/image-tag.html = IMAGE 123 BUGNOEL SKIP : fast/replaced/width100percent-image.html = IMAGE 124 BUGNOEL SKIP : fast/writing-mode/background-horizontal-bt.html = IMAGE 125 BUGNOEL SKIP : fast/writing-mode/background-vertical-lr.html = IMAGE 126 BUGNOEL SKIP : fast/writing-mode/background-vertical-rl.html = IMAGE 127 BUGNOEL SKIP : platform/chromium/compositing/img-layer-grow.html = IMAGE 128 BUGNOEL SKIP : svg/W3C-SVG-1.1/animate-elem-30-t.svg = IMAGE 129 BUGNOEL SKIP : svg/W3C-SVG-1.1/coords-viewattr-02-b.svg = IMAGE 130 BUGNOEL SKIP : svg/W3C-SVG-1.1/filters-image-01-b.svg = IMAGE 131 BUGNOEL SKIP : svg/W3C-SVG-1.1/struct-image-01-t.svg = IMAGE 132 BUGNOEL SKIP : svg/W3C-SVG-1.1/struct-image-02-b.svg = IMAGE 133 BUGNOEL SKIP : svg/W3C-SVG-1.1/struct-image-04-t.svg = IMAGE 134 BUGNOEL SKIP : svg/carto.net/scrollbar.svg = IMAGE+TEXT 135 BUGNOEL SKIP : svg/carto.net/selectionlist.svg = IMAGE+TEXT 136 BUGNOEL SKIP : svg/custom/image-rescale-clip.html = IMAGE 137 BUGNOEL SKIP : svg/custom/image-rescale-scroll.html = IMAGE 138 BUGNOEL SKIP : svg/custom/image-rescale.svg = IMAGE 139 BUGNOEL SKIP : svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html = IMAGE 140 BUGNOEL SKIP : svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html = IMAGE 141 BUGNOEL SKIP : tables/mozilla/bugs/bug10565.html = IMAGE 142 BUGNOEL SKIP : tables/mozilla/bugs/bug11026.html = IMAGE 143 BUGNOEL SKIP : tables/mozilla/bugs/bug1188.html = IMAGE 144 BUGNOEL SKIP : tables/mozilla/bugs/bug120107.html = IMAGE 145 BUGNOEL SKIP : tables/mozilla/bugs/bug1271.html = IMAGE 146 BUGNOEL SKIP : tables/mozilla/bugs/bug12908-1.html = IMAGE 147 BUGNOEL SKIP : tables/mozilla/bugs/bug12908-2.html = IMAGE 148 BUGNOEL SKIP : tables/mozilla/bugs/bug1296.html = IMAGE 149 BUGNOEL SKIP : tables/mozilla/bugs/bug13169.html = IMAGE 150 BUGNOEL SKIP : tables/mozilla/bugs/bug1430.html = IMAGE 151 BUGNOEL SKIP : tables/mozilla/bugs/bug15544.html = IMAGE 152 BUGNOEL SKIP : tables/mozilla/bugs/bug17138.html = IMAGE 153 BUGNOEL SKIP : tables/mozilla/bugs/bug196870.html = IMAGE 154 BUGNOEL SKIP : tables/mozilla/bugs/bug29314.html = IMAGE 155 BUGNOEL SKIP : tables/mozilla/bugs/bug2981-2.html = IMAGE 156 BUGNOEL SKIP : tables/mozilla/bugs/bug4093.html = IMAGE 157 BUGNOEL SKIP : tables/mozilla/bugs/bug4284.html = IMAGE 158 BUGNOEL SKIP : tables/mozilla/bugs/bug4427.html = IMAGE 159 BUGNOEL SKIP : tables/mozilla/bugs/bug50695-2.html = IMAGE 160 BUGNOEL SKIP : tables/mozilla/bugs/bug56563.html = IMAGE 161 BUGNOEL SKIP : tables/mozilla/bugs/bug5797.html = IMAGE 162 BUGNOEL SKIP : tables/mozilla/bugs/bug625.html = IMAGE 163 BUGNOEL SKIP : tables/mozilla/bugs/bug6404.html = IMAGE 164 BUGNOEL SKIP : tables/mozilla/core/col_widths_auto_autoFix.html = IMAGE 165 BUGNOEL SKIP : tables/mozilla/marvin/tbody_valign_baseline.html = IMAGE 166 BUGNOEL SKIP : tables/mozilla/marvin/tbody_valign_bottom.html = IMAGE 167 BUGNOEL SKIP : tables/mozilla/marvin/tbody_valign_middle.html = IMAGE 168 BUGNOEL SKIP : tables/mozilla/marvin/tbody_valign_top.html = IMAGE 169 BUGNOEL SKIP : tables/mozilla/marvin/td_valign_baseline.html = IMAGE 170 BUGNOEL SKIP : tables/mozilla/marvin/td_valign_bottom.html = IMAGE 171 BUGNOEL SKIP : tables/mozilla/marvin/td_valign_middle.html = IMAGE 172 BUGNOEL SKIP : tables/mozilla/marvin/td_valign_top.html = IMAGE 173 BUGNOEL SKIP : tables/mozilla/marvin/tfoot_valign_baseline.html = IMAGE 174 BUGNOEL SKIP : tables/mozilla/marvin/tfoot_valign_bottom.html = IMAGE 175 BUGNOEL SKIP : tables/mozilla/marvin/tfoot_valign_middle.html = IMAGE 176 BUGNOEL SKIP : tables/mozilla/marvin/tfoot_valign_top.html = IMAGE 177 BUGNOEL SKIP : tables/mozilla/marvin/th_valign_baseline.html = IMAGE 178 BUGNOEL SKIP : tables/mozilla/marvin/th_valign_bottom.html = IMAGE 179 BUGNOEL SKIP : tables/mozilla/marvin/th_valign_middle.html = IMAGE 180 BUGNOEL SKIP : tables/mozilla/marvin/th_valign_top.html = IMAGE 181 BUGNOEL SKIP : tables/mozilla/marvin/thead_valign_baseline.html = IMAGE 182 BUGNOEL SKIP : tables/mozilla/marvin/thead_valign_bottom.html = IMAGE 183 BUGNOEL SKIP : tables/mozilla/marvin/thead_valign_middle.html = IMAGE 184 BUGNOEL SKIP : tables/mozilla/marvin/thead_valign_top.html = IMAGE 185 BUGNOEL SKIP : tables/mozilla/marvin/tr_valign_baseline.html = IMAGE 186 BUGNOEL SKIP : tables/mozilla/marvin/tr_valign_bottom.html = IMAGE 187 BUGNOEL SKIP : tables/mozilla/marvin/tr_valign_middle.html = IMAGE 188 BUGNOEL SKIP : tables/mozilla/marvin/tr_valign_top.html = IMAGE 189 BUGNOEL SKIP : tables/mozilla_expected_failures/bugs/bug6933.html = IMAGE 190 BUGNOEL SKIP : tables/mozilla_expected_failures/bugs/bug85016.html = IMAGE 191 BUGNOEL SKIP : tables/mozilla_expected_failures/other/test4.html = IMAGE 104 192 105 193 // ----------------------------------------------------------------- … … 1346 1434 BUGCR23473 MAC : fast/repaint/4776765.html = IMAGE 1347 1435 BUGCR23473 MAC : fast/repaint/background-generated.html = IMAGE 1348 BUGCR23473 MAC: fast/repaint/backgroundSizeRepaint.html = IMAGE1436 BUGCR23473 : fast/repaint/backgroundSizeRepaint.html = IMAGE 1349 1437 BUGCR23473 MAC : fast/repaint/block-selection-gap-in-table-cell.html = IMAGE 1350 1438 BUGCR23473 MAC : fast/repaint/body-background-image.html = IMAGE … … 1360 1448 BUGCR23473 MAC : fast/repaint/button-spurious-layout-hint.html = IMAGE 1361 1449 BUGCR23473 MAC : fast/repaint/change-transform.html = IMAGE 1362 BUGCR23473 MAC: fast/repaint/clipped-relative.html = IMAGE1450 BUGCR23473 : fast/repaint/clipped-relative.html = IMAGE 1363 1451 BUGCR23473 MAC : fast/repaint/clip-with-layout-delta.html = IMAGE 1364 1452 BUGCR23473 MAC : fast/repaint/containing-block-position-change.html = IMAGE … … 1408 1496 BUGCR23473 MAC : fast/repaint/repaint-resized-overflow.html = IMAGE 1409 1497 BUGCR23473 MAC : fast/repaint/search-field-cancel.html = IMAGE 1410 BUGCR23473 MAC: fast/repaint/selected-replaced.html = IMAGE1498 BUGCR23473 : fast/repaint/selected-replaced.html = IMAGE 1411 1499 BUGCR23473 MAC : fast/repaint/selection-after-delete.html = IMAGE 1412 1500 BUGCR23473 MAC : fast/repaint/selection-clear.html = IMAGE … … 1523 1611 BUGCR99500 WIN : fast/repaint/reflection-redraw.html = IMAGE 1524 1612 BUGCR99500 WIN : printing/width-overflow.html = IMAGE 1525 BUGCR99500 WIN: svg/W3C-SVG-1.1/animate-elem-36-t.svg = IMAGE1613 BUGCR99500 : svg/W3C-SVG-1.1/animate-elem-36-t.svg = IMAGE 1526 1614 BUGCR99500 WIN : svg/W3C-SVG-1.1/animate-elem-37-t.svg = IMAGE 1527 BUGCR99500 WIN: svg/W3C-SVG-1.1/animate-elem-39-t.svg = IMAGE1528 BUGCR99500 WIN: svg/W3C-SVG-1.1/animate-elem-40-t.svg = IMAGE1615 BUGCR99500 : svg/W3C-SVG-1.1/animate-elem-39-t.svg = IMAGE 1616 BUGCR99500 : svg/W3C-SVG-1.1/animate-elem-40-t.svg = IMAGE 1529 1617 BUGCR99500 WIN : svg/W3C-SVG-1.1/animate-elem-41-t.svg = IMAGE 1530 1618 BUGCR99500 WIN : svg/W3C-SVG-1.1/animate-elem-46-t.svg = IMAGE … … 2407 2495 BUGCR65012 LINUX : fast/dom/HTMLHeadElement/head-check.html = PASS CRASH 2408 2496 2409 BUG_VITALYR MAC: tables/mozilla/bugs/bug82946-2.html = IMAGE2497 BUG_VITALYR : tables/mozilla/bugs/bug82946-2.html = IMAGE 2410 2498 2411 2499 BUGWK70878 LINUX : http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html = PASS TIMEOUT … … 2608 2696 BUGWK54322 SNOWLEOPARD : fast/text/international/text-combine-image-test.html = IMAGE 2609 2697 BUGWK54322 SNOWLEOPARD : fonts/monospace.html = IMAGE 2610 BUGWK54322 SNOWLEOPARD: tables/mozilla/core/bloomberg.html = IMAGE2611 BUGWK54322 SNOWLEOPARD: tables/mozilla/core/misc.html = IMAGE2612 BUGWK54322 SNOWLEOPARD: tables/mozilla/core/row_span.html = IMAGE2613 BUGWK54322 SNOWLEOPARD: tables/mozilla/other/cell_widths.html = IMAGE2698 BUGWK54322 : tables/mozilla/core/bloomberg.html = IMAGE 2699 BUGWK54322 : tables/mozilla/core/misc.html = IMAGE 2700 BUGWK54322 : tables/mozilla/core/row_span.html = IMAGE 2701 BUGWK54322 : tables/mozilla/other/cell_widths.html = IMAGE 2614 2702 BUGWK54322 SNOWLEOPARD : transitions/move-after-transition.html = IMAGE 2615 2703 BUGWK54322 SNOWLEOPARD : fast/dom/scroll-reveal-left-overflow.html = IMAGE … … 3386 3474 BUGWK69998 LINUX WIN : plugins/refcount-leaks.html = PASS TEXT 3387 3475 BUGWK70001 LINUX WIN : fast/images/color-jpeg-with-color-profile.html = FAIL MISSING 3476 BUGNOEL MAC : fast/images/color-jpeg-with-color-profile.html = IMAGE 3388 3477 3389 3478 // V8 handles stack overflow exceptions differently than JSC … … 3977 4066 3978 4067 // Some of the new baselines don't make any sense. 3979 BUGWK78175 DEBUG SNOWLEOPARD : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE 4068 // BUGWK78175 DEBUG SNOWLEOPARD : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE 4069 BUGNOEL SKIP : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE 3980 4070 3981 4071 // Just needs a rebaseline. -
trunk/Source/WebCore/ChangeLog
r107384 r107389 1 2012-02-10 Noel Gordon <noel.gordon@gmail.com> 2 3 [chromium] Increase JPEG decoding performance some more 4 https://bugs.webkit.org/show_bug.cgi?id=78323 5 6 Reviewed by Adam Barth. 7 8 Increase JPEG image decoding speed by another 9% (avg) according to libjpeg-turbo tjbench. 9 10 No new tests. Covered by many existing tests, all requiring subsequent rebaselines. 11 12 * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: 13 (dctMethod): Fast decode on the jpeg-turbo using ports (Chrome Android, Chrome, Chromium). 14 (WebCore::JPEGImageReader::decode): Select DCT method via a helper routine. 15 1 16 2012-02-10 Vsevolod Vlasov <vsevik@chromium.org> 2 17 -
trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
r106203 r107389 71 71 72 72 #if defined(JCS_ALPHA_EXTENSIONS) && ASSUME_LITTLE_ENDIAN 73 inline J_DCT_METHOD dctMethod() { return JDCT_IFAST; } 73 74 #define TURBO_JPEG_RGB_SWIZZLE 74 75 #if USE(SKIA) && (!SK_R32_SHIFT && SK_G32_SHIFT == 8 && SK_B32_SHIFT == 16) … … 79 80 inline bool turboSwizzled(J_COLOR_SPACE colorSpace) { return colorSpace == rgbOutputColorSpace(); } 80 81 #else 82 inline J_DCT_METHOD dctMethod() { return JDCT_ISLOW; } 81 83 inline J_COLOR_SPACE rgbOutputColorSpace() { return JCS_RGB; } 82 84 #endif … … 292 294 // FIXME -- Should reset dct_method and dither mode for final pass 293 295 // of progressive JPEG. 294 m_info.dct_method = JDCT_ISLOW;296 m_info.dct_method = dctMethod(); 295 297 m_info.dither_mode = JDITHER_FS; 296 298 m_info.do_fancy_upsampling = true;
Note: See TracChangeset
for help on using the changeset viewer.