Changeset 107432 in webkit


Ignore:
Timestamp:
Feb 10, 2012 1:03:13 PM (12 years ago)
Author:
haraken@chromium.org
Message:

Rename [JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor]
​https://bugs.webkit.org/show_bug.cgi?id=78352

Reviewed by Adam Barth.

[JSCustomGetOwnPropertySlotDelegate] is used for "flexibly customizable"
named getter. It allows us to write custom code for getOwnPropertySlotDelegate()
and getOwnPropertyDescriptorDelegate(). To clarify that, we can rename
[JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLObjectElement.idl:
  • page/History.idl:
  • page/Location.idl:
  • workers/WorkerContext.idl:
Location:
trunk/Source/WebCore
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r107431 r107432  
     12012-02-10  Kentaro Hara  <haraken@chromium.org>
     2
     3        Rename [JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor]
     4        https://bugs.webkit.org/show_bug.cgi?id=78352
     5
     6        Reviewed by Adam Barth.
     7
     8        [JSCustomGetOwnPropertySlotDelegate] is used for "flexibly customizable"
     9        named getter. It allows us to write custom code for getOwnPropertySlotDelegate()
     10        and getOwnPropertyDescriptorDelegate(). To clarify that, we can rename
     11        [JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor].
     12
     13        No tests. No change in behavior.
     14
     15        * bindings/scripts/CodeGeneratorJS.pm:
     16        (GenerateGetOwnPropertySlotBody):
     17        (GenerateGetOwnPropertyDescriptorBody):
     18        (GenerateHeader):
     19        (GenerateImplementation):
     20
     21        * html/HTMLAppletElement.idl:
     22        * html/HTMLEmbedElement.idl:
     23        * html/HTMLObjectElement.idl:
     24        * page/History.idl:
     25        * page/Location.idl:
     26        * workers/WorkerContext.idl:
     27
    1282012-02-10  Anders Carlsson  <andersca@apple.com>
    229

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r107410 r107432  
    470470    }
    471471
    472     if ($dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"}) {
     472    if ($dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"}) {
    473473        push(@getOwnPropertySlotImpl, "    if (thisObject->getOwnPropertySlotDelegate(exec, propertyName, slot))\n");
    474474        push(@getOwnPropertySlotImpl, "        return true;\n");
    … …  
    571571    }
    572572
    573     if ($dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"}) {
     573    if ($dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"}) {
    574574        push(@getOwnPropertyDescriptorImpl, "    if (thisObject->getOwnPropertyDescriptorDelegate(exec, propertyName, descriptor))\n");
    575575        push(@getOwnPropertyDescriptorImpl, "        return true;\n");
    … …  
    759759                 || $dataNode->extendedAttributes->{"NumericIndexedGetter"}
    760760                 || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"}
    761                  || $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"}
     761                 || $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"}
    762762                 || $dataNode->extendedAttributes->{"NamedGetter"}
    763763                 || $dataNode->extendedAttributes->{"CustomNamedGetter"};
    … …  
    768768        push(@headerContent, "    static bool getOwnPropertyDescriptor(JSC::JSObject*, JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertyDescriptor&);\n");
    769769        push(@headerContent, "    static bool getOwnPropertySlotByIndex(JSC::JSCell*, JSC::ExecState*, unsigned propertyName, JSC::PropertySlot&);\n") if ($dataNode->extendedAttributes->{"IndexedGetter"} || $dataNode->extendedAttributes->{"NumericIndexedGetter"}) && !$dataNode->extendedAttributes->{"CustomNamedGetter"};
    770         push(@headerContent, "    bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);\n") if $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"};
    771         push(@headerContent, "    bool getOwnPropertyDescriptorDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertyDescriptor&);\n") if $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"};
     770        push(@headerContent, "    bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);\n") if $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"};
     771        push(@headerContent, "    bool getOwnPropertyDescriptorDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertyDescriptor&);\n") if $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"};
    772772        $structureFlags{"JSC::OverridesGetOwnPropertySlot"} = 1;
    773773    }
    … …  
    16241624                 || $dataNode->extendedAttributes->{"IndexedGetter"}
    16251625                 || $dataNode->extendedAttributes->{"NumericIndexedGetter"}
    1626                  || $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"}
     1626                 || $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"}
    16271627                 || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"}
    16281628                 || $dataNode->extendedAttributes->{"NamedGetter"}

  • trunk/Source/WebCore/html/HTMLAppletElement.idl

    r107051 r107432  
    2323    interface [
    2424        CustomNamedSetter,
    25         JSCustomGetOwnPropertySlotDelegate,
     25        JSCustomGetOwnPropertySlotAndDescriptor,
    2626        CustomCall
    2727    ] HTMLAppletElement : HTMLElement {

  • trunk/Source/WebCore/html/HTMLEmbedElement.idl

    r107051 r107432  
    2323    interface [
    2424        CustomNamedSetter,
    25         JSCustomGetOwnPropertySlotDelegate,
     25        JSCustomGetOwnPropertySlotAndDescriptor,
    2626        CustomCall
    2727    ] HTMLEmbedElement : HTMLElement {

  • trunk/Source/WebCore/html/HTMLObjectElement.idl

    r107051 r107432  
    2323    interface [
    2424        CustomNamedSetter,
    25         JSCustomGetOwnPropertySlotDelegate,
     25        JSCustomGetOwnPropertySlotAndDescriptor,
    2626        CustomCall
    2727    ] HTMLObjectElement : HTMLElement {

  • trunk/Source/WebCore/page/History.idl

    r107410 r107432  
    3030        CheckDomainSecurity,
    3131#endif
    32         JSCustomGetOwnPropertySlotDelegate,
     32        JSCustomGetOwnPropertySlotAndDescriptor,
    3333        CustomNamedSetter,
    3434        JSGenerateIsReachable=ImplFrame,

  • trunk/Source/WebCore/page/Location.idl

    r107410 r107432  
    3333        CheckDomainSecurity,
    3434#endif
    35         JSCustomGetOwnPropertySlotDelegate,
     35        JSCustomGetOwnPropertySlotAndDescriptor,
    3636        CustomNamedSetter,
    3737        JSGenerateIsReachable=ImplFrame,

  • trunk/Source/WebCore/workers/WorkerContext.idl

    r107304 r107432  
    3030        Conditional=WORKERS,
    3131        JSCustomMarkFunction,
    32         JSCustomGetOwnPropertySlotDelegate,
     32        JSCustomGetOwnPropertySlotAndDescriptor,
    3333        EventTarget,
    3434        ExtendsDOMGlobalObject,
Note: See TracChangeset for help on using the changeset viewer.