Changeset 107436 in webkit

Timestamp:

Feb 10, 2012 1:43:22 PM (12 years ago)

Author:

haraken@chromium.org

Message:

Rename [JSCustomPrototypePutDelegate] to [JSCustomNamedGetterOnPrototype]
​https://bugs.webkit.org/show_bug.cgi?id=78353

Reviewed by Adam Barth.

[JSCustomPrototypePutDelegate] is used to write custom code for named
getters on a prototype interface. "PutDelegate" is just a method name
in implementation and not so descriptive. This patch renames it to
[JSCustomNamedGetterOnPrototype]. This is also for naming consistency
with [CustomNamedGetter].

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

• page/Location.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorJS.pm (modified) (2 diffs)
• page/Location.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-10  Kentaro Hara  <haraken@chromium.org>
+
+        Rename [JSCustomPrototypePutDelegate] to [JSCustomNamedGetterOnPrototype]
+        https://bugs.webkit.org/show_bug.cgi?id=78353
+
+        Reviewed by Adam Barth.
+
+        [JSCustomPrototypePutDelegate] is used to write custom code for named
+        getters on a prototype interface. "PutDelegate" is just a method name
+        in implementation and not so descriptive. This patch renames it to
+        [JSCustomNamedGetterOnPrototype]. This is also for naming consistency
+        with [CustomNamedGetter].
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateHeader):
+        (GenerateImplementation):
+        * page/Location.idl:
+
 2012-02-10  Enrica Casucci  <enrica@apple.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -1049 +1049 @@
         "        return JSC::Structure::create(globalData, globalObject, prototype, JSC::TypeInfo(JSC::ObjectType, StructureFlags), &s_info);\n" .
         "    }\n");
-    if ($dataNode->extendedAttributes->{"JSCustomPrototypePutDelegate"}) {
+    if ($dataNode->extendedAttributes->{"JSCustomNamedGetterOnPrototype"}) {
         push(@headerContent, "    static void put(JSC::JSCell*, JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);\n");
         push(@headerContent, "    bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);\n");
@@ -1518 +1518 @@
     }
 
-    if ($dataNode->extendedAttributes->{"JSCustomPrototypePutDelegate"}) {
+    if ($dataNode->extendedAttributes->{"JSCustomNamedGetterOnPrototype"}) {
         push(@implContent, "void ${className}Prototype::put(JSCell* cell, ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)\n");
         push(@implContent, "{\n");

trunk/Source/WebCore/page/Location.idl

@@ -39 +39 @@
         CustomEnumerateProperty,
         JSCustomDefineOwnProperty,
-        JSCustomPrototypePutDelegate,
+        JSCustomNamedGetterOnPrototype,
         JSCustomPrototypeDefineOwnProperty,
         OmitConstructor