Changeset 107463 in webkit


Ignore:
Timestamp:
Feb 10, 2012 5:20:34 PM (12 years ago)
Author:
dgrogan@chromium.org
Message:

Disable IndexedDB permissions check from shared workers
https://bugs.webkit.org/show_bug.cgi?id=78316

We want to temporarily bypass this check because it causes a crash
when called from a shared worker. We'll have to fix it before
including idb on shared workers in a release but don't want to stop
developers from testing out idb on shared workers.

No new tests because it affects shared workers only, which aren't
testable by DRT.

Reviewed by Tony Chang.

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIDBFromWorkerThread):

Location:
trunk/Source/WebKit/chromium
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/chromium/ChangeLog

    r107403 r107463  
     12012-02-10  David Grogan  <dgrogan@chromium.org>
     2
     3        Disable IndexedDB permissions check from shared workers
     4        https://bugs.webkit.org/show_bug.cgi?id=78316
     5
     6        We want to temporarily bypass this check because it causes a crash
     7        when called from a shared worker.  We'll have to fix it before
     8        including idb on shared workers in a release but don't want to stop
     9        developers from testing out idb on shared workers.
     10
     11        No new tests because it affects shared workers only, which aren't
     12        testable by DRT.
     13
     14        Reviewed by Tony Chang.
     15
     16        * src/IDBFactoryBackendProxy.cpp:
     17        (WebKit::IDBFactoryBackendProxy::allowIDBFromWorkerThread):
     18
    1192012-02-10  Sheriff Bot  <webkit.review.bot@gmail.com>
    220
  • trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp

    r107174 r107463  
    158158bool IDBFactoryBackendProxy::allowIDBFromWorkerThread(WorkerContext* workerContext, const String& name, const WebSecurityOrigin&)
    159159{
     160    // FIXME: Bypass checking for permission so as not to block shared worker
     161    // testing until a permissions check is implemented. This has to be fixed
     162    // before m19 goes to beta. http://crbug.com/112855
     163    if (workerContext->isSharedWorkerContext())
     164        return true;
     165
    160166    WebWorkerClientImpl* webWorkerClientImpl = static_cast<WebWorkerClientImpl*>(&workerContext->thread()->workerLoaderProxy());
    161167    WorkerRunLoop& runLoop = workerContext->thread()->runLoop();
Note: See TracChangeset for help on using the changeset viewer.