Changeset 107482 in webkit

Timestamp:

Feb 11, 2012 10:36:37 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[GStreamer] html5test.com says that gstreamer ports do not support WebM for audio
​https://bugs.webkit.org/show_bug.cgi?id=78244

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-11
Reviewed by Eric Seidel.

Specifically advertise support for audio/webm when we support the vorbis
audio codec. This is necessary because gstreamer doesn't advertise it.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::mimeTypeCache): Add an override for audio/webm.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-11  Martin Robinson  <mrobinson@igalia.com>
+
+        [GStreamer] html5test.com says that gstreamer ports do not support WebM for audio
+        https://bugs.webkit.org/show_bug.cgi?id=78244
+
+        Reviewed by Eric Seidel.
+
+        Specifically advertise support for audio/webm when we support the vorbis
+        audio codec. This is necessary because gstreamer doesn't advertise it.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::mimeTypeCache): Add an override for audio/webm.
+
 2012-02-11  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -1495 +1495 @@
                 bool cached = false;
 
-                // These formats are supported by GStreamer, but not
-                // correctly advertised.
+                // There isn't a one-to-one correspondance of caps to supported mime types in
+                // GStreamer, so we need to manually map between them. At some point in the future,
+                // GStreamer may reduce the differences between caps and mime types and we can
+                // remove mappings.
                 if (g_str_equal(name, "video/x-h264")) {
                     cache.add(String("video/mp4"));
@@ -1524 +1526 @@
                     cache.add(String("audio/ogg"));
                     cache.add(String("audio/x-vorbis+ogg"));
+                    cache.add(String("audio/webm"));
                     cached = true;
                 }