Changeset 107527 in webkit


Ignore:
Timestamp:
Feb 12, 2012 9:00:25 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

KeywordLookupGenerator.py script fails in some cases
​https://bugs.webkit.org/show_bug.cgi?id=77886

Patch by Ashod Nakashian <​ashodnakashian@yahoo.com> on 2012-02-12
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

  • parser/Keywords.table: Converted to LF-only.

Tools:

  • Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
  • Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.

(GlobalVariablesTest.test_path_rules_specifier):

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r107525 r107527  
     12012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
     2
     3        KeywordLookupGenerator.py script fails in some cases
     4        https://bugs.webkit.org/show_bug.cgi?id=77886
     5
     6        Reviewed by Benjamin Poulain.
     7
     8        * parser/Keywords.table: Converted to LF-only.
     9
    1102012-02-12  Shinya Kawanaka  <shinyak@google.com>
    211

  • trunk/Source/JavaScriptCore/parser/Keywords.table

    r106198 r107527  
    1 # main keywords
     1# Main keywords.
    22@begin mainTable 47
    33
    4 # types
     4# Types.
    55null            NULLTOKEN
    66true            TRUETOKEN
    77false           FALSETOKEN
    88
    9 # keywords
     9# Keywords.
    1010break           BREAK
    1111case            CASE
    … …  
    3636debugger        DEBUGGER
    3737
    38 # reserved for future use
     38# Reserved for future use.
    3939class           RESERVED
    4040enum            RESERVED
    … …  
    4747let             RESERVED
    4848
    49 # reserved for future use in strict code
     49# Reserved for future use in strict code.
    5050implements      RESERVED_IF_STRICT
    5151interface       RESERVED_IF_STRICT
    … …  
    5858
    5959@end
    60 

  • trunk/Tools/ChangeLog

    r107522 r107527  
     12012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
     2
     3        KeywordLookupGenerator.py script fails in some cases
     4        https://bugs.webkit.org/show_bug.cgi?id=77886
     5
     6        Reviewed by Benjamin Poulain.
     7
     8        * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
     9        * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
     10        (GlobalVariablesTest.test_path_rules_specifier):
     11
    1122012-02-12  Joe Thomas  <joethomas@motorola.com>
    213

  • trunk/Tools/Scripts/webkitpy/style/checker.py

    r106814 r107527  
    238238      "Source/JavaScriptCore/jit/GDBInterface.cpp"],
    239239     ["-readability/naming"]),
     240
     241    ([# On some systems the trailing CR is causing parser failure.
     242      "Source/JavaScriptCore/parser/Keywords.table"],
     243     ["+whitespace/carriage_return"]),
    240244]
    241245
    … …  
    272276    'rb',
    273277    'sh',
     278    'table',
    274279    'txt',
    275280    'wm',

  • trunk/Tools/Scripts/webkitpy/style/checker_unittest.py

    r106838 r107527  
    269269                      "readability/naming")
    270270
     271        # Javascript keywords.
     272        assertCheck("Source/JavaScriptCore/parser/Keywords.table", "whitespace/carriage_return")
     273
    271274    def test_max_reports_per_category(self):
    272275        """Check that _MAX_REPORTS_PER_CATEGORY is valid."""
Note: See TracChangeset for help on using the changeset viewer.