Changeset 107567 in webkit


Ignore:
Timestamp:
Feb 13, 2012 6:27:51 AM (12 years ago)
Author:
vsevik@chromium.org
Message:

Web Inspector: In Inspector.json PropertyDescriptor.writable should be declared optional
​https://bugs.webkit.org/show_bug.cgi?id=77917

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-02-13
Reviewed by Pavel Feldman.

Source/WebCore:

Property descriptor is fixed in Inspector.json. Also retroactively in
0.1 and 1.0.
Injected script in instructed to never return null property values.

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector-0.1.json:
  • inspector/Inspector-1.0.json:
  • inspector/Inspector.json:

LayoutTests:

"Undefined" getter and setter is now visible.

  • inspector/runtime/runtime-getProperties-expected.txt:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r107564 r107567  
     12012-02-13  Peter Rybin  <peter.rybin@gmail.com>
     2
     3        Web Inspector: In Inspector.json PropertyDescriptor.writable should be declared optional
     4        https://bugs.webkit.org/show_bug.cgi?id=77917
     5
     6        Reviewed by Pavel Feldman.
     7
     8        "Undefined" getter and setter is now visible.
     9
     10        * inspector/runtime/runtime-getProperties-expected.txt:
     11
    1122012-02-13  Csaba Osztrogonác  <ossy@webkit.org>
    213

  • trunk/LayoutTests/inspector/runtime/runtime-getProperties-expected.txt

    r92765 r107567  
    3737    writable : false
    3838}
     39{
     40    name : "set foo"
     41    value : {
     42        type : "undefined"
     43        description : "undefined"
     44        objectId : <undefined>
     45    }
     46    enumerable : true
     47    writable : false
     48}
    3949

  • trunk/Source/WebCore/ChangeLog

    r107565 r107567  
     12012-02-13  Peter Rybin  <peter.rybin@gmail.com>
     2
     3        Web Inspector: In Inspector.json PropertyDescriptor.writable should be declared optional
     4        https://bugs.webkit.org/show_bug.cgi?id=77917
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Property descriptor is fixed in Inspector.json. Also retroactively in
     9        0.1 and 1.0.
     10        Injected script in instructed to never return null property values.
     11
     12        * inspector/InjectedScriptSource.js:
     13        (.):
     14        * inspector/Inspector-0.1.json:
     15        * inspector/Inspector-1.0.json:
     16        * inspector/Inspector.json:
     17
    1182012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
    219

  • trunk/Source/WebCore/inspector/InjectedScriptSource.js

    r106657 r107567  
    185185        for (var i = 0; i < descriptors.length; ++i) {
    186186            var descriptor = descriptors[i];
    187             if (descriptor.get)
     187            if ("get" in descriptor)
    188188                descriptor.get = this._wrapObject(descriptor.get, objectGroupName);
    189             if (descriptor.set)
     189            if ("set" in descriptor)
    190190                descriptor.set = this._wrapObject(descriptor.set, objectGroupName);
    191191            if ("value" in descriptor)
    192192                descriptor.value = this._wrapObject(descriptor.value, objectGroupName);
     193            if (!("configurable" in descriptor))
     194                descriptor.configurable = false;
     195            if (!("enumerable" in descriptor))
     196                descriptor.enumerable = false;
     197           
    193198        }
    194199        return descriptors;

  • trunk/Source/WebCore/inspector/Inspector-0.1.json

    r106787 r107567  
    266266                    { "name": "name", "type": "string", "description": "Property name." },
    267267                    { "name": "value", "$ref": "RemoteObject", "optional": true, "description": "The value associated with the property." },
    268                     { "name": "writable", "type": "boolean", "description": "True if the value associated with the property may be changed (data descriptors only)." },
     268                    { "name": "writable", "type": "boolean", "optional": true, "description": "True if the value associated with the property may be changed (data descriptors only)." },
    269269                    { "name": "get", "$ref": "RemoteObject", "optional": true, "description": "A function which serves as a getter for the property, or <code>undefined</code> if there is no getter (accessor descriptors only)." },
    270270                    { "name": "set", "$ref": "RemoteObject", "optional": true, "description": "A function which serves as a setter for the property, or <code>undefined</code> if there is no setter (accessor descriptors only)." },

  • trunk/Source/WebCore/inspector/Inspector-1.0.json

    r106787 r107567  
    377377                    { "name": "name", "type": "string", "description": "Property name." },
    378378                    { "name": "value", "$ref": "RemoteObject", "optional": true, "description": "The value associated with the property." },
    379                     { "name": "writable", "type": "boolean", "description": "True if the value associated with the property may be changed (data descriptors only)." },
     379                    { "name": "writable", "type": "boolean", "optional": true, "description": "True if the value associated with the property may be changed (data descriptors only)." },
    380380                    { "name": "get", "$ref": "RemoteObject", "optional": true, "description": "A function which serves as a getter for the property, or <code>undefined</code> if there is no getter (accessor descriptors only)." },
    381381                    { "name": "set", "$ref": "RemoteObject", "optional": true, "description": "A function which serves as a setter for the property, or <code>undefined</code> if there is no setter (accessor descriptors only)." },

  • trunk/Source/WebCore/inspector/Inspector.json

    r107220 r107567  
    378378                    { "name": "name", "type": "string", "description": "Property name." },
    379379                    { "name": "value", "$ref": "RemoteObject", "optional": true, "description": "The value associated with the property." },
    380                     { "name": "writable", "type": "boolean", "description": "True if the value associated with the property may be changed (data descriptors only)." },
     380                    { "name": "writable", "type": "boolean", "optional": true, "description": "True if the value associated with the property may be changed (data descriptors only)." },
    381381                    { "name": "get", "$ref": "RemoteObject", "optional": true, "description": "A function which serves as a getter for the property, or <code>undefined</code> if there is no getter (accessor descriptors only)." },
    382382                    { "name": "set", "$ref": "RemoteObject", "optional": true, "description": "A function which serves as a setter for the property, or <code>undefined</code> if there is no setter (accessor descriptors only)." },
Note: See TracChangeset for help on using the changeset viewer.