Changeset 107605 in webkit

Timestamp:

Feb 13, 2012 2:02:26 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[CSS Regions] Inconsistent text selection behavior in regions
​https://bugs.webkit.org/show_bug.cgi?id=76456

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.

Source/WebCore:

Use the proper bounding rect when doing hit testing on flow threads.
Based on initial patch by Alexandru Chiculita.

Test: fast/regions/hit-test-region.html

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestRegion):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

• rendering/RenderRegion.cpp:

(WebCore::RenderRegion::nodeAtPoint):

LayoutTests:

• fast/regions/hit-test-region-expected.txt: Added.
• fast/regions/hit-test-region.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/regions/hit-test-region-expected.txt (added)
• LayoutTests/fast/regions/hit-test-region.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderFlowThread.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.cpp (modified) (2 diffs)
• Source/WebCore/rendering/RenderRegion.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-13  Raul Hudea  <rhudea@adobe.com>
+
+        [CSS Regions] Inconsistent text selection behavior in regions
+        https://bugs.webkit.org/show_bug.cgi?id=76456
+
+        Reviewed by David Hyatt.
+
+        * fast/regions/hit-test-region-expected.txt: Added.
+        * fast/regions/hit-test-region.html: Added.
+
 2012-02-12  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-13  Raul Hudea  <rhudea@adobe.com>
+
+        [CSS Regions] Inconsistent text selection behavior in regions
+        https://bugs.webkit.org/show_bug.cgi?id=76456
+
+        Reviewed by David Hyatt.
+
+        Use the proper bounding rect when doing hit testing on flow threads.
+        Based on initial patch by Alexandru Chiculita.
+
+        Test: fast/regions/hit-test-region.html
+
+        * rendering/RenderFlowThread.cpp:
+        (WebCore::RenderFlowThread::hitTestRegion):
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::hitTest):
+        * rendering/RenderRegion.cpp:
+        (WebCore::RenderRegion::nodeAtPoint):
+
 2012-02-12  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/rendering/RenderFlowThread.cpp

@@ -492 +492 @@
     
     // Always ignore clipping, since the RenderFlowThread has nothing to do with the bounds of the FrameView.
-    HitTestRequest newRequest(request.type() & HitTestRequest::IgnoreClipping);
+    HitTestRequest newRequest(request.type() | HitTestRequest::IgnoreClipping);
 
     RenderRegion* oldRegion = result.region();

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -78 +78 @@
 #include "PlatformMouseEvent.h"
 #include "RenderArena.h"
+#include "RenderFlowThread.h"
 #include "RenderInline.h"
 #include "RenderMarquee.h"
@@ -3111 +3112 @@
     renderer()->document()->updateLayout();
     
-    LayoutRect hitTestArea = renderer()->view()->documentRect();
+    LayoutRect hitTestArea = renderer()->isRenderFlowThread() ? toRenderFlowThread(renderer())->borderBoxRect() : renderer()->view()->documentRect();
     if (!request.ignoreClipping())
         hitTestArea.intersect(frameVisibleRect(renderer()));

trunk/Source/WebCore/rendering/RenderRegion.cpp

@@ -158 +158 @@
     // Check our bounds next. For this purpose always assume that we can only be hit in the
     // foreground phase (which is true for replaced elements like images).
-    LayoutRect boundsRect(adjustedLocation, size());
+    LayoutRect boundsRect = borderBoxRectInRegion(result.region());
+    boundsRect.moveBy(adjustedLocation);
     if (visibleToHitTesting() && action == HitTestForeground && boundsRect.intersects(result.rectForPoint(pointInContainer))) {
         // Check the contents of the RenderFlowThread.