Changeset 107662 in webkit

Timestamp:

Feb 13, 2012 8:03:49 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Mutation Observers build is broken
​https://bugs.webkit.org/show_bug.cgi?id=78433

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-13
Reviewed by Martin Robinson.

Source/WebCore:

Added some files missed.

No new tests since no new feature.

• GNUmakefile.list.am:

Tools:

Enabled mutation observers as a default feature for GTK port, too.

• Scripts/build-webkit:

LayoutTests:

Removed fast/mutation, but added following 3 tests which are needed more time to pass.

GTK port DRT doesn't support some APIs like scheduleAsynchronousKeyDown.
I opened a new bug to deal with it. ​http://webkit.org/b/78481
And also see ​http://webkit.org/b/78290
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html

Needed to enable FileSystem API at the same time.
fast/mutation/filesystem-callback-delivery.html

• platform/gtk/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/GNUmakefile.list.am (modified) (4 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/build-webkit (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
+
+        [GTK] Mutation Observers build is broken
+        https://bugs.webkit.org/show_bug.cgi?id=78433
+
+        Reviewed by Martin Robinson.
+
+        Removed fast/mutation, but added following 3 tests which are needed more time to pass.
+
+        GTK port DRT doesn't support some APIs like scheduleAsynchronousKeyDown.
+        I opened a new bug to deal with it. http://webkit.org/b/78481
+        And also see http://webkit.org/b/78290
+        fast/mutation/end-of-task-delivery.html
+        fast/mutation/inline-event-listener.html
+
+        Needed to enable FileSystem API at the same time.
+        fast/mutation/filesystem-callback-delivery.html
+
+        * platform/gtk/Skipped:
+
 2012-02-13  Hayato Ito  <hayato@chromium.org>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -281 +281 @@
 http/tests/websocket/tests/hybi/send-file-blob-fail.html
 http/tests/workers/terminate-during-sync-operation.html
+fast/mutation/filesystem-callback-delivery.html
 
 # Requires WebP support.
@@ -1608 +1609 @@
 security/block-test.html
 
-# MutationObservers are not enabled. http://webkit.org/b/78433
-fast/mutation
-
 # https://bugs.webkit.org/show_bug.cgi?id=78434
 fast/dom/Window/window-custom-prototype.html
 http/tests/security/cross-frame-access-object-getPrototypeOf.html
+
+# GTK port DRT doesn't support some API like scheduleAsynchronousKeyDown.
+# http://webkit.org/b/78481, http://webkit.org/b/78290
+fast/mutation/end-of-task-delivery.html
+fast/mutation/inline-event-listener.html

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
+
+        [GTK] Mutation Observers build is broken
+        https://bugs.webkit.org/show_bug.cgi?id=78433
+
+        Reviewed by Martin Robinson.
+
+        Added some files missed.
+
+        No new tests since no new feature.
+
+        * GNUmakefile.list.am:
+
 2012-02-13  Hayato Ito  <hayato@chromium.org>
 

trunk/Source/WebCore/GNUmakefile.list.am

@@ -389 +389 @@
         DerivedSources/WebCore/JSMouseEvent.cpp \
         DerivedSources/WebCore/JSMouseEvent.h \
+        DerivedSources/WebCore/JSMutationCallback.cpp \
+        DerivedSources/WebCore/JSMutationCallback.h \
         DerivedSources/WebCore/JSMutationEvent.cpp \
         DerivedSources/WebCore/JSMutationEvent.h \
@@ -588 +590 @@
         DerivedSources/WebCore/JSWebKitCSSTransformValue.cpp \
         DerivedSources/WebCore/JSWebKitCSSTransformValue.h \
+        DerivedSources/WebCore/JSWebKitMutationObserver.cpp \
+        DerivedSources/WebCore/JSWebKitMutationObserver.h \
         DerivedSources/WebCore/JSWebKitNamedFlow.cpp \
         DerivedSources/WebCore/JSWebKitNamedFlow.h \
@@ -706 +710 @@
         $(WebCore)/dom/MessagePort.idl \
         $(WebCore)/dom/MouseEvent.idl \
+        $(WebCore)/dom/MutationCallback.idl \
         $(WebCore)/dom/MutationEvent.idl \
         $(WebCore)/dom/MutationRecord.idl \
@@ -730 +735 @@
         $(WebCore)/dom/UIEvent.idl \
         $(WebCore)/dom/WebKitAnimationEvent.idl \
+        $(WebCore)/dom/WebKitMutationObserver.idl \
         $(WebCore)/dom/WebKitNamedFlow.idl \
         $(WebCore)/dom/WebKitTransitionEvent.idl \

trunk/Tools/ChangeLog

@@ +1 @@
+2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
+
+        [GTK] Mutation Observers build is broken
+        https://bugs.webkit.org/show_bug.cgi?id=78433
+
+        Reviewed by Martin Robinson.
+
+        Enabled mutation observers as a default feature for GTK port, too.
+
+        * Scripts/build-webkit:
+
 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
 

trunk/Tools/Scripts/build-webkit

@@ -277 +277 @@
 
     { option => "mutation-observers", desc => "Toggle DOM mutation observer support",
-      define => "ENABLE_MUTATION_OBSERVERS", default => !isGtk(), value => \$mutationObserversSupport },
+      define => "ENABLE_MUTATION_OBSERVERS", default => 1, value => \$mutationObserversSupport },
 
     { option => "netscape-plugin", desc => "Netscape Plugin support",