Changeset 107940 in webkit


Ignore:
Timestamp:
Feb 16, 2012 8:37:54 AM (12 years ago)
Author:
pfeldman@chromium.org
Message:

Web Inspector: remove free flow DOM editing experiment.
https://bugs.webkit.org/show_bug.cgi?id=78813

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._markRevision):

Location:
trunk
Files:
1 deleted
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r107937 r107940  
     12012-02-16  Pavel Feldman  <pfeldman@google.com>
     2
     3        Web Inspector: remove free flow DOM editing experiment.
     4        https://bugs.webkit.org/show_bug.cgi?id=78813
     5
     6        Reviewed by Yury Semikhatsky.
     7
     8        * inspector/front-end/DOMAgent.js:
     9        (WebInspector.DOMAgent.prototype._markRevision):
     10
    1112012-02-16  Patrick Gansterer  <paroga@webkit.org>
    212
  • trunk/Source/WebCore/inspector/front-end/DOMAgent.js

    r107935 r107940  
    661661    this._attributeLoadNodeIds = {};
    662662    InspectorBackend.registerDOMDispatcher(new WebInspector.DOMDispatcher(this));
    663     if (WebInspector.experimentsSettings.freeFlowDOMEditing.isEnabled())
    664         new WebInspector.DOMModelResourceBinding(this);
    665 
    666663    if (WebInspector.settings.emulateTouchEvents.get())
    667664        this._emulateTouchEventsChanged();
     
    11231120            if (callback)
    11241121                callback.apply(this, arguments);
    1125             if (error || !WebInspector.experimentsSettings.freeFlowDOMEditing.isEnabled())
    1126                 return;
    1127             if (this._captureDOMTimer)
    1128                clearTimeout(this._captureDOMTimer);
    1129             this._captureDOMTimer = setTimeout(this._captureDOM.bind(this, node), 500);
    11301122        }
    11311123        return wrapperFunction.bind(this);
    1132     },
    1133 
    1134     /**
    1135      * @param {WebInspector.DOMNode} node
    1136      */
    1137     _captureDOM: function(node)
    1138     {
    1139         delete this._captureDOMTimer;
    1140         if (!node.ownerDocument)
    1141             return;
    1142 
    1143         function callback(error, text)
    1144         {
    1145             if (error) {
    1146                 console.error(error);
    1147                 return;
    1148             }
    1149 
    1150             var url = node.ownerDocument.documentURL;
    1151             if (!url)
    1152                 return;
    1153 
    1154             var resource = WebInspector.resourceForURL(url);
    1155             if (!resource)
    1156                 return;
    1157 
    1158             resource.addRevision(text);
    1159         }
    1160         DOMAgent.getOuterHTML(node.ownerDocument.id, callback);
    1161        
    11621124    },
    11631125
     
    12991261 */
    13001262WebInspector.domAgent = null;
    1301 
    1302 /**
    1303  * @constructor
    1304  * @implements {WebInspector.ResourceDomainModelBinding}
    1305  */
    1306 WebInspector.DOMModelResourceBinding = function(domAgent)
    1307 {
    1308     this._domAgent = domAgent;
    1309     WebInspector.Resource.registerDomainModelBinding(WebInspector.Resource.Type.Document, this);
    1310 }
    1311 
    1312 WebInspector.DOMModelResourceBinding.prototype = {
    1313     setContent: function(resource, content, majorChange, userCallback)
    1314     {
    1315         var frameId = resource.frameId;
    1316         if (!frameId)
    1317             return;
    1318 
    1319         PageAgent.setDocumentContent(frameId, content, callbackWrapper);
    1320 
    1321         function callbackWrapper(error)
    1322         {
    1323             if (majorChange)
    1324                 resource.addRevision(content);
    1325             if (userCallback)
    1326                 userCallback(error);
    1327         }
    1328     },
    1329 
    1330     canSetContent: function()
    1331     {
    1332         return true;
    1333     }
    1334 }
    1335 
    1336 WebInspector.DOMModelResourceBinding.prototype.__proto__ = WebInspector.ResourceDomainModelBinding.prototype;
  • trunk/Source/WebCore/inspector/front-end/Settings.js

    r107925 r107940  
    171171    // Add currently running experiments here.
    172172    this.sourceFrameAlwaysEditable = this._createExperiment("sourceFrameAlwaysEditable", "Make resources always editable");
    173     this.freeFlowDOMEditing = this._createExperiment("freeFlowDOMEditing", "Enable free flow DOM editing");
    174173    this.showMemoryCounters = this._createExperiment("showMemoryCounters", "Show memory counters in Timeline panel");
    175174    this.singleClickEditing = this._createExperiment("singleClickEditing", "Single click CSS editing");
Note: See TracChangeset for help on using the changeset viewer.