Changeset 107959 in webkit

Timestamp:

Feb 16, 2012 11:15:40 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[CSS Regions] Repaint issues when changing innerHTML of content
​https://bugs.webkit.org/show_bug.cgi?id=78787

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-02-16
Reviewed by David Hyatt.

Source/WebCore:

The calculation of the clipping rectangle is based on the repaint rectangle,
so it needs to be clipped to the current region, because it might spread over multiple ones.

Test: fast/repaint/region-painting-invalidation.html

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::repaintRectangleInRegions):

LayoutTests:

• fast/repaint/region-painting-invalidation.html: Added.
• platform/chromium/test_expectations.txt: Needs baseline
• platform/mac/fast/repaint/region-painting-invalidation-expected.png: Added.
• platform/mac/fast/repaint/region-painting-invalidation-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/region-painting-invalidation.html (added)
• LayoutTests/platform/chromium/test_expectations.txt (modified) (1 diff)
• LayoutTests/platform/mac/fast/repaint/region-painting-invalidation-expected.png (added)
• LayoutTests/platform/mac/fast/repaint/region-painting-invalidation-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderFlowThread.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-16  Raul Hudea  <rhudea@adobe.com>
+
+        [CSS Regions] Repaint issues when changing innerHTML of content
+        https://bugs.webkit.org/show_bug.cgi?id=78787
+
+        Reviewed by David Hyatt.
+
+        * fast/repaint/region-painting-invalidation.html: Added.
+        * platform/chromium/test_expectations.txt: Needs baseline
+        * platform/mac/fast/repaint/region-painting-invalidation-expected.png: Added.
+        * platform/mac/fast/repaint/region-painting-invalidation-expected.txt: Added.
+
 2012-02-16  James Robinson <jamesr@chromium.org>
 

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -3049 +3049 @@
 BUGWK78761 DEBUG : fast/regions/element-region-overflow-state.html = PASS TEXT
 BUGWK78761 DEBUG : fast/regions/element-region-overflow-state-vertical-rl.html = PASS TEXT
+
+// New test added from https://bugs.webkit.org/show_bug.cgi?id=78787, needs baselines.
+BUGWK78787 : fast/repaint/region-painting-invalidation.html = IMAGE+TEXT
 
 // CSS custom() filters are not currently supported

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-16  Raul Hudea  <rhudea@adobe.com>
+
+        [CSS Regions] Repaint issues when changing innerHTML of content
+        https://bugs.webkit.org/show_bug.cgi?id=78787
+
+        Reviewed by David Hyatt.
+
+        The calculation of the clipping rectangle is based on the repaint rectangle,
+        so it needs to be clipped to the current region, because it might spread over multiple ones.
+
+        Test: fast/repaint/region-painting-invalidation.html
+
+        * rendering/RenderFlowThread.cpp:
+        (WebCore::RenderFlowThread::repaintRectangleInRegions):
+
 2012-02-16  Adam Roben  <aroben@apple.com>
 

trunk/Source/WebCore/rendering/RenderFlowThread.cpp

@@ -541 +541 @@
         flipForWritingMode(flippedRegionOverflowRect);
 
-        LayoutRect clippedRect(flippedRegionOverflowRect);
-        clippedRect.intersect(repaintRect);
+        LayoutRect clippedRect(repaintRect);
+        clippedRect.intersect(flippedRegionOverflowRect);
         if (clippedRect.isEmpty())
             continue;
-        
+
         // Put the region rect into the region's physical coordinate space.
-        clippedRect.setLocation(region->contentBoxRect().location() + (repaintRect.location() - flippedRegionRect.location()));
-        
+        clippedRect.setLocation(region->contentBoxRect().location() + (clippedRect.location() - flippedRegionRect.location()));
+
         // Now switch to the region's writing mode coordinate space and let it repaint itself.
         region->flipForWritingMode(clippedRect);