Changeset 107961 in webkit


Ignore:
Timestamp:
Feb 16, 2012 11:39:53 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[CSSRegions]overflowRegion tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=78761

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-02-16
Reviewed by Tony Chang.

Source/WebCore:

The overflowRegion tests were updated.

  • dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):

LayoutTests:

  • fast/regions/element-region-overflow-state-expected.txt:
  • fast/regions/element-region-overflow-state-vertical-rl-expected.txt:
  • fast/regions/element-region-overflow-state-vertical-rl.html:
  • fast/regions/element-region-overflow-state.html:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r107959 r107961  
     12012-02-16  Raul Hudea  <rhudea@adobe.com>
     2
     3        [CSSRegions]overflowRegion tests are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=78761
     5
     6        Reviewed by Tony Chang.
     7
     8        * fast/regions/element-region-overflow-state-expected.txt:
     9        * fast/regions/element-region-overflow-state-vertical-rl-expected.txt:
     10        * fast/regions/element-region-overflow-state-vertical-rl.html:
     11        * fast/regions/element-region-overflow-state.html:
     12
    1132012-02-16  Raul Hudea  <rhudea@adobe.com>
    214

  • trunk/LayoutTests/fast/regions/element-region-overflow-state-expected.txt

    r107827 r107961  
    55 
    66PASS regionOverflow('article') is "undefined"
    7 PASS regionOverflow('region_1') is "undefined"
    8 PASS regionOverflow('region_2') is "undefined"
    9 PASS regionOverflow('region_3') is "undefined"
    10 After first layout
    117PASS regionOverflow('region_1') is "empty"
    128PASS regionOverflow('region_2') is "empty"

  • trunk/LayoutTests/fast/regions/element-region-overflow-state-vertical-rl-expected.txt

    r107827 r107961  
    55 
    66PASS regionOverflow('article') is "undefined"
    7 PASS regionOverflow('region_1') is "undefined"
    8 PASS regionOverflow('region_2') is "undefined"
    9 PASS regionOverflow('region_3') is "undefined"
    107PASS regionOverflow('region_1') is "empty"
    118PASS regionOverflow('region_2') is "empty"

  • trunk/LayoutTests/fast/regions/element-region-overflow-state-vertical-rl.html

    r107827 r107961  
    6868        c.style.width = 596;
    6969    }
    70     function emptyContent() {
    71 
    72     }
    7370    function test() {
    7471        shouldBeEqualToString("regionOverflow('article')", "undefined");
    75         shouldBeEqualToString("regionOverflow('region_1')", "undefined");
    76         shouldBeEqualToString("regionOverflow('region_2')", "undefined");
    77         shouldBeEqualToString("regionOverflow('region_3')", "undefined");
    78 
    79         document.body.offsetTop; // force layout
    8072
    8173        shouldBeEqualToString("regionOverflow('region_1')", "empty");
    … …  
    8577        debug("Flow content");
    8678        flowContent("article");
    87         document.body.offsetTop; // force layout
    8879
    8980        shouldBeEqualToString("regionOverflow('region_1')", "overflow");
    … …  
    9384        debug("Add more content");
    9485        addMoreContent();
    95         document.body.offsetTop; // force layout
    9686
    9787        shouldBeEqualToString("regionOverflow('region_1')", "overflow");
    … …  
    10191        debug("Add visual overflow");
    10292        addVisualOverflow();
    103         document.body.offsetTop; // force layout
    10493
    10594        shouldBeEqualToString("regionOverflow('region_1')", "overflow");
    … …  
    10998        debug("Empty content");
    11099        flowContent("no_article");
    111         document.body.offsetTop; // force layout
    112100
    113101        shouldBeEqualToString("regionOverflow('region_1')", "empty");

  • trunk/LayoutTests/fast/regions/element-region-overflow-state.html

    r107827 r107961  
    6363    function test() {
    6464        shouldBeEqualToString("regionOverflow('article')", "undefined");
    65         shouldBeEqualToString("regionOverflow('region_1')", "undefined");
    66         shouldBeEqualToString("regionOverflow('region_2')", "undefined");
    67         shouldBeEqualToString("regionOverflow('region_3')", "undefined");
    68 
    69         document.body.offsetTop; // force layout
    70         debug("After first layout");
    7165
    7266        shouldBeEqualToString("regionOverflow('region_1')", "empty");
    … …  
    7670        debug("Flow content");
    7771        flowContent("article");
    78         document.body.offsetTop; // force layout
    7972
    8073        shouldBeEqualToString("regionOverflow('region_1')", "overflow");
    … …  
    8477        debug("Add more content");
    8578        addMoreContent();
    86         document.body.offsetTop; // force layout
    8779
    8880        shouldBeEqualToString("regionOverflow('region_1')", "overflow");
    … …  
    9284        debug("Add visual overflow");
    9385        addVisualOverflow();
    94         document.body.offsetTop; // force layout
    9586
    9687        shouldBeEqualToString("regionOverflow('region_1')", "overflow");
    … …  
    10091        debug("Empty content");
    10192        flowContent("no_article");
    102         document.body.offsetTop; // force layout
    10393
    10494        shouldBeEqualToString("regionOverflow('region_1')", "empty");

  • trunk/Source/WebCore/ChangeLog

    r107959 r107961  
     12012-02-16  Raul Hudea  <rhudea@adobe.com>
     2
     3        [CSSRegions]overflowRegion tests are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=78761
     5
     6        Reviewed by Tony Chang.
     7
     8        The overflowRegion tests were updated.
     9
     10        * dom/Element.cpp:
     11        (WebCore::Element::webkitRegionOverflow):
     12
    1132012-02-16  Raul Hudea  <rhudea@adobe.com>
    214

  • trunk/Source/WebCore/dom/Element.cpp

    r107793 r107961  
    19651965const AtomicString& Element::webkitRegionOverflow() const
    19661966{
     1967    document()->updateLayoutIgnorePendingStylesheets();
     1968
    19671969    if (renderer() && renderer()->isRenderRegion()) {
    19681970        RenderRegion* region = toRenderRegion(renderer());
Note: See TracChangeset for help on using the changeset viewer.