Changeset 108415 in webkit

Timestamp:

Feb 21, 2012 4:34:19 PM (12 years ago)

Author:

adamk@chromium.org

Message:

ContainerNode::childrenChanged must be called immediately after removing children
​https://bugs.webkit.org/show_bug.cgi?id=79162

Reviewed by Ryosuke Niwa.

Source/WebCore:

In r108152, a call to childrenChanged() was erroneously moved
below the call to child->removedFromDocument(). This breaks, at the
least, the behavior of the <title> element. This patch corrects the
mistake and adds a test.

Test: fast/dom/title-directionality-removeChild.html

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):

LayoutTests:

• fast/dom/title-directionality-removeChild-expected.txt: Added.
• fast/dom/title-directionality-removeChild.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/title-directionality-removeChild-expected.txt (added)
• LayoutTests/fast/dom/title-directionality-removeChild.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/ContainerNode.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-21  Adam Klein  <adamk@chromium.org>
+
+        ContainerNode::childrenChanged must be called immediately after removing children
+        https://bugs.webkit.org/show_bug.cgi?id=79162
+
+        Reviewed by Ryosuke Niwa.
+
+        * fast/dom/title-directionality-removeChild-expected.txt: Added.
+        * fast/dom/title-directionality-removeChild.html: Added.
+
 2012-02-21  Tom Sepez  <tsepez@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-21  Adam Klein  <adamk@chromium.org>
+
+        ContainerNode::childrenChanged must be called immediately after removing children
+        https://bugs.webkit.org/show_bug.cgi?id=79162
+
+        Reviewed by Ryosuke Niwa.
+
+        In r108152, a call to childrenChanged() was erroneously moved
+        below the call to child->removedFromDocument(). This breaks, at the
+        least, the behavior of the <title> element. This patch corrects the
+        mistake and adds a test.
+
+        Test: fast/dom/title-directionality-removeChild.html
+
+        * dom/ContainerNode.cpp:
+        (WebCore::ContainerNode::removeChild):
+
 2012-02-21  Luke Macpherson   <macpherson@chromium.org>
 

trunk/Source/WebCore/dom/ContainerNode.cpp

@@ -479 +479 @@
     removeBetween(prev, next, child.get());
 
+    childrenChanged(false, prev, next, -1);
+
     if (child->inDocument())
         child->removedFromDocument();
@@ -484 +486 @@
         child->removedFromTree(true);
 
-    // Dispatch post-removal mutation events
-    childrenChanged(false, prev, next, -1);
     dispatchSubtreeModifiedEvent();