Changeset 108610 in webkit

Timestamp:

Feb 22, 2012 10:26:07 PM (12 years ago)

Author:

haraken@chromium.org

Message:

Enable Geolocation bindings for GObject
​https://bugs.webkit.org/show_bug.cgi?id=79293

Reviewed by Adam Barth.

This patch adds "WebCore::" to supplemental method calls.
This will solve the GTK build failure we have observed in the Geolocation API,
and thus this patch enables the Geolocation API.

• Modules/geolocation/NavigatorGeolocation.idl:
• bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateFunction):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/geolocation/NavigatorGeolocation.idl (modified) (1 diff)
• bindings/scripts/CodeGeneratorGObject.pm (modified) (6 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-22  Kentaro Hara  <haraken@chromium.org>
+
+        Enable Geolocation bindings for GObject
+        https://bugs.webkit.org/show_bug.cgi?id=79293
+
+        Reviewed by Adam Barth.
+
+        This patch adds "WebCore::" to supplemental method calls.
+        This will solve the GTK build failure we have observed in the Geolocation API,
+        and thus this patch enables the Geolocation API.
+
+        * Modules/geolocation/NavigatorGeolocation.idl:
+        * bindings/scripts/CodeGeneratorGObject.pm:
+        (GenerateProperty):
+        (GenerateFunction):
+
 2012-02-22  MORITA Hajime  <morrita@google.com>
 

trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.idl

@@ -24 +24 @@
         Supplemental=Navigator
     ] NavigatorGeolocation {
-#if !defined(LANGUAGE_GOBJECT) || !LANGUAGE_GOBJECT
-        // FIXME: Enable this interface for GOBJECT.
         readonly attribute [V8EnabledAtRuntime] Geolocation geolocation;
-#endif
     };
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm

@@ -390 +390 @@
         unshift(@getterArguments, "coreSelf");
         unshift(@setterArguments, "coreSelf");
-        $getterFunctionName = "${implementedBy}::$getterFunctionName";
-        $setterFunctionName = "${implementedBy}::$setterFunctionName";
+        $getterFunctionName = "WebCore::${implementedBy}::$getterFunctionName";
+        $setterFunctionName = "WebCore::${implementedBy}::$setterFunctionName";
     } else {
         push(@setterArguments, "${convertFunction}(g_value_get_$gtype(value))");
@@ -927 +927 @@
                 $implIncludes{"${implementedBy}.h"} = 1;
                 unshift(@arguments, "item");
-                $functionName = "${implementedBy}::${functionName}";
+                $functionName = "WebCore::${implementedBy}::${functionName}";
             } else {
                 $functionName = "item->${functionName}";
@@ -938 +938 @@
                 $implIncludes{"${implementedBy}.h"} = 1;
                 unshift(@arguments, "item");
-                $getterContentHead = "${assign}convertToUTF8String(${implementedBy}::${functionSigName}(" . join(", ", @arguments) . "));\n";
+                $getterContentHead = "${assign}convertToUTF8String(WebCore::${implementedBy}::${functionSigName}(" . join(", ", @arguments) . "));\n";
             } else {
                 $getterContentHead = "${assign}convertToUTF8String(item->${functionSigName}(" . join(", ", @arguments) . "));\n";
@@ -953 +953 @@
                 $implIncludes{"${implementedBy}.h"} = 1;
                 unshift(@arguments, "item");
-                $functionName = "${implementedBy}::${functionName}";
+                $functionName = "WebCore::${implementedBy}::${functionName}";
             } else {
                 $functionName = "item->${functionName}";
@@ -965 +965 @@
                 $implIncludes{"${implementedBy}.h"} = 1;
                 unshift(@arguments, "item");
-                $functionName = "${implementedBy}::${functionName}";
+                $functionName = "WebCore::${implementedBy}::${functionName}";
                 $contentHead = "${assign}${assignPre}${functionName}(" . join(", ", @arguments) . "${assignPost});\n";
             } else {
@@ -977 +977 @@
                 $implIncludes{"${implementedBy}.h"} = 1;
                 unshift(@arguments, "item");
-                $contentHead = "${assign}${assignPre}${implementedBy}::${functionSigName}(" . join(", ", @arguments) . "${assignPost});\n";
+                $contentHead = "${assign}${assignPre}WebCore::${implementedBy}::${functionSigName}(" . join(", ", @arguments) . "${assignPost});\n";
             } else {
                 $contentHead = "${assign}${assignPre}item->${functionSigName}(" . join(", ", @arguments) . "${assignPost});\n";