Changeset 108690 in webkit


Ignore:
Timestamp:
Feb 23, 2012 3:55:51 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

CSS2:text-decoration: <rt> element should not inherit text-decoration property
https://bugs.webkit.org/show_bug.cgi?id=71266

Patch by Koji Ishii <Koji Ishii> on 2012-02-23
Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/ruby/text-decoration-in-descendants-ruby-expected.html

fast/ruby/text-decoration-in-descendants-ruby.html

The spec says "text decorations are not propagated to any out-of-flow descendants":
http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration
Floats etc. are fixed in bug 18611, but <rt> is not inline either and therefore
it should be included; it was confirmed at a discussion at www-style.
http://lists.w3.org/Archives/Public/www-style/2011Sep/0238.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

LayoutTests:

The spec says "text decorations are not propagated to any out-of-flow descendants":
http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration
Floats etc. are fixed in bug 18611, but <rt> is not inline either and therefore
it should be included; it was confirmed at a discussion at www-style.
http://lists.w3.org/Archives/Public/www-style/2011Sep/0238.html

  • fast/ruby/text-decoration-in-descendants-ruby-expected.html: Added.
  • fast/ruby/text-decoration-in-descendants-ruby.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r108687 r108690  
     12012-02-23  Koji Ishii  <kojiishi@gmail.com>
     2
     3        CSS2:text-decoration: <rt> element should not inherit text-decoration property
     4        https://bugs.webkit.org/show_bug.cgi?id=71266
     5
     6        Reviewed by Kentaro Hara.
     7
     8        The spec says "text decorations are not propagated to any out-of-flow descendants":
     9        http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration
     10        Floats etc. are fixed in bug 18611, but <rt> is not inline either and therefore
     11        it should be included; it was confirmed at a discussion at www-style.
     12        http://lists.w3.org/Archives/Public/www-style/2011Sep/0238.html
     13
     14        * fast/ruby/text-decoration-in-descendants-ruby-expected.html: Added.
     15        * fast/ruby/text-decoration-in-descendants-ruby.html: Added.
     16
    1172012-02-23  Filip Pizlo  <fpizlo@apple.com>
    218
  • trunk/Source/WebCore/ChangeLog

    r108685 r108690  
     12012-02-23  Koji Ishii  <kojiishi@gmail.com>
     2
     3        CSS2:text-decoration: <rt> element should not inherit text-decoration property
     4        https://bugs.webkit.org/show_bug.cgi?id=71266
     5
     6        Reviewed by Kentaro Hara.
     7
     8        Tests: fast/ruby/text-decoration-in-descendants-ruby-expected.html
     9               fast/ruby/text-decoration-in-descendants-ruby.html
     10
     11        The spec says "text decorations are not propagated to any out-of-flow descendants":
     12        http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration
     13        Floats etc. are fixed in bug 18611, but <rt> is not inline either and therefore
     14        it should be included; it was confirmed at a discussion at www-style.
     15        http://lists.w3.org/Archives/Public/www-style/2011Sep/0238.html
     16
     17        * rendering/RenderObject.cpp:
     18        (WebCore::RenderObject::getTextDecorationColors):
     19
    1202012-02-23  Zoltan Horvath  <zoltan@webkit.org>
    221
  • trunk/Source/WebCore/rendering/RenderObject.cpp

    r108494 r108690  
    25502550            }
    25512551        }
    2552         if (curr->isFloating() || curr->isPositioned())
     2552        if (curr->isFloating() || curr->isPositioned() || curr->isRubyText())
    25532553            return;
    25542554        curr = curr->parent();
Note: See TracChangeset for help on using the changeset viewer.