Changeset 108772 in webkit
- Timestamp:
- Feb 24, 2012 4:32:27 AM (12 years ago)
- Location:
- trunk/Source
- Files:
-
- 32 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r108770 r108772 1 2012-02-24 Shinya Kawanaka <shinyak@chromium.org> 2 3 SpellCheckRequest needs to know the context where the spellcheck happened. 4 https://bugs.webkit.org/show_bug.cgi?id=79320 5 6 Reviewed by Hajime Morita. 7 8 WebKit clients should be able to get the context how the spellcheck happended. 9 For example, WebKit clients may want to change the behavior by a spellcheck request is 10 invoked in typing or in pasting. 11 12 This patch added an enum in SpellCheckRequest so that WebKit clients can understand the context. 13 14 * editing/Editor.cpp: 15 (WebCore::Editor::replaceSelectionWithFragment): 16 (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): 17 * editing/SpellChecker.cpp: 18 (WebCore::SpellCheckRequest::SpellCheckRequest): 19 (WebCore::SpellCheckRequest::create): 20 (WebCore::SpellChecker::invokeRequest): 21 * editing/SpellChecker.h: 22 (SpellCheckRequest): 23 (WebCore::SpellCheckRequest::textCheckingRequest): 24 (WebCore::SpellCheckRequest::processType): 25 * loader/EmptyClients.h: 26 (WebCore::EmptyTextCheckerClient::requestCheckingOfString): 27 * platform/text/TextCheckerClient.h: 28 (WebCore): 29 (TextCheckerClient): 30 * platform/text/TextChecking.h: 31 (TextCheckingRequest): 32 (WebCore::TextCheckingRequest::TextCheckingRequest): 33 (WebCore::TextCheckingRequest::setSequence): 34 (WebCore::TextCheckingRequest::sequence): 35 (WebCore::TextCheckingRequest::text): 36 (WebCore::TextCheckingRequest::mask): 37 (WebCore::TextCheckingRequest::processType): 38 (WebCore): 39 1 40 2012-02-24 Hayato Ito <hayato@chromium.org> 2 41 -
trunk/Source/WebCore/editing/Editor.cpp
r108462 r108772 419 419 420 420 RefPtr<Range> rangeToCheck = Range::create(m_frame->document(), firstPositionInNode(nodeToCheck), lastPositionInNode(nodeToCheck)); 421 m_spellChecker->requestCheckingFor(SpellCheckRequest::create(resolveTextCheckingTypeMask(TextCheckingTypeSpelling | TextCheckingTypeGrammar), rangeToCheck, rangeToCheck));421 m_spellChecker->requestCheckingFor(SpellCheckRequest::create(resolveTextCheckingTypeMask(TextCheckingTypeSpelling | TextCheckingTypeGrammar), TextCheckingProcessBatch, rangeToCheck, rangeToCheck)); 422 422 } 423 423 … … 1936 1936 1937 1937 // In asynchronous mode, we intentionally check paragraph-wide sentence. 1938 RefPtr<SpellCheckRequest> request = SpellCheckRequest::create(resolveTextCheckingTypeMask(textCheckingOptions), asynchronous ? paragraphRange : rangeToCheck, paragraphRange);1938 RefPtr<SpellCheckRequest> request = SpellCheckRequest::create(resolveTextCheckingTypeMask(textCheckingOptions), TextCheckingProcessIncremental, asynchronous ? paragraphRange : rangeToCheck, paragraphRange); 1939 1939 1940 1940 if (asynchronous) { -
trunk/Source/WebCore/editing/SpellChecker.cpp
r102553 r108772 48 48 static const int unrequestedSequence = -1; 49 49 50 SpellCheckRequest::SpellCheckRequest(int sequence, PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange, const String& text, TextCheckingTypeMask mask )50 SpellCheckRequest::SpellCheckRequest(int sequence, PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange, const String& text, TextCheckingTypeMask mask, TextCheckingProcessType processType) 51 51 : m_sequence(sequence) 52 , m_text(text) 53 , m_mask(mask) 54 , m_processType(processType) 52 55 , m_checkingRange(checkingRange) 53 56 , m_paragraphRange(paragraphRange) 54 , m_text(text)55 , m_mask(mask)56 57 , m_rootEditableElement(m_checkingRange->startContainer()->rootEditableElement()) 57 58 { … … 63 64 64 65 // static 65 PassRefPtr<SpellCheckRequest> SpellCheckRequest::create(TextCheckingTypeMask textCheckingOptions, PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange)66 PassRefPtr<SpellCheckRequest> SpellCheckRequest::create(TextCheckingTypeMask textCheckingOptions, TextCheckingProcessType processType, PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange) 66 67 { 67 68 ASSERT(checkingRange); … … 72 73 return PassRefPtr<SpellCheckRequest>(); 73 74 74 return adoptRef(new SpellCheckRequest(unrequestedSequence, checkingRange, paragraphRange, text, textCheckingOptions ));75 return adoptRef(new SpellCheckRequest(unrequestedSequence, checkingRange, paragraphRange, text, textCheckingOptions, processType)); 75 76 } 76 77 … … 146 147 147 148 m_processingRequest = request; 148 client()->requestCheckingOfString(this, m_processingRequest-> sequence(), m_processingRequest->mask(), m_processingRequest->text());149 client()->requestCheckingOfString(this, m_processingRequest->textCheckingRequest()); 149 150 } 150 151 -
trunk/Source/WebCore/editing/SpellChecker.h
r102328 r108772 47 47 class SpellCheckRequest : public RefCounted<SpellCheckRequest> { 48 48 public: 49 SpellCheckRequest(int sequence, PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange, const String&, TextCheckingTypeMask );49 SpellCheckRequest(int sequence, PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange, const String&, TextCheckingTypeMask, TextCheckingProcessType); 50 50 ~SpellCheckRequest(); 51 51 52 static PassRefPtr<SpellCheckRequest> create(TextCheckingTypeMask, PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange); 52 static PassRefPtr<SpellCheckRequest> create(TextCheckingTypeMask, TextCheckingProcessType, PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange); 53 54 TextCheckingRequest textCheckingRequest() const; 53 55 54 56 void setSequence(int sequence) { m_sequence = sequence; } … … 58 60 const String& text() const { return m_text; } 59 61 TextCheckingTypeMask mask() const { return m_mask; } 62 TextCheckingProcessType processType() const { return m_processType; } 60 63 PassRefPtr<Element> rootEditableElement() const { return m_rootEditableElement; } 61 64 private: 62 63 65 int m_sequence; 66 String m_text; 67 TextCheckingTypeMask m_mask; 68 TextCheckingProcessType m_processType; 64 69 RefPtr<Range> m_checkingRange; 65 70 RefPtr<Range> m_paragraphRange; 66 String m_text;67 TextCheckingTypeMask m_mask;68 71 RefPtr<Element> m_rootEditableElement; 69 72 }; … … 110 113 }; 111 114 115 inline TextCheckingRequest SpellCheckRequest::textCheckingRequest() const 116 { 117 return TextCheckingRequest(m_sequence, m_text, m_mask, m_processType); 118 } 119 112 120 } // namespace WebCore 113 121 -
trunk/Source/WebCore/loader/EmptyClients.h
r108462 r108772 433 433 434 434 virtual void getGuessesForWord(const String&, const String&, Vector<String>&) { } 435 virtual void requestCheckingOfString(SpellChecker*, int, TextCheckingTypeMask, const String&) { }435 virtual void requestCheckingOfString(SpellChecker*, const TextCheckingRequest&) { } 436 436 }; 437 437 -
trunk/Source/WebCore/platform/text/TextCheckerClient.h
r95901 r108772 38 38 39 39 class SpellChecker; 40 class TextCheckingRequest; 40 41 41 42 struct GrammarDetail { … … 72 73 // identification. Noramlly it's the text surrounding the "word" for which we are getting correction suggestions. 73 74 virtual void getGuessesForWord(const String& word, const String& context, Vector<String>& guesses) = 0; 74 virtual void requestCheckingOfString(SpellChecker*, int, TextCheckingTypeMask, const String&) = 0;75 virtual void requestCheckingOfString(SpellChecker*, const TextCheckingRequest&) = 0; 75 76 }; 76 77 -
trunk/Source/WebCore/platform/text/TextChecking.h
r95901 r108772 32 32 #define TextChecking_h 33 33 34 #include <wtf/text/WTFString.h> 35 34 36 namespace WebCore { 35 37 … … 62 64 typedef unsigned TextCheckingTypeMask; 63 65 66 enum TextCheckingProcessType { 67 TextCheckingProcessBatch, 68 TextCheckingProcessIncremental 69 }; 70 71 class TextCheckingRequest { 72 public: 73 TextCheckingRequest(int sequence, String text, TextCheckingTypeMask mask, TextCheckingProcessType processType) 74 : m_sequence(sequence) 75 , m_text(text) 76 , m_mask(mask) 77 , m_processType(processType) 78 { 79 } 80 81 void setSequence(int sequence) { m_sequence = sequence; } 82 int sequence() const { return m_sequence; } 83 String text() const { return m_text; } 84 TextCheckingTypeMask mask() const { return m_mask; } 85 TextCheckingProcessType processType() const { return m_processType; } 86 87 private: 88 int m_sequence; 89 String m_text; 90 TextCheckingTypeMask m_mask; 91 TextCheckingProcessType m_processType; 92 }; 93 64 94 } 65 95 -
trunk/Source/WebKit/blackberry/ChangeLog
r108763 r108772 1 2012-02-24 Shinya Kawanaka <shinyak@chromium.org> 2 3 SpellCheckRequest needs to know the context where the spellcheck happened. 4 https://bugs.webkit.org/show_bug.cgi?id=79320 5 6 Reviewed by Hajime Morita. 7 8 * WebCoreSupport/EditorClientBlackBerry.cpp: 9 (WebCore::EditorClientBlackBerry::requestCheckingOfString): 10 * WebCoreSupport/EditorClientBlackBerry.h: 11 (EditorClientBlackBerry): 12 1 13 2012-02-24 Charles Wei <charles.wei@torchmobile.com.cn> 2 14 -
trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp
r108462 r108772 559 559 } 560 560 561 void EditorClientBlackBerry::requestCheckingOfString(SpellChecker*, int, TextCheckingTypeMask, const String&)561 void EditorClientBlackBerry::requestCheckingOfString(SpellChecker*, const TextCheckingRequest&) 562 562 { 563 563 notImplemented(); -
trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.h
r108462 r108772 85 85 virtual void checkGrammarOfString(const UChar*, int, Vector<GrammarDetail, 0u>&, int*, int*); 86 86 virtual void getGuessesForWord(const String&, const String&, Vector<String>&); 87 virtual void requestCheckingOfString(SpellChecker*, int, TextCheckingTypeMask, const String&);87 virtual void requestCheckingOfString(SpellChecker*, const TextCheckingRequest&); 88 88 89 89 virtual TextCheckerClient* textChecker(); -
trunk/Source/WebKit/chromium/ChangeLog
r108732 r108772 1 2012-02-24 Shinya Kawanaka <shinyak@chromium.org> 2 3 SpellCheckRequest needs to know the context where the spellcheck happened. 4 https://bugs.webkit.org/show_bug.cgi?id=79320 5 6 Reviewed by Hajime Morita. 7 8 * src/EditorClientImpl.cpp: 9 (WebKit::EditorClientImpl::requestCheckingOfString): 10 * src/EditorClientImpl.h: 11 (EditorClientImpl): 12 * src/WebFrameImpl.cpp: 13 (WebKit::WebFrameImpl::requestTextChecking): 14 1 15 2012-02-23 Sheriff Bot <webkit.review.bot@gmail.com> 2 16 -
trunk/Source/WebKit/chromium/src/EditorClientImpl.cpp
r108462 r108772 730 730 } 731 731 732 void EditorClientImpl::requestCheckingOfString(SpellChecker* sender, int identifier, TextCheckingTypeMask, const String& text)732 void EditorClientImpl::requestCheckingOfString(SpellChecker* sender, const WebCore::TextCheckingRequest& request) 733 733 { 734 734 if (m_webView->spellCheckClient()) 735 m_webView->spellCheckClient()->requestCheckingOfText( text, new WebTextCheckingCompletionImpl(identifier, sender));735 m_webView->spellCheckClient()->requestCheckingOfText(request.text(), new WebTextCheckingCompletionImpl(request.sequence(), sender)); 736 736 } 737 737 -
trunk/Source/WebKit/chromium/src/EditorClientImpl.h
r108462 r108772 110 110 virtual void willSetInputMethodState(); 111 111 virtual void setInputMethodState(bool enabled); 112 virtual void requestCheckingOfString(WebCore::SpellChecker*, int, WebCore::TextCheckingTypeMask, const WTF::String&);112 virtual void requestCheckingOfString(WebCore::SpellChecker*, const WebCore::TextCheckingRequest&); 113 113 114 114 virtual WebCore::TextCheckerClient* textChecker() { return this; } -
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
r107682 r108772 1302 1302 RefPtr<Range> rangeToCheck = rangeOfContents(const_cast<Element*>(webElem.constUnwrap<Element>())); 1303 1303 1304 frame()->editor()->spellChecker()->requestCheckingFor(SpellCheckRequest::create(TextCheckingTypeSpelling | TextCheckingTypeGrammar, rangeToCheck, rangeToCheck));1304 frame()->editor()->spellChecker()->requestCheckingFor(SpellCheckRequest::create(TextCheckingTypeSpelling | TextCheckingTypeGrammar, TextCheckingProcessBatch, rangeToCheck, rangeToCheck)); 1305 1305 } 1306 1306 -
trunk/Source/WebKit/efl/ChangeLog
r108562 r108772 1 2012-02-24 Shinya Kawanaka <shinyak@chromium.org> 2 3 SpellCheckRequest needs to know the context where the spellcheck happened. 4 https://bugs.webkit.org/show_bug.cgi?id=79320 5 6 Reviewed by Hajime Morita. 7 8 * WebCoreSupport/EditorClientEfl.h: 9 (WebCore::EditorClientEfl::requestCheckingOfString): 10 1 11 2012-02-21 Ryosuke Niwa <rniwa@webkit.org> 2 12 -
trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h
r108462 r108772 121 121 virtual void willSetInputMethodState(); 122 122 virtual void setInputMethodState(bool enabled); 123 virtual void requestCheckingOfString(WebCore::SpellChecker*, int, WebCore::TextCheckingTypeMask, const WTF::String&) { }123 virtual void requestCheckingOfString(WebCore::SpellChecker*, const WebCore::TextCheckingRequest&) { } 124 124 virtual TextCheckerClient* textChecker() { return this; } 125 125 -
trunk/Source/WebKit/gtk/ChangeLog
r108628 r108772 1 2012-02-24 Shinya Kawanaka <shinyak@chromium.org> 2 3 SpellCheckRequest needs to know the context where the spellcheck happened. 4 https://bugs.webkit.org/show_bug.cgi?id=79320 5 6 Reviewed by Hajime Morita. 7 8 * WebCoreSupport/TextCheckerClientGtk.h: 9 (WebKit::TextCheckerClientGtk::requestCheckingOfString): 10 1 11 2012-02-23 ChangSeok Oh <shivamidow@gmail.com> 2 12 -
trunk/Source/WebKit/gtk/WebCoreSupport/TextCheckerClientGtk.h
r95901 r108772 49 49 virtual void checkGrammarOfString(const UChar*, int length, WTF::Vector<WebCore::GrammarDetail>&, int* badGrammarLocation, int* badGrammarLength); 50 50 virtual void getGuessesForWord(const WTF::String& word, const WTF::String& context, WTF::Vector<WTF::String>& guesses); 51 virtual void requestCheckingOfString(WebCore::SpellChecker*, int, WebCore::TextCheckingTypeMask, const WTF::String&) {}51 virtual void requestCheckingOfString(WebCore::SpellChecker*, const WebCore::TextCheckingRequest&) { } 52 52 53 53 void updateSpellCheckingLanguage(const char*); -
trunk/Source/WebKit/mac/ChangeLog
r108730 r108772 1 2012-02-24 Shinya Kawanaka <shinyak@chromium.org> 2 3 SpellCheckRequest needs to know the context where the spellcheck happened. 4 https://bugs.webkit.org/show_bug.cgi?id=79320 5 6 Reviewed by Hajime Morita. 7 8 * WebCoreSupport/WebEditorClient.h: 9 * WebCoreSupport/WebEditorClient.mm: 10 (WebEditorClient::requestCheckingOfString): 11 1 12 2012-02-23 Andy Estes <aestes@apple.com> 2 13 -
trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h
r108462 r108772 136 136 virtual void willSetInputMethodState() OVERRIDE; 137 137 virtual void setInputMethodState(bool enabled) OVERRIDE; 138 virtual void requestCheckingOfString(WebCore::SpellChecker*, int, WebCore::TextCheckingTypeMask, const WTF::String&) OVERRIDE;138 virtual void requestCheckingOfString(WebCore::SpellChecker*, const WebCore::TextCheckingRequest&) OVERRIDE; 139 139 #if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD) 140 140 virtual void showCorrectionPanel(WebCore::CorrectionPanelInfo::PanelType, const WebCore::FloatRect& boundingBoxOfReplacedString, const String& replacedString, const String& replacementString, const Vector<String>& alternativeReplacementStrings) OVERRIDE; -
trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm
r108462 r108772 973 973 #endif 974 974 975 void WebEditorClient::requestCheckingOfString(WebCore::SpellChecker* sender, int sequence, WebCore::TextCheckingTypeMask checkingTypes, const String& text)975 void WebEditorClient::requestCheckingOfString(WebCore::SpellChecker* sender, const WebCore::TextCheckingRequest& request) 976 976 { 977 977 #ifndef BUILDING_ON_LEOPARD 978 NSRange range = NSMakeRange(0, text.length());978 NSRange range = NSMakeRange(0, request.text().length()); 979 979 NSRunLoop* currentLoop = [NSRunLoop currentRunLoop]; 980 [[NSSpellChecker sharedSpellChecker] requestCheckingOfString: text range:range types:NSTextCheckingAllSystemTypes options:0 inSpellDocumentWithTag:0980 [[NSSpellChecker sharedSpellChecker] requestCheckingOfString:request.text() range:range types:NSTextCheckingAllSystemTypes options:0 inSpellDocumentWithTag:0 981 981 completionHandler:^(NSInteger, NSArray* results, NSOrthography*, NSInteger) { 982 982 [currentLoop performSelector:@selector(perform) 983 target:[[[WebEditorSpellCheckResponder alloc] initWithSender:sender sequence: sequence types:checkingTypesresults:results] autorelease]983 target:[[[WebEditorSpellCheckResponder alloc] initWithSender:sender sequence:request.sequence() types:request.mask() results:results] autorelease] 984 984 argument:nil order:0 modes:[NSArray arrayWithObject:NSDefaultRunLoopMode]]; 985 985 }]; -
trunk/Source/WebKit/qt/ChangeLog
r108643 r108772 1 2012-02-24 Shinya Kawanaka <shinyak@chromium.org> 2 3 SpellCheckRequest needs to know the context where the spellcheck happened. 4 https://bugs.webkit.org/show_bug.cgi?id=79320 5 6 Reviewed by Hajime Morita. 7 8 * WebCoreSupport/TextCheckerClientQt.h: 9 (WebCore::TextCheckerClientQt::requestCheckingOfString): 10 1 11 2012-02-23 Simon Hausmann <simon.hausmann@nokia.com> 2 12 -
trunk/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.h
r95901 r108772 48 48 virtual void checkGrammarOfString(const UChar*, int length, Vector<GrammarDetail>&, int* badGrammarLocation, int* badGrammarLength); 49 49 virtual void getGuessesForWord(const String& word, const String& context, Vector<String>& guesses); 50 virtual void requestCheckingOfString(SpellChecker*, int, TextCheckingTypeMask, const String&) { }50 virtual void requestCheckingOfString(SpellChecker*, const TextCheckingRequest&) { } 51 51 52 52 virtual bool isContinousSpellCheckingEnabled(); -
trunk/Source/WebKit/win/ChangeLog
r108562 r108772 1 2012-02-24 Shinya Kawanaka <shinyak@chromium.org> 2 3 SpellCheckRequest needs to know the context where the spellcheck happened. 4 https://bugs.webkit.org/show_bug.cgi?id=79320 5 6 Reviewed by Hajime Morita. 7 8 * WebCoreSupport/WebEditorClient.h: 9 (WebEditorClient::requestCheckingOfString): 10 (WebEditorClient): 11 1 12 2012-02-21 Ryosuke Niwa <rniwa@webkit.org> 2 13 -
trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.h
r108462 r108772 111 111 virtual void willSetInputMethodState(); 112 112 virtual void setInputMethodState(bool); 113 virtual void requestCheckingOfString(WebCore::SpellChecker*, int, WebCore::TextCheckingTypeMask, const WTF::String&) {} 113 virtual void requestCheckingOfString(WebCore::SpellChecker*, const WebCore::TextCheckingRequest&) { } 114 114 115 virtual WebCore::TextCheckerClient* textChecker() { return this; } 115 116 -
trunk/Source/WebKit/wince/ChangeLog
r108633 r108772 1 2012-02-24 Shinya Kawanaka <shinyak@chromium.org> 2 3 SpellCheckRequest needs to know the context where the spellcheck happened. 4 https://bugs.webkit.org/show_bug.cgi?id=79320 5 6 Reviewed by Hajime Morita. 7 8 * WebCoreSupport/EditorClientWinCE.h: 9 (WebKit::EditorClientWinCE::requestCheckingOfString): 10 1 11 2012-02-23 Patrick Gansterer <paroga@webkit.org> 2 12 -
trunk/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.h
r108633 r108772 102 102 virtual void willSetInputMethodState(); 103 103 virtual void setInputMethodState(bool); 104 virtual void requestCheckingOfString(WebCore::SpellChecker*, int, WebCore::TextCheckingTypeMask, const WTF::String&) {}104 virtual void requestCheckingOfString(WebCore::SpellChecker*, const WebCore::TextCheckingRequest&) { } 105 105 virtual WebCore::TextCheckerClient* textChecker() { return this; } 106 106 -
trunk/Source/WebKit/wx/ChangeLog
r108562 r108772 1 2012-02-24 Shinya Kawanaka <shinyak@chromium.org> 2 3 SpellCheckRequest needs to know the context where the spellcheck happened. 4 https://bugs.webkit.org/show_bug.cgi?id=79320 5 6 Reviewed by Hajime Morita. 7 8 * WebKitSupport/EditorClientWx.h: 9 (WebCore::EditorClientWx::requestCheckingOfString): 10 1 11 2012-02-21 Ryosuke Niwa <rniwa@webkit.org> 2 12 -
trunk/Source/WebKit/wx/WebKitSupport/EditorClientWx.h
r108462 r108772 115 115 virtual void willSetInputMethodState(); 116 116 virtual void setInputMethodState(bool enabled); 117 virtual void requestCheckingOfString(WebCore::SpellChecker*, int, WebCore::TextCheckingTypeMask, const WTF::String&) {}117 virtual void requestCheckingOfString(WebCore::SpellChecker*, const WebCore::TextCheckingRequest&) { } 118 118 virtual TextCheckerClient* textChecker() { return this; } 119 119 -
trunk/Source/WebKit2/ChangeLog
r108771 r108772 1 2012-02-24 Shinya Kawanaka <shinyak@chromium.org> 2 3 SpellCheckRequest needs to know the context where the spellcheck happened. 4 https://bugs.webkit.org/show_bug.cgi?id=79320 5 6 Reviewed by Hajime Morita. 7 8 * WebProcess/WebCoreSupport/WebEditorClient.cpp: 9 (WebKit::WebEditorClient::requestCheckingOfString): 10 * WebProcess/WebCoreSupport/WebEditorClient.h: 11 1 12 2012-02-23 Kenneth Rohde Christiansen <kenneth@webkit.org> 2 13 -
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp
r108462 r108772 448 448 } 449 449 450 void WebEditorClient::requestCheckingOfString(WebCore::SpellChecker*, int, WebCore::TextCheckingTypeMask, const WTF::String&)450 void WebEditorClient::requestCheckingOfString(WebCore::SpellChecker*, const WebCore::TextCheckingRequest&) 451 451 { 452 452 notImplemented(); -
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h
r108462 r108772 142 142 virtual void willSetInputMethodState() OVERRIDE; 143 143 virtual void setInputMethodState(bool enabled) OVERRIDE; 144 virtual void requestCheckingOfString(WebCore::SpellChecker*, int, WebCore::TextCheckingTypeMask, const WTF::String&) OVERRIDE;144 virtual void requestCheckingOfString(WebCore::SpellChecker*, const WebCore::TextCheckingRequest&) OVERRIDE; 145 145 #if PLATFORM(MAC) && !defined(BUILDING_ON_SNOW_LEOPARD) 146 146 virtual void showCorrectionPanel(WebCore::CorrectionPanelInfo::PanelType, const WebCore::FloatRect& boundingBoxOfReplacedString, const String& replacedString, const String& replacementString, const Vector<String>& alternativeReplacementStrings) OVERRIDE;
Note: See TracChangeset
for help on using the changeset viewer.