Changeset 108839 in webkit


Ignore:
Timestamp:
Feb 24, 2012 1:06:27 PM (12 years ago)
Author:
enne@google.com
Message:

Fix flaky tests by removing call to dumpResourceResponseMIMETypes
​https://bugs.webkit.org/show_bug.cgi?id=79505

Reviewed by Daniel Bates.

It appears to be a race condition (on Chromium at least) between when
script executes and the style sheet resource response occurs. This
prevents some of the text to be output if the response occurs before
the call to set the flag to dump responses. Since the tests themselves
already test the results of loading stylesheets properly, this extra
text is superfluous and can be removed.

This change modifies all tests using link-load-utilities.js to dump
stylesheet resource responses. Other tests are using
dumpResponseResponseMIMEType, but for things other than stylesheets.

  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt:
  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt:
  • fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt:
  • fast/dom/HTMLLinkElement/link-onload-expected.txt:
  • fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt:
  • fast/dom/HTMLLinkElement/link-onload2-expected.txt:
  • fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt:
  • fast/dom/HTMLLinkElement/resources/link-load-utilities.js:
  • fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt:
Location:
trunk/LayoutTests
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r108835 r108839  
     12012-02-24  Adrienne Walker  <enne@google.com>
     2
     3        Fix flaky tests by removing call to dumpResourceResponseMIMETypes
     4        https://bugs.webkit.org/show_bug.cgi?id=79505
     5
     6        Reviewed by Daniel Bates.
     7
     8        It appears to be a race condition (on Chromium at least) between when
     9        script executes and the style sheet resource response occurs. This
     10        prevents some of the text to be output if the response occurs before
     11        the call to set the flag to dump responses. Since the tests themselves
     12        already test the results of loading stylesheets properly, this extra
     13        text is superfluous and can be removed.
     14
     15        This change modifies all tests using link-load-utilities.js to dump
     16        stylesheet resource responses. Other tests are using
     17        dumpResponseResponseMIMEType, but for things other than stylesheets.
     18
     19        * fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt:
     20        * fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt:
     21        * fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt:
     22        * fast/dom/HTMLLinkElement/link-onload-expected.txt:
     23        * fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt:
     24        * fast/dom/HTMLLinkElement/link-onload2-expected.txt:
     25        * fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt:
     26        * fast/dom/HTMLLinkElement/resources/link-load-utilities.js:
     27        * fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt:
     28
    1292012-02-24  Elliot Poger  <epoger@google.com>
    230

  • trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt

    r108809 r108839  
    1 stylesheet-with-existent-and-non-existent-import.css has MIME type text/css
    2 stylesheet.css has MIME type text/css
    31This tests that an Error event is fired at an HTML Link element when its style sheet fails to load an @import'ed style sheet (regardless of whether it successfully loaded another @import'ed style sheet). This test PASSED if there are only PASS messages below. Otherwise, it FAILED.
    42

  • trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt

    r108809 r108839  
    1 stylesheet-with-non-existent-import.css has MIME type text/css
    21This tests that an Error event is fired at an HTML Link element when its style sheet fails to load an @import'ed style sheet. This test PASSED if there are only PASS messages below. Otherwise, it FAILED.
    32

  • trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt

    r108809 r108839  
    1 stylesheet.css has MIME type text/css
    21This tests that a Load event for an HTML Link element comes before the Load event for the window. This test PASSED if you see the word PASS below. Otherwise, it FAILED.
    32

  • trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload-expected.txt

    r108809 r108839  
    1 stylesheet.css has MIME type text/css
    21This tests that a Load event is fired at an HTML Link element once it loads a style sheet. This test PASSED if you see the word PASS below. Otherwise, it FAILED.
    32

  • trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt

    r108809 r108839  
    1 stylesheet-with-import.css has MIME type text/css
    2 stylesheet.css has MIME type text/css
    31This tests that a Load event is fired at an HTML Link element once all @import'ed stylesheets are loaded by a style sheet. This test PASSED if there are only PASS messages below. Otherwise, it FAILED.
    42

  • trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onload2-expected.txt

    r108809 r108839  
    1 stylesheet.css has MIME type text/css
    21This tests that we fire two Load events on a page with two HTML Link elements and that both events are fired before the Load event for the window is dispatched. This test PASSED if you see the word PASS below. Otherwise, it FAILED.
    32

  • trunk/LayoutTests/fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt

    r108809 r108839  
    1 stylesheet.css has MIME type text/css
    21This tests that a Load event is fired at a programmatically inserted HTML Link element once it loads its style sheet. This test PASSED if you see the word PASS below. Otherwise, it FAILED.
    32

  • trunk/LayoutTests/fast/dom/HTMLLinkElement/resources/link-load-utilities.js

    r108809 r108839  
    11if (window.layoutTestController) {
    22  layoutTestController.dumpAsText();
    3   layoutTestController.dumpResourceResponseMIMETypes();
    43  layoutTestController.waitUntilDone();
    54}

  • trunk/LayoutTests/fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt

    r108809 r108839  
    1 stylesheet.css has MIME type text/css
    21This tests that a Error event is fired at an HTML Style element whose @import style sheet failed to load. This test PASSED if there are only PASS messages below. Otherwise, it FAILED.
    32
Note: See TracChangeset for help on using the changeset viewer.