Changeset 109029 in webkit


Ignore:
Timestamp:
Feb 27, 2012 3:22:32 PM (12 years ago)
Author:
haraken@chromium.org
Message:

Remove [ConstructorParameters] from IDL files that have [Constructor]
​https://bugs.webkit.org/show_bug.cgi?id=79643

Reviewed by Adam Barth.

This patch removes [ConstructorParameters] from IDL files that have [Constructor],
since CodeGeneratorJS.pm can automatically detect the number of constructor
arguments by the [Constructor(...)] signature.

Test: fast/js/constructor-length.html

  • Modules/mediastream/PeerConnection.idl:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

  • css/WebKitCSSMatrix.idl:
  • page/EventSource.idl:
  • workers/SharedWorker.idl:
  • workers/Worker.idl:
Location:
trunk/Source/WebCore
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r109028 r109029  
     12012-02-27  Kentaro Hara  <haraken@chromium.org>
     2
     3        Remove [ConstructorParameters] from IDL files that have [Constructor]
     4        https://bugs.webkit.org/show_bug.cgi?id=79643
     5
     6        Reviewed by Adam Barth.
     7
     8        This patch removes [ConstructorParameters] from IDL files that have [Constructor],
     9        since CodeGeneratorJS.pm can automatically detect the number of constructor
     10        arguments by the [Constructor(...)] signature.
     11
     12        Test: fast/js/constructor-length.html
     13
     14        * Modules/mediastream/PeerConnection.idl:
     15        * bindings/scripts/CodeGeneratorJS.pm:
     16        (GenerateConstructorDefinition):
     17        * css/WebKitCSSMatrix.idl:
     18        * page/EventSource.idl:
     19        * workers/SharedWorker.idl:
     20        * workers/Worker.idl:
     21
    1222012-02-27  Julien Chaffraix  <jchaffraix@webkit.org>
    223

  • trunk/Source/WebCore/Modules/mediastream/PeerConnection.idl

    r108297 r109029  
    2828        Conditional=MEDIA_STREAM,
    2929        ActiveDOMObject,
    30         ConstructorParameters=2,
    3130        Constructor(in DOMString serverConfiguration, in [Callback] SignalingCallback signalingCallback),
    3231        CallWith=ScriptExecutionContext,

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r108757 r109029  
    33693369        if (IsConstructorTemplate($dataNode, "Event")) {
    33703370            $numberOfConstructorParameters = 2;
    3371         } elsif ($dataNode->extendedAttributes->{"Constructor"} and !$dataNode->extendedAttributes->{"CustomConstructor"} and !$dataNode->extendedAttributes->{"JSCustomConstructor"}) {
     3371        } elsif ($dataNode->extendedAttributes->{"Constructor"}) {
    33723372            $numberOfConstructorParameters = @{$dataNode->constructor->parameters};
    33733373        }

  • trunk/Source/WebCore/css/WebKitCSSMatrix.idl

    r107304 r109029  
    2828    // Introduced in DOM Level ?:
    2929    interface [
    30         ConstructorParameters=1,
    3130        Constructor(in [Optional=DefaultIsNullString] DOMString cssValue),
    3231        ConstructorRaisesException,

  • trunk/Source/WebCore/page/EventSource.idl

    r106737 r109029  
    3434    interface [
    3535        ActiveDOMObject,
    36         ConstructorParameters=1,
    3736        Constructor(in DOMString scriptUrl),
    3837        CallWith=ScriptExecutionContext,

  • trunk/Source/WebCore/workers/SharedWorker.idl

    r107768 r109029  
    3636        ActiveDOMObject,
    3737        JSCustomConstructor,
    38         ConstructorParameters=2,
    3938        Constructor(in DOMString scriptURL, in [Optional=DefaultIsNullString] DOMString name),
    4039        CallWith=ScriptExecutionContext,

  • trunk/Source/WebCore/workers/Worker.idl

    r107768 r109029  
    3232        ActiveDOMObject,
    3333        JSCustomConstructor,
    34         ConstructorParameters=1,
    3534        Constructor(in DOMString scriptUrl),
    3635        CallWith=ScriptExecutionContext,
Note: See TracChangeset for help on using the changeset viewer.