Changeset 109054 in webkit

Timestamp:

Feb 27, 2012 5:51:32 PM (12 years ago)

Author:

adamk@chromium.org

Message:

Always notify subtree of removal in ContainerNode::removeChildren
​https://bugs.webkit.org/show_bug.cgi?id=79316

Reviewed by Ryosuke Niwa.

Source/WebCore:

In the inDocument case, Node::removedFromDocument is called.
In the out-of-document case, call ContainerNode::removedFromTree to ensure,
e.g., form-associated elements are properly disconnected.

Test: fast/forms/form-associated-element-removal.html

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren):

LayoutTests:

• fast/forms/form-associated-element-removal-expected.txt: Added.
• fast/forms/form-associated-element-removal.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/form-associated-element-removal-expected.txt (added)
• LayoutTests/fast/forms/form-associated-element-removal.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/ContainerNode.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-27  Adam Klein  <adamk@chromium.org>
+
+        Always notify subtree of removal in ContainerNode::removeChildren
+        https://bugs.webkit.org/show_bug.cgi?id=79316
+
+        Reviewed by Ryosuke Niwa.
+
+        * fast/forms/form-associated-element-removal-expected.txt: Added.
+        * fast/forms/form-associated-element-removal.html: Added.
+
 2012-02-27  Adrienne Walker  <enne@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-27  Adam Klein  <adamk@chromium.org>
+
+        Always notify subtree of removal in ContainerNode::removeChildren
+        https://bugs.webkit.org/show_bug.cgi?id=79316
+
+        Reviewed by Ryosuke Niwa.
+
+        In the inDocument case, Node::removedFromDocument is called.
+        In the out-of-document case, call ContainerNode::removedFromTree to ensure,
+        e.g., form-associated elements are properly disconnected.
+
+        Test: fast/forms/form-associated-element-removal.html
+
+        * dom/ContainerNode.cpp:
+        (WebCore::ContainerNode::removeChildren):
+
 2012-02-27  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/dom/ContainerNode.cpp

@@ -583 +583 @@
         if (removedChild->inDocument())
             removedChild->removedFromDocument();
-        // removeChild() calls removedFromTree(true) if the child was not in the
-        // document. There is no explanation for this discrepancy between removeChild()
-        // and its optimized version removeChildren().
+        else if (removedChild->isContainerNode())
+            toContainerNode(removedChild)->removedFromTree(true);
     }