Changeset 109056 in webkit


Ignore:
Timestamp:
Feb 27, 2012 6:05:13 PM (12 years ago)
Author:
dpranke@chromium.org
Message:

nrwt: log multiline stderr/crash output properly
https://bugs.webkit.org/show_bug.cgi?id=79722

Reviewed by Adam Barth.

This cleans up some nits in the log output to make things
slightly easier to read (every line gets timestamped, etc.).

Also tweaks the log message for pixel hash mismatches.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._handle_error):
(SingleTestRunner._compare_image):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r109053 r109056  
     12012-02-27  Dirk Pranke  <dpranke@chromium.org>
     2
     3        nrwt: log multiline stderr/crash output properly
     4        https://bugs.webkit.org/show_bug.cgi?id=79722
     5
     6        Reviewed by Adam Barth.
     7
     8        This cleans up some nits in the log output to make things
     9        slightly easier to read (every line gets timestamped, etc.).
     10
     11        Also tweaks the log message for pixel hash mismatches.
     12
     13        * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
     14        (SingleTestRunner._handle_error):
     15        (SingleTestRunner._compare_image):
     16
    1172012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
    218
  • trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

    r108144 r109056  
    199199        if driver_output.crash:
    200200            failures.append(test_failures.FailureCrash(bool(reference_filename)))
    201             _log.debug("%s Stacktrace for %s:\n%s" % (self._worker_name, testname,
    202                                                       driver_output.error))
     201            if driver_output.error:
     202                _log.debug("%s %s crashed, stack trace:" % (self._worker_name, testname))
     203            else:
     204                _log.debug("%s %s crashed, no stack trace" % (self._worker_name, testname))
    203205        elif driver_output.error:
    204             _log.debug("%s %s output stderr lines:\n%s" % (self._worker_name, testname,
    205                                                            driver_output.error))
     206            _log.debug("%s %s output stderr lines:" % (self._worker_name, testname))
     207        for line in driver_output.error.splitlines():
     208            _log.debug("  %s" % line)
    206209        return failures
    207210
     
    267270            else:
    268271                # See https://bugs.webkit.org/show_bug.cgi?id=69444 for why this isn't a full failure.
    269                 _log.warning('%s -> pixel hash failed (but pixel test still passes)' % self._test_name)
     272                _log.warning('  %s -> pixel hash failed (but pixel test still passes)' % self._test_name)
    270273        return failures
    271274
Note: See TracChangeset for help on using the changeset viewer.