Changeset 109066 in webkit


Ignore:
Timestamp:
Feb 27, 2012 7:52:02 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[chromium] Remove media tests from ChromiumGpu configurations
https://bugs.webkit.org/show_bug.cgi?id=79720

Patch by James Robinson <jamesr@chromium.org> on 2012-02-27
Reviewed by Adam Barth.

We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
composited playback path via tests in the compositing/ directory.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(_default_tests_paths):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r109056 r109066  
     12012-02-27  James Robinson  <jamesr@chromium.org>
     2
     3        [chromium] Remove media tests from ChromiumGpu configurations
     4        https://bugs.webkit.org/show_bug.cgi?id=79720
     5
     6        Reviewed by Adam Barth.
     7
     8        We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
     9        composited playback path via tests in the compositing/ directory.
     10
     11        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
     12        (_default_tests_paths):
     13        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
     14        (ChromiumGpuTest.test_default_tests_paths):
     15        (ChromiumGpuTest.test_test_files):
     16
    1172012-02-27  Dirk Pranke  <dpranke@chromium.org>
    218
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py

    r108974 r109066  
    5151
    5252def _default_tests_paths(port):
    53     paths = []
    54     if port.name() != 'chromium-gpu-mac-leopard':
    55         # Only run tests requiring accelerated compositing on platforms that
    56         # support it.
    57         # FIXME: we should add the above paths here as well but let's test
    58         # the waters with media first.
    59         paths += ['media']
    60 
    61     paths += ['fast/canvas', 'canvas/philip']
    62 
    63     if not paths:
    64         # FIXME: This is a hack until we can turn off the webkit_gpu
    65         # tests on the bots. If paths is empty, port.tests()
    66         # finds *everything*. However, we have to return something,
    67         # or NRWT thinks there's something wrong. So, we return a single
    68         # short directory. See https://bugs.webkit.org/show_bug.cgi?id=72498.
    69         paths = ['fast/html']
    70 
    71     return paths
     53    return ['fast/canvas', 'canvas/philip']
    7254
    7355
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py

    r104739 r109066  
    110110            return chromium_gpu._default_tests_paths(PortFactory(MockSystemHost()).get(port_name))
    111111
    112         self.assertEqual(test_paths('chromium-gpu-linux'), ['media', 'fast/canvas', 'canvas/philip'])
    113         self.assertEqual(test_paths('chromium-gpu-mac-leopard'), ['fast/canvas', 'canvas/philip'])
     112        self.assertEqual(test_paths('chromium-gpu-linux'), ['fast/canvas', 'canvas/philip'])
    114113
    115114    def test_test_files(self):
     
    119118            '/mock-checkout/LayoutTests/fast/canvas/test.html': '',
    120119            '/mock-checkout/LayoutTests/fast/html/test.html': '',
    121             '/mock-checkout/LayoutTests/media/test.html': '',
    122120            '/mock-checkout/LayoutTests/foo/bar.html': '',
    123121        }
     
    127125            return PortFactory(host).get(port_name).tests([])
    128126
    129         self.assertEqual(test_paths('chromium-gpu-linux'), set(['canvas/philip/test.html', 'fast/canvas/test.html', 'media/test.html']))
    130         self.assertEqual(test_paths('chromium-gpu-mac-leopard'), set(['canvas/philip/test.html', 'fast/canvas/test.html']))
     127        self.assertEqual(test_paths('chromium-gpu-linux'), set(['canvas/philip/test.html', 'fast/canvas/test.html']))
    131128
    132129
Note: See TracChangeset for help on using the changeset viewer.